From: Stephen Hemminger <stephen@networkplumber.org>
To: Rahul Gupta <rahulgupt@linux.microsoft.com>
Cc: dev@dpdk.org, thomas@monjalon.net, bruce.richardson@intel.com,
dmitry.kozliuk@gmail.com, sovaradh@linux.microsoft.com,
okaya@kernel.org, sujithsankar@microsoft.com,
sowmini.varadhan@microsoft.com, krathinavel@microsoft.com,
rahulrgupta27@gmail.com, Rahul Gupta <rahulgupt@microsoft.com>
Subject: Re: [dpdk-dev] [PATCH v3] eal: refactor rte_eal_init into sub-functions
Date: Fri, 19 Jan 2024 14:16:48 -0800 [thread overview]
Message-ID: <20240119141648.4801da19@hermes.local> (raw)
In-Reply-To: <1705683497-25074-1-git-send-email-rahulgupt@linux.microsoft.com>
On Fri, 19 Jan 2024 08:58:17 -0800
Rahul Gupta <rahulgupt@linux.microsoft.com> wrote:
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index 9e4e99e53b..345f3c1c04 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -4531,6 +4531,8 @@ main(int argc, char** argv)
> portid_t port_id;
> uint16_t count;
> int ret;
> + int lcore_id = 0;
> + int main_lcore_id = 0;
These do not need to be initialized, there is assignment
before first usage.
There already exists rte_get_main_lcore() please use that
prev parent reply other threads:[~2024-01-19 22:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-19 16:58 Rahul Gupta
2024-01-19 17:26 ` Bruce Richardson
2024-01-19 22:16 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240119141648.4801da19@hermes.local \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=krathinavel@microsoft.com \
--cc=okaya@kernel.org \
--cc=rahulgupt@linux.microsoft.com \
--cc=rahulgupt@microsoft.com \
--cc=rahulrgupta27@gmail.com \
--cc=sovaradh@linux.microsoft.com \
--cc=sowmini.varadhan@microsoft.com \
--cc=sujithsankar@microsoft.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).