From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0BE0143903; Fri, 19 Jan 2024 23:16:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E855B42D6B; Fri, 19 Jan 2024 23:16:52 +0100 (CET) Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by mails.dpdk.org (Postfix) with ESMTP id 73E7F402AD for <dev@dpdk.org>; Fri, 19 Jan 2024 23:16:51 +0100 (CET) Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-6db05618c1fso1297792b3a.1 for <dev@dpdk.org>; Fri, 19 Jan 2024 14:16:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1705702610; x=1706307410; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Ji0qLgh9EDAL9/KWFOowLYqNJwiDw8wt5M0FG4SmzkU=; b=lhZHVx/ZBSvh5Yow7JJpQkYRQP3C6Tg3ClSi9XzLQo6vOPciZxllA7Q530mEJl8fYm Bj67VLqvr6hcXIele2KN7gy14/26xFozdJ+J8eRW83kNH3Ok+Ga0h0x85HF6rb83O3s/ Ewku3S/Ou2VwzqDvJNgQSOeCpEpUUzj7pK+Pm6G2Qo26EBVXcPo3eLihmTgsen7K07Lk l1F1WBAnbfWe4mWqGj4kHQZYxE4PY8hPizVP8PfICCM6j8s76DE18vKj42giwtpMgrfT LWNFy8vDQesxSXTv1hNlju7rWgDE9VDuHLqpPIEJJq6Ew+uzAOxoiU0teNj/82tkGYsS lsfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705702610; x=1706307410; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ji0qLgh9EDAL9/KWFOowLYqNJwiDw8wt5M0FG4SmzkU=; b=KVNU6uxPkjafSlDHHCS61mXXshmOoSUFCcirzHg04YuzRRUk+HDBdplYDExHJUFRvm Yv6//ENGqHPq7Udup3QEF1kMXnejZlz5O5Zu1/jxfYto48K0VwQ0du/wmG9xkEPwO4o8 DbJ0INSZTB/nfCM+4ataRIHPQF3bHJRYM0E6bSjkCijzQxj93iFckbqvARvD/fXAbaZ3 0l5IuEoIWnyZgroz8RrNUJmhXTrVMgCqHS/C4x533L0eRjHEn8Dcll5VRdZ9LU3DToU2 +OgwHH5pVeTZ41VvF1osa50WhsZmzDAX26xmZFNbKjVFawbfFR+0jxIIHxjheEz0rBEY ZxdQ== X-Gm-Message-State: AOJu0Yyuw2hFkYws4e1GH3nDSboBNEzzjkCqLlzn/orX7vFUzdPYSRwp ISFo32EJDeCQt+UmWPSqlxmTaIGTRJrs0HKGHjl8rJuREEsp7EMc32to7+IGMC0= X-Google-Smtp-Source: AGHT+IG7HiVeoJydzeOUuz948G1L2SP4BYEirHbAKwp2fMI4WqeJbE8qGAaeqMMmPc8UUhKBY8V8qg== X-Received: by 2002:aa7:9829:0:b0:6d9:e91c:a5bc with SMTP id q9-20020aa79829000000b006d9e91ca5bcmr475122pfl.38.1705702610589; Fri, 19 Jan 2024 14:16:50 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id it11-20020a056a00458b00b006dbcd7b4d19sm151817pfb.192.2024.01.19.14.16.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jan 2024 14:16:50 -0800 (PST) Date: Fri, 19 Jan 2024 14:16:48 -0800 From: Stephen Hemminger <stephen@networkplumber.org> To: Rahul Gupta <rahulgupt@linux.microsoft.com> Cc: dev@dpdk.org, thomas@monjalon.net, bruce.richardson@intel.com, dmitry.kozliuk@gmail.com, sovaradh@linux.microsoft.com, okaya@kernel.org, sujithsankar@microsoft.com, sowmini.varadhan@microsoft.com, krathinavel@microsoft.com, rahulrgupta27@gmail.com, Rahul Gupta <rahulgupt@microsoft.com> Subject: Re: [dpdk-dev] [PATCH v3] eal: refactor rte_eal_init into sub-functions Message-ID: <20240119141648.4801da19@hermes.local> In-Reply-To: <1705683497-25074-1-git-send-email-rahulgupt@linux.microsoft.com> References: <1705683497-25074-1-git-send-email-rahulgupt@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Fri, 19 Jan 2024 08:58:17 -0800 Rahul Gupta <rahulgupt@linux.microsoft.com> wrote: > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index 9e4e99e53b..345f3c1c04 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -4531,6 +4531,8 @@ main(int argc, char** argv) > portid_t port_id; > uint16_t count; > int ret; > + int lcore_id = 0; > + int main_lcore_id = 0; These do not need to be initialized, there is assignment before first usage. There already exists rte_get_main_lcore() please use that