DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Subject: [PATCH 0/6] remove incorrect code for loading 16B descriptors
Date: Tue, 23 Jan 2024 11:40:47 +0000	[thread overview]
Message-ID: <20240123114053.172189-1-bruce.richardson@intel.com> (raw)

Inside the AVX2 code paths, there was special case code for loading two
16-byte descriptors simultaneously, if that build-time feature was
enabled. As well as not being enabled by default, these code blocks also
were incorrect as there is no guarantee of the two descriptors being
loaded either atomically or in a defined order. If they were loaded in
an unexpected order the driver logic would break. Therefore we remove
these blocks, and do come cleanup of the following code to remove
indentation.

NOTE: I've split out the removal and subsequent cleanup into separate
patches for ease of review. These can be merged into a single patch on
merge, if so desired.

Bruce Richardson (6):
  net/i40e: remove incorrect 16B descriptor read block
  net/i40e: reduce code indentation
  net/iavf: remove incorrect 16B descriptor read block
  net/ice: remove incorrect 16B descriptor read block
  net/ice: reduce code indent
  net/iavf: reduce code indent

 drivers/net/i40e/i40e_rxtx_vec_avx2.c | 64 ++++++++-------------
 drivers/net/iavf/iavf_rxtx_vec_avx2.c | 80 ++++++++-------------------
 drivers/net/ice/ice_rxtx_vec_avx2.c   | 80 ++++++++-------------------
 3 files changed, 72 insertions(+), 152 deletions(-)

--
2.40.1


             reply	other threads:[~2024-01-23 11:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-23 11:40 Bruce Richardson [this message]
2024-01-23 11:40 ` [PATCH 1/6] net/i40e: remove incorrect 16B descriptor read block Bruce Richardson
2024-01-23 11:40 ` [PATCH 2/6] net/i40e: reduce code indentation Bruce Richardson
2024-01-23 11:40 ` [PATCH 3/6] net/iavf: remove incorrect 16B descriptor read block Bruce Richardson
2024-01-23 11:40 ` [PATCH 4/6] net/iavf: reduce code indent Bruce Richardson
2024-01-23 11:40 ` [PATCH 5/6] net/ice: remove incorrect 16B descriptor read block Bruce Richardson
2024-01-23 11:40 ` [PATCH 6/6] net/ice: reduce code indent Bruce Richardson
2024-02-22 14:57 ` [PATCH 0/6] remove incorrect code for loading 16B descriptors Burakov, Anatoly
2024-02-29 16:06   ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240123114053.172189-1-bruce.richardson@intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).