DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@amd.com>
To: "Sachin Saxena" <sachin.saxena@nxp.com>,
	"Hemant Agrawal" <hemant.agrawal@nxp.com>,
	"Morten Brørup" <mb@smartsharesystems.com>,
	"Chengwen Feng" <fengchengwen@huawei.com>
Cc: <dev@dpdk.org>, <stable@dpdk.org>
Subject: [PATCH v2 3/8] rawdev: fix calloc parameters
Date: Wed, 24 Jan 2024 18:54:00 +0000	[thread overview]
Message-ID: <20240124185406.3598985-3-ferruh.yigit@amd.com> (raw)
In-Reply-To: <20240124185406.3598985-1-ferruh.yigit@amd.com>

gcc [1] generates warning [2] about calloc usage, because calloc
parameter order is wrong, fixing it by replacing parameters.

[1]
gcc (GCC) 14.0.0 20240108 (experimental)

[2]
Compiling C object .../lib/librte_rawdev.a.p/rawdev_rte_rawdev.c.o
../lib/rawdev/rte_rawdev.c: In function ‘handle_dev_dump’:
../lib/rawdev/rte_rawdev.c:659:29:
  error: ‘calloc’ sizes specified with ‘sizeof’ in the earlier
  argument and not in the later argument
  [-Werror=calloc-transposed-args]
  659 |     buf = calloc(sizeof(char), RTE_TEL_MAX_SINGLE_STRING_LEN);
      |                         ^~~~

Fixes: e915d404eb72 ("rawdev: support telemetry dump rawdev")
Cc: stable@dpdk.org

Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com>
---
Cc: fengchengwen@huawei.com
---
 lib/rawdev/rte_rawdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/rawdev/rte_rawdev.c b/lib/rawdev/rte_rawdev.c
index 474bdc95407f..4f8897b63947 100644
--- a/lib/rawdev/rte_rawdev.c
+++ b/lib/rawdev/rte_rawdev.c
@@ -656,7 +656,7 @@ handle_dev_dump(const char *cmd __rte_unused,
 	if (!rte_rawdev_pmd_is_valid_dev(dev_id))
 		return -EINVAL;
 
-	buf = calloc(sizeof(char), RTE_TEL_MAX_SINGLE_STRING_LEN);
+	buf = calloc(RTE_TEL_MAX_SINGLE_STRING_LEN, sizeof(char));
 	if (buf == NULL)
 		return -ENOMEM;
 
-- 
2.34.1


  parent reply	other threads:[~2024-01-24 18:55 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-02 13:08 [PATCH 1/2] pipeline: " Ferruh Yigit
2023-11-02 13:08 ` [PATCH 2/2] net/nfp: " Ferruh Yigit
2023-11-03  1:26   ` Chaoyong He
2023-11-06 14:26 ` [PATCH 1/2] pipeline: " Dumitrescu, Cristian
2024-01-24 18:53 ` [PATCH v2 1/8] " Ferruh Yigit
2024-01-24 18:53   ` [PATCH v2 2/8] net/nfp: " Ferruh Yigit
2024-01-24 19:01     ` Morten Brørup
2024-01-24 18:54   ` Ferruh Yigit [this message]
2024-01-24 18:59     ` [PATCH v2 3/8] rawdev: " Morten Brørup
2024-01-25  2:34     ` fengchengwen
2024-01-25  3:39     ` Hemant Agrawal
2024-01-24 18:54   ` [PATCH v2 4/8] eventdev: " Ferruh Yigit
2024-01-24 18:59     ` Morten Brørup
2024-01-25  2:34     ` fengchengwen
2024-01-24 18:54   ` [PATCH v2 5/8] dmadev: " Ferruh Yigit
2024-01-24 18:59     ` Morten Brørup
2024-01-25  2:35     ` fengchengwen
2024-01-24 18:54   ` [PATCH v2 6/8] common/mlx5: " Ferruh Yigit
2024-01-24 19:01     ` Morten Brørup
2024-01-26 10:12       ` Dariusz Sosnowski
2024-01-24 18:54   ` [PATCH v2 7/8] net/bnx2x: " Ferruh Yigit
2024-01-24 19:01     ` Morten Brørup
2024-01-24 18:54   ` [PATCH v2 8/8] net/sfc: " Ferruh Yigit
2024-01-24 19:02     ` Morten Brørup
2024-01-25  7:10       ` Andrew Rybchenko
2024-01-24 19:00   ` [PATCH v2 1/8] pipeline: " Morten Brørup
2024-02-18 16:08   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240124185406.3598985-3-ferruh.yigit@amd.com \
    --to=ferruh.yigit@amd.com \
    --cc=dev@dpdk.org \
    --cc=fengchengwen@huawei.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=mb@smartsharesystems.com \
    --cc=sachin.saxena@nxp.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).