From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Julien Aube <julien_dpdk@jaube.fr>,
Harish Patil <harish.patil@cavium.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: <dev@dpdk.org>, <stable@dpdk.org>
Subject: [PATCH v2 7/8] net/bnx2x: fix calloc parameters
Date: Wed, 24 Jan 2024 18:54:04 +0000 [thread overview]
Message-ID: <20240124185406.3598985-7-ferruh.yigit@amd.com> (raw)
In-Reply-To: <20240124185406.3598985-1-ferruh.yigit@amd.com>
gcc [1] generates warning [2] about rte_calloc usage, because
rte_calloc parameter order is wrong, fixing it by replacing parameters.
[1]
gcc (GCC) 14.0.1 20240124 (experimental)
[2]
Compiling C object drivers/libtmp_rte_net_bnx2x.a.p/net_bnx2x_bnx2x.c.o
../drivers/net/bnx2x/bnx2x.c: In function ‘bnx2x_alloc_ilt_lines_mem’:
../drivers/net/bnx2x/bnx2x.c:2392:44:
warning: ‘rte_calloc’ sizes specified with ‘sizeof’ in the earlier
argument and not in the later argument [-Wcalloc-transposed-args]
2392 | sizeof(struct ilt_line), ILT_MAX_LINES,
| ^~~~~~
Fixes: 540a211084a7 ("bnx2x: driver core")
Cc: stable@dpdk.org
Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com>
---
Cc: stephen@networkplumber.org
---
drivers/net/bnx2x/bnx2x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c
index c3283c94f38f..597ee4335977 100644
--- a/drivers/net/bnx2x/bnx2x.c
+++ b/drivers/net/bnx2x/bnx2x.c
@@ -2389,7 +2389,7 @@ int bnx2x_alloc_ilt_mem(struct bnx2x_softc *sc)
static int bnx2x_alloc_ilt_lines_mem(struct bnx2x_softc *sc)
{
sc->ilt->lines = rte_calloc("",
- sizeof(struct ilt_line), ILT_MAX_LINES,
+ ILT_MAX_LINES, sizeof(struct ilt_line),
RTE_CACHE_LINE_SIZE);
return sc->ilt->lines == NULL;
}
--
2.34.1
next prev parent reply other threads:[~2024-01-24 18:55 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 13:08 [PATCH 1/2] pipeline: " Ferruh Yigit
2023-11-02 13:08 ` [PATCH 2/2] net/nfp: " Ferruh Yigit
2023-11-03 1:26 ` Chaoyong He
2023-11-06 14:26 ` [PATCH 1/2] pipeline: " Dumitrescu, Cristian
2024-01-24 18:53 ` [PATCH v2 1/8] " Ferruh Yigit
2024-01-24 18:53 ` [PATCH v2 2/8] net/nfp: " Ferruh Yigit
2024-01-24 19:01 ` Morten Brørup
2024-01-24 18:54 ` [PATCH v2 3/8] rawdev: " Ferruh Yigit
2024-01-24 18:59 ` Morten Brørup
2024-01-25 2:34 ` fengchengwen
2024-01-25 3:39 ` Hemant Agrawal
2024-01-24 18:54 ` [PATCH v2 4/8] eventdev: " Ferruh Yigit
2024-01-24 18:59 ` Morten Brørup
2024-01-25 2:34 ` fengchengwen
2024-01-24 18:54 ` [PATCH v2 5/8] dmadev: " Ferruh Yigit
2024-01-24 18:59 ` Morten Brørup
2024-01-25 2:35 ` fengchengwen
2024-01-24 18:54 ` [PATCH v2 6/8] common/mlx5: " Ferruh Yigit
2024-01-24 19:01 ` Morten Brørup
2024-01-26 10:12 ` Dariusz Sosnowski
2024-01-24 18:54 ` Ferruh Yigit [this message]
2024-01-24 19:01 ` [PATCH v2 7/8] net/bnx2x: " Morten Brørup
2024-01-24 18:54 ` [PATCH v2 8/8] net/sfc: " Ferruh Yigit
2024-01-24 19:02 ` Morten Brørup
2024-01-25 7:10 ` Andrew Rybchenko
2024-01-24 19:00 ` [PATCH v2 1/8] pipeline: " Morten Brørup
2024-02-18 16:08 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240124185406.3598985-7-ferruh.yigit@amd.com \
--to=ferruh.yigit@amd.com \
--cc=dev@dpdk.org \
--cc=harish.patil@cavium.com \
--cc=julien_dpdk@jaube.fr \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).