DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: stable@dpdk.org, Sunil Kumar Kori <skori@marvell.com>,
	Rakesh Kudurumalla <rkudurumalla@marvell.com>,
	Nithin Dabilpuram <ndabilpuram@marvell.com>
Subject: [PATCH 2/2] app/graph: fix build reason
Date: Wed, 31 Jan 2024 18:45:52 +0100	[thread overview]
Message-ID: <20240131174552.2601531-2-david.marchand@redhat.com> (raw)
In-Reply-To: <20240131174552.2601531-1-david.marchand@redhat.com>

When a component is disabled, the reason meson variable must be set to
provide an explanation why.

Since epoll is a Linux thing, report that the graph application is only
supported on Linux.

Fixes: 5b21ffb23308 ("app/graph: add CLI framework")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 app/graph/meson.build | 1 +
 1 file changed, 1 insertion(+)

diff --git a/app/graph/meson.build b/app/graph/meson.build
index 5b0f966d99..8aefdf505c 100644
--- a/app/graph/meson.build
+++ b/app/graph/meson.build
@@ -5,6 +5,7 @@
 name = 'graph'
 build = cc.has_header('sys/epoll.h')
 if not build
+    reason = 'only supported on Linux'
     subdir_done()
 endif
 
-- 
2.43.0


  reply	other threads:[~2024-01-31 17:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-31 17:45 [PATCH 1/2] build: fix reasons conflict David Marchand
2024-01-31 17:45 ` David Marchand [this message]
2024-01-31 20:38   ` [PATCH 2/2] app/graph: fix build reason Tyler Retzlaff
2024-02-01  2:31   ` fengchengwen
2024-02-01  9:24   ` David Marchand
2024-01-31 18:02 ` [PATCH 1/2] build: fix reasons conflict Bruce Richardson
2024-01-31 20:36   ` Tyler Retzlaff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240131174552.2601531-2-david.marchand@redhat.com \
    --to=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ndabilpuram@marvell.com \
    --cc=rkudurumalla@marvell.com \
    --cc=skori@marvell.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).