From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 033E243A20;
	Wed, 31 Jan 2024 21:36:55 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id C10984068E;
	Wed, 31 Jan 2024 21:36:54 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id C74E342D78;
 Wed, 31 Jan 2024 21:36:53 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 0671820B2000; Wed, 31 Jan 2024 12:36:53 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 0671820B2000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1706733413;
 bh=ESqzmxlpsTTZ8EXNEyorJ/Mf3E+L/IU5L/4a57sF2XI=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=WpBCeIK0qgZ5clahG9WOQLHwGlnPuZsMeG/r+rGHF3+YC1IREPIfm/RzlnwrFMyKs
 gLP6TMAbe0qBxRCbLCCvRvP1nDg4aPdYi7hKgN8mAg+MfYrnJEYBgJTwplbu/b0RGg
 GKyk5+DgKkmIoNfIDeHjL5Rr4xP/5z7f0WQFosag=
Date: Wed, 31 Jan 2024 12:36:52 -0800
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: David Marchand <david.marchand@redhat.com>, dev@dpdk.org,
 stable@dpdk.org, Kai Ji <kai.ji@intel.com>,
 Markus Theil <markus.theil@tu-ilmenau.de>
Subject: Re: [PATCH 1/2] build: fix reasons conflict
Message-ID: <20240131203652.GA11576@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20240131174552.2601531-1-david.marchand@redhat.com>
 <ZbqLSXx_rmZGNQ6a@bricha3-MOBL.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZbqLSXx_rmZGNQ6a@bricha3-MOBL.ger.corp.intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Wed, Jan 31, 2024 at 06:02:49PM +0000, Bruce Richardson wrote:
> On Wed, Jan 31, 2024 at 06:45:51PM +0100, David Marchand wrote:
> > The "_disable_reason" variables are subject to naming conflicts.
> > 
> > This has been caught while looking at mingw builds where the graph
> > application was skipped with an <unknown_reason> (which is caused by a
> > missing reason variable set in app/graph/meson.build) and the graph
> > library was skipped with the same <unknown_reason> too, even though
> > this library meson does set a proper reason variable.
> > 
> > Example in GHA:
> > 
> > =================
> > Content Skipped
> > =================
> > 
> > apps:
> > 	dumpcap:	not supported on Windows
> > 	graph:	<unknown reason>
> > 	pdump:	not supported on Windows
> > ...
> > 
> > libs:
> > 	acl:	not supported on Windows
> > 	bbdev:	not supported on Windows
> > ...
> > 	graph:	<unknown reason>
> > 	node:	not supported on Windows
> > 
> > Prefix all those variables with the type of component.
> > 
> > Fixes: ecf75180171b ("build: list selected applications")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>