From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A67F443A44; Thu, 1 Feb 2024 22:49:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 37F82402B9; Thu, 1 Feb 2024 22:49:46 +0100 (CET) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id AEE814021D for ; Thu, 1 Feb 2024 22:49:44 +0100 (CET) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1d51ba18e1bso13487945ad.0 for ; Thu, 01 Feb 2024 13:49:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1706824183; x=1707428983; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=36HkAJgg8JdyAdxLr8cfSHd09yogMziW43W5dKdLU5A=; b=ClD87CNkTKeTmC30VTgXpXko1Gf5yOn6rJmTJJPP4jbmJG+G88h7tJlmE5QByZT+NN UxkErhoZBEsSN0JZiZvGhje21l/offWUpMIifl2Pa++/hHSQ1NQP7RHTEOctdoHS+Gde awz922Npk6BdQdsHDr4LW1Yo2jpcab8+FM1B8h8awEW2mPfSqRQ0nX47h4mPVj365GVx rYRj9oB2+FVuN3wyY0V9rlocFoLNSlDT9vNi2kkBB3iq8ejHZeF9VgZukVGy0gtjHAw1 sXqCoYzW/MrMXLWmiHivm0qIcySJkgcx2UAeb4cBC17bCe2Iu4Pvtpa4sVD0IBK4WTHq d5GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706824183; x=1707428983; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=36HkAJgg8JdyAdxLr8cfSHd09yogMziW43W5dKdLU5A=; b=M0lZn2i/dXr9dC1Hbd34NFNZD8dYGvDDlhHQmXNPSrpQ9DD4xnVG3Va0BRM6ZLUCol o8WlkILwYl0mEzFkBBOVG9+7Wjb7wDu3AuFwCxGxkhVtI/P4TsCP3SUq9znaYD/QP+R4 V+NUsycH7/eezanQoZQztMKQUwcCeOZm095SfB1bchpDQBxRbvvj+/FmP8qefE3+K+qy CkyGgtYk9WV/Aj9a043rU8efog2WcIR7UvlXOZn8DEkkb1AQCOXI92MZwOdRcHZo4t+a ucA3uLk/zodCWa7AUDaLVo632l703LY5onA6qMLN/uL5KG09dDJ2brqq9o0ClkwiXU2/ S9fQ== X-Gm-Message-State: AOJu0YyXu508OQW4JOvJpo36ON43F0VbDXRYeySZGini8fdw6kF1Rvw/ 4kZ1V5nCiSxOAlhuNtg6dvjNrb2RANNyxoEgA7wpYBGz3+faRsYwKHrDqxoyHXo= X-Google-Smtp-Source: AGHT+IGjBlnaCmevfLuB2qCx7rAeF2ZpWjzLjQsC0HZyK+IX5mY7T3lWLBKXoWA2uZSgdwJEyFgjPA== X-Received: by 2002:a17:902:d50d:b0:1d5:4b18:17c6 with SMTP id b13-20020a170902d50d00b001d54b1817c6mr467158plg.62.1706824183592; Thu, 01 Feb 2024 13:49:43 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXxHWSdMRLTdwVMEV8TVuK9tGTXZyJw93yGB/fiDWofGRaQnsmebqx/PL46YXgoSYnu5SOBXAWMdM9CUrdIF/DGjsLZnCHzIMYCnEVfPrXCJW4ZOhZ7Q9ULYYXB1mdxlUZ/dQC8yI7ktXxcbV1I4zNYcLOGLOtrj6vaQ7JDZ9HlzfGpp1P7tMEmslUJJp7ty2LLdcomzC1SAxc= Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id kt5-20020a170903088500b001d70af5be17sm274805plb.229.2024.02.01.13.49.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Feb 2024 13:49:43 -0800 (PST) Date: Thu, 1 Feb 2024 13:49:41 -0800 From: Stephen Hemminger To: Morten =?UTF-8?B?QnLDuHJ1cA==?= Cc: "Dengdui Huang" , , , , , Subject: Re: [PATCH 02/43] eal: use rte strerror Message-ID: <20240201134941.4d650639@hermes.local> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F025@smartserver.smartshare.dk> References: <20231114082539.1858594-1-huangdengdui@huawei.com> <20231114082539.1858594-3-huangdengdui@huawei.com> <20231114161813.29e9b73c@hermes.local> <98CBD80474FA8B44BF855DF32C47DC35E9F025@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 15 Nov 2023 12:16:18 +0100 Morten Br=C3=B8rup wrote: > > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > Sent: Wednesday, 15 November 2023 01.18 > >=20 > > On Tue, 14 Nov 2023 16:24:58 +0800 > > Dengdui Huang wrote: > > =20 > > > The function strerror() is insecure in a multi-thread environment. > > > This patch uses rte_strerror() to replace it. > > > > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Dengdui Huang > > > Acked-by: Chengwen Feng =20 > >=20 > > NAK. > > rte_strerror() is no more thrad safe than strerror() =20 >=20 > It is thread safe: > https://elixir.bootlin.com/dpdk/v23.11-rc3/source/lib/eal/common/eal_comm= on_errno.c#L31 Thread safe, but not signal safe. a per-core buffer is not safe against preemption in an interrupt.