From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Julien Aube <julien_dpdk@jaube.fr>
Subject: [PATCH v9 17/23] net/bnx2x: remove reference to sanity
Date: Mon, 5 Feb 2024 09:43:45 -0800 [thread overview]
Message-ID: <20240205180328.131019-18-stephen@networkplumber.org> (raw)
In-Reply-To: <20240205180328.131019-1-stephen@networkplumber.org>
Replace "sanity check"
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/bnx2x/bnx2x.c | 2 +-
drivers/net/bnx2x/bnx2x_stats.c | 8 ++++----
drivers/net/bnx2x/ecore_sp.c | 2 +-
drivers/net/bnx2x/elink.c | 4 ++--
4 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c
index c3283c94f38f..e345f293f25c 100644
--- a/drivers/net/bnx2x/bnx2x.c
+++ b/drivers/net/bnx2x/bnx2x.c
@@ -7820,7 +7820,7 @@ static int bnx2x_check_valid_mf_cfg(struct bnx2x_softc *sc)
uint32_t ovlan2;
uint8_t i, j;
- /* various MF mode sanity checks... */
+ /* various MF mode checks... */
if (mf_info->mf_config[SC_VN(sc)] & FUNC_MF_CFG_FUNC_HIDE) {
PMD_DRV_LOG(NOTICE, sc,
diff --git a/drivers/net/bnx2x/bnx2x_stats.c b/drivers/net/bnx2x/bnx2x_stats.c
index c07b01510a06..86d90679ac0a 100644
--- a/drivers/net/bnx2x/bnx2x_stats.c
+++ b/drivers/net/bnx2x/bnx2x_stats.c
@@ -187,7 +187,7 @@ bnx2x_stats_pmf_update(struct bnx2x_softc *sc)
*/
return;
}
- /* sanity */
+ /* input valid? */
if (!sc->port.pmf || !sc->port.port_stx) {
PMD_DRV_LOG(ERR, sc, "BUG!");
return;
@@ -237,7 +237,7 @@ bnx2x_port_stats_init(struct bnx2x_softc *sc)
uint32_t mac_addr;
uint32_t *stats_comp = BNX2X_SP(sc, stats_comp);
- /* sanity */
+ /* input valid? */
if (!sc->link_vars.link_up || !sc->port.pmf) {
PMD_DRV_LOG(ERR, sc, "BUG!");
return;
@@ -461,7 +461,7 @@ bnx2x_func_stats_init(struct bnx2x_softc *sc)
struct dmae_command *dmae = &sc->stats_dmae;
uint32_t *stats_comp = BNX2X_SP(sc, stats_comp);
- /* sanity */
+ /* input valid? */
if (!sc->func_stx) {
PMD_DRV_LOG(ERR, sc, "BUG!");
return;
@@ -1301,7 +1301,7 @@ bnx2x_port_stats_base_init(struct bnx2x_softc *sc)
struct dmae_command *dmae;
uint32_t *stats_comp = BNX2X_SP(sc, stats_comp);
- /* sanity */
+ /* input valid? */
if (!sc->port.pmf || !sc->port.port_stx) {
PMD_DRV_LOG(ERR, sc, "BUG!");
return;
diff --git a/drivers/net/bnx2x/ecore_sp.c b/drivers/net/bnx2x/ecore_sp.c
index c6c3857778f7..158205266f62 100644
--- a/drivers/net/bnx2x/ecore_sp.c
+++ b/drivers/net/bnx2x/ecore_sp.c
@@ -207,7 +207,7 @@ static int ecore_exe_queue_step(struct bnx2x_softc *sc,
break;
}
- /* Sanity check */
+ /* Argument check */
if (!cur_len)
return ECORE_SUCCESS;
diff --git a/drivers/net/bnx2x/elink.c b/drivers/net/bnx2x/elink.c
index 2c81f85b9605..6ebd47d927f8 100644
--- a/drivers/net/bnx2x/elink.c
+++ b/drivers/net/bnx2x/elink.c
@@ -1088,7 +1088,7 @@ static void elink_get_epio(struct bnx2x_softc *sc, uint32_t epio_pin,
{
uint32_t epio_mask, gp_oenable;
*en = 0;
- /* Sanity check */
+ /* Input check */
if (epio_pin > 31) {
ELINK_DEBUG_P1(sc, "Invalid EPIO pin %d to get", epio_pin);
return;
@@ -1105,7 +1105,7 @@ static void elink_set_epio(struct bnx2x_softc *sc, uint32_t epio_pin, uint32_t e
{
uint32_t epio_mask, gp_output, gp_oenable;
- /* Sanity check */
+ /* Input check */
if (epio_pin > 31) {
ELINK_DEBUG_P1(sc, "Invalid EPIO pin %d to set", epio_pin);
return;
--
2.43.0
next prev parent reply other threads:[~2024-02-05 18:05 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0230331200824.195294-1-stephen@networkplumber.org>
2023-04-05 23:29 ` [PATCH v3] devtools: add script to check for non inclusive naming Stephen Hemminger
2023-08-17 14:58 ` Stephen Hemminger
2023-04-19 15:00 ` [PATCH] " Stephen Hemminger
2023-10-30 21:33 ` [PATCH v4] " Stephen Hemminger
2023-10-30 22:17 ` [PATCH v5] " Stephen Hemminger
2023-10-30 22:22 ` [PATCH v6] " Stephen Hemminger
2023-10-30 22:32 ` [PATCH v7] " Stephen Hemminger
2023-11-02 20:57 ` [PATCH v8] " Stephen Hemminger
2024-02-05 17:43 ` [PATCH v9 00/23] Use inclusive naming in DPDK Stephen Hemminger
2024-02-05 17:43 ` [PATCH v9 01/23] devtools: add script to check for non inclusive naming Stephen Hemminger
2024-02-05 17:43 ` [PATCH v9 02/23] test: replace use of term segregate Stephen Hemminger
2024-02-05 17:43 ` [PATCH v9 03/23] examples/ptp: replace terms master and slave Stephen Hemminger
2024-02-05 17:43 ` [PATCH v9 04/23] test: remove use of word master in test_red Stephen Hemminger
2024-02-05 17:43 ` [PATCH v9 05/23] mbuf: replace term sanity check Stephen Hemminger
2024-02-05 17:43 ` [PATCH v9 06/23] eal: replace use of sanity check in comments and messages Stephen Hemminger
2024-02-05 17:43 ` [PATCH v9 07/23] test: replace use word sanity Stephen Hemminger
2024-02-05 17:43 ` [PATCH v9 08/23] examples: remove term sanity Stephen Hemminger
2024-02-06 10:05 ` [EXT] " Akhil Goyal
2024-02-05 17:43 ` [PATCH v9 09/23] lib: replace use of sanity check in comments and messages Stephen Hemminger
2024-02-05 17:43 ` [PATCH v9 10/23] doc/eventdev_pipeline: remove sanity Stephen Hemminger
2024-02-05 17:43 ` [PATCH v9 11/23] net/ring: replace use of sanity Stephen Hemminger
2024-02-05 17:43 ` [PATCH v9 12/23] net/fm10k, net/ixgbe: remove word sanity Stephen Hemminger
2024-02-05 17:43 ` [PATCH v9 13/23] net/mlx[45]: " Stephen Hemminger
2024-02-05 19:22 ` Dariusz Sosnowski
2024-02-05 17:43 ` [PATCH v9 14/23] net/sfc: remove term "sanity check" Stephen Hemminger
2024-02-05 17:43 ` [PATCH v9 15/23] net/ark: replace use of term sanity Stephen Hemminger
2024-02-05 21:12 ` Ed Czeck
2024-02-05 17:43 ` [PATCH v9 16/23] net/bnxt: " Stephen Hemminger
2024-02-05 17:43 ` Stephen Hemminger [this message]
2024-02-05 17:43 ` [PATCH v9 18/23] cnxk: replace " Stephen Hemminger
2024-02-05 17:43 ` [PATCH v9 19/23] event/opdl: remove " Stephen Hemminger
2024-02-05 17:43 ` [PATCH v9 20/23] net/txgbe: replace " Stephen Hemminger
2024-02-05 17:43 ` [PATCH v9 21/23] net/cxgbe: remove use of " Stephen Hemminger
2024-02-05 17:43 ` [PATCH v9 22/23] crypto/bcmfs: replace term sanity check Stephen Hemminger
2024-02-05 17:43 ` [PATCH v9 23/23] drivers: remove use of " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240205180328.131019-18-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=julien_dpdk@jaube.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).