From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D73F43AA3; Wed, 7 Feb 2024 19:55:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 51FE640DDD; Wed, 7 Feb 2024 19:55:12 +0100 (CET) Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by mails.dpdk.org (Postfix) with ESMTP id 1155E4027D for ; Wed, 7 Feb 2024 19:55:11 +0100 (CET) Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-6da4a923b1bso818203b3a.2 for ; Wed, 07 Feb 2024 10:55:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1707332110; x=1707936910; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=j9i7y+fCI5fI/MLHS18J0e0NnFzm90OZVh67z90Exds=; b=guG+skmeelosOxzS+CYtnCHkIaHSh9AtO6NoG4Uol2dPFQPeP7/nwdIADRg6mFUan/ BlCaDcNq7tnEKThwFo6rmIPuLSJkKhN3q/ZdbWet1+Aor+A30OKaQtnahFzLbRARoxuu oaD5BFvrXK4zclmpOxWnR1ldYzBN4UaQZFFAtGxMhUL0C911M9KXwqOtLOfDvbBRekK/ K540eFxnCfZFdac6f5afcARqw6Cl60UaramrcI6WZXh9Ok+l82IFuVgJJott49AfuHKB 2aftq5XW96EIzJ8z/dWadzLnrKujuZXVZ+NcehkshoXvihnS0I4P+oKi3/Vkcu/UcVHn 8qdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707332110; x=1707936910; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j9i7y+fCI5fI/MLHS18J0e0NnFzm90OZVh67z90Exds=; b=uzFAg9PEok3M7oQrvBGXVJUzVdlnhANGgW4r6IX40janfX7u/zuFuZP12zk3PKpY5c g7PhKB5cwddgh4OO5peo/AbLpqmy6ys5p4OCWrgcQF21ZS3WyLpFVACyfFAkrf0aOv1A I69JEaNQV8j/E7cCkab3mgjU9zntsFUKwPKRr7q9BJ7OPKWz0xgBxAFHB2XpDD5GPLal cB/WRK1cB1ope0xHhRypBRwkrjI2sTrYDPJk+HicS21y08g8VfMVvXXmIsIzjg+CHKA5 aVHltYS1XVcpUk9SpJ0j4IylfFFBvOMg1QnoHBiBqlLk59SEtPpnQGmtxC1gKAyL6SZK MrVA== X-Gm-Message-State: AOJu0Yyl2vHelXqb4+/NtaTKJJq0hyOBx9+rCS/DtNFsX5zl3Y3EC40O HTelDaFIdECCndgXrQCj6nLA09Y3Y2ImYR6JKCcQcx+y+qcolxMTdBOEowsN8e4= X-Google-Smtp-Source: AGHT+IHittRieJTXwPDDEFDnZMMuIxG9SVWxvNMjcY6RPF9cPTXEv/8bj+urmLVGnQKdCidYEHyiwQ== X-Received: by 2002:a05:6a00:2f1b:b0:6e0:3f2d:4c0f with SMTP id fe27-20020a056a002f1b00b006e03f2d4c0fmr3385827pfb.12.1707332109937; Wed, 07 Feb 2024 10:55:09 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUH1wgVYgLWeCkd9X28k6PyB3AJPqkYnJM6dGPDeWhulHgwYVMWEPxEdFf4KRJlNCV6aqgVhlKgdsoXp7ewqYIqqGWgxg== Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id n24-20020a637218000000b005dc36279d6dsm1722852pgc.73.2024.02.07.10.55.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 10:55:09 -0800 (PST) Date: Wed, 7 Feb 2024 10:55:08 -0800 From: Stephen Hemminger To: madhuker.mythri@oracle.com Cc: dev@dpdk.org, ferruh.yigit@amd.com Subject: Re: [PATCH] net/tap: Modified TAP BPF program as per the Kernel-version upgrade requirements. Message-ID: <20240207105508.30e9e8d3@hermes.local> In-Reply-To: <20240112134821.2067-1-madhuker.mythri@oracle.com> References: <20240112134821.2067-1-madhuker.mythri@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 12 Jan 2024 19:18:21 +0530 madhuker.mythri@oracle.com wrote: > +struct { > + __uint(type, BPF_MAP_TYPE_HASH); > + __type(key, __u32); > + __type(value, struct rss_key); > + __uint(max_entries, 256); > +} map_keys SEC(".maps"); > Overall this patch is a big step forward in getting TAP BPF going again. But using the new BTF maps won't work with how the tap device is loading the BPF program. Getting BTF to work requires more steps and is best done by using libbpf. With this part of your version current kernels will give type mismatch in verifier since the type information for map_keys is not loaded. See my followon RFC for what libbpf integration looks like. Ends up being a deeper rewrite.