From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0EA1843AB0; Thu, 8 Feb 2024 21:39:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D654042DFD; Thu, 8 Feb 2024 21:39:56 +0100 (CET) Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by mails.dpdk.org (Postfix) with ESMTP id 3E91B42DF9 for ; Thu, 8 Feb 2024 21:39:55 +0100 (CET) Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-2909a632e40so205024a91.0 for ; Thu, 08 Feb 2024 12:39:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1707424794; x=1708029594; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:to:from:date:from:to:cc:subject:date:message-id :reply-to; bh=3S2rYAcuGUQCgqSyzI8m1jR2rLM1vtuAqe0aDmK8MZI=; b=FvuGGy6pgm6ybh6rCpTJIH8AXEcG7nlupr/Va/JHpx9BabbYa/8UsiKxdMswA8ArrD VNOQR2pn6ygBD97Vnu6L86e2o7ZESI+yVCeQsM89I0oTP4WW2MPDMjtEFYKwRcE0W7cg tZ9rrjhX3yifHsN66TSiVp47VvqzyFmWu5ief6KoLvuguUB7xGI/oXg4zrDWnfP4Thry a0e91dV0YkG6bGylt2tLtPjsKTAU+ojQM8xBezc06uRaY6nl3ZiWmo0TIbzDvL1neneI WlOi33P0cqQJZ+K6pyVi0hejQV5kFbausokYF9TsLnkbMvzpMElfyZqsGzBrX2mL3397 +hXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707424794; x=1708029594; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3S2rYAcuGUQCgqSyzI8m1jR2rLM1vtuAqe0aDmK8MZI=; b=krSr9b5HqbdvHJHh+5Ltts7LLvECUgn2MvmNpoc15sWP9y/xDIac/ueJfHlXf1pgc7 AQYuujd9lSNYUL8bmhphINJ0gewIzuX0XEt0vI7d0JwaD/y2qwTZcL7kNrL8/oxBg42Y FBtQohsANSJNvoeaEa8IWtGOKxwM2Pauh0NgGWgB/4amc9H9BWmXoNhtPRDoFcH1If4l HE34LZJE3xFS2LSasLHmYpOmJOV/O1K+loWSuN1u5EVG7+lk3LcXayzYElr5JlNt3zY6 EvKmE06//iSIfs2Kf+efvobY9rvAcaLCWDYIqZw9DT20jg7lknHW7SvoVh8XYsMbtNbC E/Mg== X-Gm-Message-State: AOJu0Yw9MdUpGYQJzxabxez/VCRBgHieCuQ/tfuq72FBNmOYt8rGP1wU kaUHGhTebMSgzhYlmwkTNDuTxI7rs6vWUmVjouoJvXjCebi1uVouThj+cCBwLF8qmVe0x2kmb2m Gd4k= X-Google-Smtp-Source: AGHT+IG4DSxSiDLJrmmdtlvA+a/q4U5JFUcrO2Fbx2KtqD4vMKEvFS4Kt09IPsye40NW9gnIyBWIOA== X-Received: by 2002:a17:90a:d714:b0:295:ee75:6090 with SMTP id y20-20020a17090ad71400b00295ee756090mr478725pju.1.1707424794277; Thu, 08 Feb 2024 12:39:54 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id s65-20020a17090a69c700b00290f9e8b4f9sm231962pjj.46.2024.02.08.12.39.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 12:39:54 -0800 (PST) Date: Thu, 8 Feb 2024 12:39:52 -0800 From: Stephen Hemminger To: dev@dpdk.org Subject: Re: [PATCH v4 5/7] net/tap: use libbpf to load new BPF program Message-ID: <20240208123952.2f226ffa@hermes.local> In-Reply-To: <20240208190827.332368-6-stephen@networkplumber.org> References: <20240130034925.44869-1-stephen@networkplumber.org> <20240208190827.332368-1-stephen@networkplumber.org> <20240208190827.332368-6-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 8 Feb 2024 11:05:53 -0800 Stephen Hemminger wrote: > There were multiple issues in the RSS queue support in the TAP > driver. This required extensive rework of the BPF support. > > Change the BPF loading to use bpftool to > create a skeleton header file, and load with libbpf. > The BPF is always compiled from source so less chance that > source and instructions diverge. Also resolves issue where > libbpf and source get out of sync. The program > is only loaded once, so if multiple rules are created > only one BPF program is loaded in kernel. > > The new BPF program only needs a single action. > No need for action and re-classification step. > > It alsow fixes the missing bits from the original. > - supports setting RSS key per flow > - level of hash can be L3 or L3/L4. > > Signed-off-by: Stephen Hemminger Note: this patch introduces a optional dependency on bpftool to get the RSS to work. If bpftool is not present, then RSS is not built, and attempts to use rte_flow_action_queue will fail with not supported. It looks like the CI build environment is missing bpftool, so all the builds just skip that code. This works but CI build environments need to change to get bpftool. Not sure how to make that happen.