From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4316743B01; Mon, 12 Feb 2024 14:59:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2D0A440A89; Mon, 12 Feb 2024 14:59:56 +0100 (CET) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2056.outbound.protection.outlook.com [40.107.212.56]) by mails.dpdk.org (Postfix) with ESMTP id 28B2A4068A for ; Mon, 12 Feb 2024 14:59:55 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bK62nwyeBWG4NiRIpGCkiDjmiQRW24k0kMxOM4QIzx+f6vTuGyMlrniAEibcKhSBIqtndwCDOp21mwssZrVn9IOrzRWYSjjtQffz33ZN91QX4hMTliLmqm7I47121GIUf87fFdK9VBmcgLsYAXE0xFsx3M7IhKwOlyLtNgcUgPOr3H1NAmY7PL3jOwwbWJBp2zHT6dKWLuhkE28PUyvjsUHxBYp7Y4O22cxnZxr8l4HaTPYFGLB/EPB4VDZhkzuc/WauyGilwg+OYFo8Hqq9P/aAHaJxtZmeNdQJxhklVT3gWm5r3OFAIYoK7KEiseUEYlN1NAzYHpI1vVR/7Lr8yA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=45Y95lZnoAoc3X4haDH8u87T9bRtJr5zEw1iQXwji3w=; b=dgeJa7tWvpE8+zQztTCb/zPSh0SDHB/BGLWNe/dvn1LEIIBci29kO5j4tYsLIkF9uFUnVE65tCCEWgFxIU8UyvUWxP+vNUp70uWloyBR+oM9CEx8L6/ClkfEopYJXD7+xZu2Swud/Wx9q6+vay51LYrJGH+BJ8AHAsHvqf6twQDbN27zp0lhLWNSc9ZkbsGUkkbxhHPaoG/B/rOaLzlB60WnWgMSY2tbAEm0YUQRkjQ/iPjJOjWQ0FtloPZXgh9psRKT8TcQCa2j3OFEAPAbt9MraUJIy27Izui7R7XVJB2ave7BkhzSPahA/HZ5qdTXeOsMXeUz2h4n6GwxwiAzZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=45Y95lZnoAoc3X4haDH8u87T9bRtJr5zEw1iQXwji3w=; b=nrjE0A1QoWxft/Bs3I31/C2JsnxDpBTix/QxwJes14dS6pGww0Lg5laziiQa8eaBBbaK4uIxOSISfTJNQcpKjAnDqJ+B1PCECUPuaNpeDgUkBPwtTVWGGXIVXwJ1OIU0/IDkOYpo1RGYKEiwcJm6EG2Lu7wuj0aIDHrrrrfSy1546P0hwAj9PRLfSx0AhFcNj7kyEq2QwNrq+yvDKWwzhebitUJ/5oTnvz0rgizmv+nWEkY8NYtrLqcs/88nvuHbP8OD72OCn8e+hRUhki31uOzjbt0wdRMeHnQnagaZMbtDT4k44RNyJBvLJzzpwp9cHGeAST3a5JQ5ikFrv4zbZg== Received: from BN1PR10CA0019.namprd10.prod.outlook.com (2603:10b6:408:e0::24) by BL0PR12MB4932.namprd12.prod.outlook.com (2603:10b6:208:1c2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.25; Mon, 12 Feb 2024 13:59:53 +0000 Received: from BN3PEPF0000B077.namprd04.prod.outlook.com (2603:10b6:408:e0:cafe::dd) by BN1PR10CA0019.outlook.office365.com (2603:10b6:408:e0::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.39 via Frontend Transport; Mon, 12 Feb 2024 13:59:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BN3PEPF0000B077.mail.protection.outlook.com (10.167.243.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.19 via Frontend Transport; Mon, 12 Feb 2024 13:59:52 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 12 Feb 2024 05:59:41 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Mon, 12 Feb 2024 05:59:38 -0800 From: Gregory Etelson To: CC: , , Dariusz Sosnowski , Viacheslav Ovsiienko , "Ori Kam" , Suanming Mou , Matan Azrad Subject: [PATCH v3 2/2] net/mlx5: improve pattern template validation Date: Mon, 12 Feb 2024 15:59:11 +0200 Message-ID: <20240212135911.529237-3-getelson@nvidia.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240212135911.529237-1-getelson@nvidia.com> References: <20240202150617.328603-1-getelson@nvidia.com> <20240212135911.529237-1-getelson@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B077:EE_|BL0PR12MB4932:EE_ X-MS-Office365-Filtering-Correlation-Id: 6220483b-e955-4c1a-f0d1-08dc2bd2e2d5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XTN1a9x9XO6roVW1/t4XzaHHqF9GvItnGSxOBI9L3pmSKRx57meecl4hUDr7Ld1cTG9p+8O37di9BG4ybkfT8b7Y6K+WJWR9Z+gCWMO2s5VhWwoeHQ1hOZD1u63fWeh8bUHmUtuFaakrtcwC9xoyffbA6M6+dWNtvE4DIzsmGwCW2VruM0J9n3/Xfc+DjJgqPj93+iavCS7wPa3YzXN8BZpfOf/FVkiFo3Y6P/rFhPhfGyIFcYCyWfIcp7cejQO/fLAxNjUbUgglAHvjyAd9gUZdFMOj5KFOrbR8BYUNrB2GyOsEGKw6Mp7xNjyjd3IcOw1mG3+Sn9XMZCG0k9dqEltQFcBDm4yboDpq/6Ldh0/245mxx97/7ZN/cSn2O2AdlPClcddnolakzDb1/W4zgKNqtp+SrN77pmJxjqTWZNtQG7om/IfuUFIupkJ8kqDGcI83JvMmaW1DnkjigIrTZK6Z0yW/8X+B1nCIqwMYV0nRR4o1U63VBLFQWHntf9HnriqQvkBhwoHpCPUgu3AXbN/2vAfvsI0YyaSkhQFKiaVlU1ZByt9gUaHUYG0O0qTIELnTjjana/Y6Axlu8hxhBziX41IsE5jVN4dQyGkJ3as= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(376002)(396003)(136003)(39850400004)(346002)(230273577357003)(230922051799003)(82310400011)(186009)(64100799003)(1800799012)(451199024)(46966006)(36840700001)(55016003)(41300700001)(2616005)(107886003)(426003)(6666004)(7636003)(356005)(70206006)(70586007)(4326008)(8676002)(8936002)(5660300002)(2906002)(82740400003)(316002)(6916009)(54906003)(36756003)(86362001)(26005)(1076003)(6286002)(336012)(16526019)(83380400001)(7696005)(478600001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2024 13:59:52.6378 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6220483b-e955-4c1a-f0d1-08dc2bd2e2d5 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B077.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4932 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Current PMD implementation validates pattern templates that will always be rejected during table template creation. The patch adds basic HWS verifications to pattern validation to ensure that the pattern can be used in table template. PMD updates `rte_errno` if pattern template validation failed: E2BIG - pattern too big for PMD ENOTSUP - pattern not supported by PMD ENOMEM - PMD allocation failure Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5.h | 1 + drivers/net/mlx5/mlx5_flow_hw.c | 121 ++++++++++++++++++++++++++++++++ 2 files changed, 122 insertions(+) diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index f2e2e04429..e98db91888 100644 --- a/drivers/net/mlx5/mlx5.h +++ b/drivers/net/mlx5/mlx5.h @@ -1965,6 +1965,7 @@ struct mlx5_priv { struct mlx5_aso_mtr_pool *hws_mpool; /* HW steering's Meter pool. */ struct mlx5_flow_hw_ctrl_rx *hw_ctrl_rx; /**< HW steering templates used to create control flow rules. */ + struct rte_flow_actions_template *action_template_drop[MLX5DR_TABLE_TYPE_MAX]; #endif struct rte_eth_dev *shared_host; /* Host device for HW steering. */ uint16_t shared_refcnt; /* HW steering host reference counter. */ diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index da873ae2e2..4e405bcb07 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -6840,6 +6840,50 @@ flow_hw_pattern_has_sq_match(const struct rte_flow_item *items) return false; } +static int +pattern_template_validate(struct rte_eth_dev *dev, + struct rte_flow_pattern_template *pt[], uint32_t pt_num) +{ + uint32_t group = 0; + struct mlx5_flow_template_table_cfg tbl_cfg = { + .attr = (struct rte_flow_template_table_attr) { + .nb_flows = 64, + .insertion_type = RTE_FLOW_TABLE_INSERTION_TYPE_PATTERN, + .hash_func = RTE_FLOW_TABLE_HASH_FUNC_DEFAULT, + .flow_attr = { + .ingress = pt[0]->attr.ingress, + .egress = pt[0]->attr.egress, + .transfer = pt[0]->attr.transfer + } + }, + .external = true + }; + struct mlx5_priv *priv = dev->data->dev_private; + struct rte_flow_actions_template *action_template; + + if (pt[0]->attr.ingress) + action_template = priv->action_template_drop[MLX5DR_TABLE_TYPE_NIC_RX]; + else if (pt[0]->attr.egress) + action_template = priv->action_template_drop[MLX5DR_TABLE_TYPE_NIC_TX]; + else if (pt[0]->attr.transfer) + action_template = priv->action_template_drop[MLX5DR_TABLE_TYPE_FDB]; + else { + rte_errno = EINVAL; + return rte_errno; + } + do { + struct rte_flow_template_table *tmpl_tbl; + + tbl_cfg.attr.flow_attr.group = group; + tmpl_tbl = flow_hw_table_create(dev, &tbl_cfg, pt, pt_num, + &action_template, 1, NULL); + if (!tmpl_tbl) + return rte_errno; + flow_hw_table_destroy(dev, tmpl_tbl, NULL); + } while (++group <= 1); + return 0; +} + /** * Create flow item template. * @@ -6975,8 +7019,19 @@ flow_hw_pattern_template_create(struct rte_eth_dev *dev, } } __atomic_fetch_add(&it->refcnt, 1, __ATOMIC_RELAXED); + rte_errno = pattern_template_validate(dev, &it, 1); + if (rte_errno) + goto error; LIST_INSERT_HEAD(&priv->flow_hw_itt, it, next); return it; +error: + flow_hw_flex_item_release(dev, &it->flex_item); + claim_zero(mlx5dr_match_template_destroy(it->mt)); + mlx5_free(it); + rte_flow_error_set(error, rte_errno, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, + "Failed to create pattern template"); + return NULL; + } /** @@ -9184,6 +9239,67 @@ flow_hw_compare_config(const struct mlx5_flow_hw_attr *hw_attr, return true; } +/* + * No need to explicitly release drop action templates on port stop. + * Drop action templates release with other action templates during + * mlx5_dev_close -> flow_hw_resource_release -> flow_hw_actions_template_destroy + */ +static void +action_template_drop_release(struct rte_eth_dev *dev) +{ + int i; + struct mlx5_priv *priv = dev->data->dev_private; + + for (i = 0; i < MLX5DR_TABLE_TYPE_MAX; i++) { + if (!priv->action_template_drop[i]) + continue; + flow_hw_actions_template_destroy(dev, + priv->action_template_drop[i], + NULL); + priv->action_template_drop[i] = NULL; + } +} + +static int +action_template_drop_init(struct rte_eth_dev *dev, + struct rte_flow_error *error) +{ + const struct rte_flow_action drop[2] = { + [0] = { .type = RTE_FLOW_ACTION_TYPE_DROP }, + [1] = { .type = RTE_FLOW_ACTION_TYPE_END }, + }; + const struct rte_flow_action *actions = drop; + const struct rte_flow_action *masks = drop; + const struct rte_flow_actions_template_attr attr[MLX5DR_TABLE_TYPE_MAX] = { + [MLX5DR_TABLE_TYPE_NIC_RX] = { .ingress = 1 }, + [MLX5DR_TABLE_TYPE_NIC_TX] = { .egress = 1 }, + [MLX5DR_TABLE_TYPE_FDB] = { .transfer = 1 } + }; + struct mlx5_priv *priv = dev->data->dev_private; + + priv->action_template_drop[MLX5DR_TABLE_TYPE_NIC_RX] = + flow_hw_actions_template_create(dev, + &attr[MLX5DR_TABLE_TYPE_NIC_RX], + actions, masks, error); + if (!priv->action_template_drop[MLX5DR_TABLE_TYPE_NIC_RX]) + return -1; + priv->action_template_drop[MLX5DR_TABLE_TYPE_NIC_TX] = + flow_hw_actions_template_create(dev, + &attr[MLX5DR_TABLE_TYPE_NIC_TX], + actions, masks, error); + if (!priv->action_template_drop[MLX5DR_TABLE_TYPE_NIC_TX]) + return -1; + if (priv->sh->config.dv_esw_en && priv->master) { + priv->action_template_drop[MLX5DR_TABLE_TYPE_FDB] = + flow_hw_actions_template_create(dev, + &attr[MLX5DR_TABLE_TYPE_FDB], + actions, masks, error); + if (!priv->action_template_drop[MLX5DR_TABLE_TYPE_FDB]) + return -1; + } + return 0; +} + /** * Configure port HWS resources. * @@ -9426,6 +9542,9 @@ flow_hw_configure(struct rte_eth_dev *dev, rte_spinlock_init(&priv->hw_ctrl_lock); LIST_INIT(&priv->hw_ctrl_flows); LIST_INIT(&priv->hw_ext_ctrl_flows); + ret = action_template_drop_init(dev, error); + if (ret) + goto err; ret = flow_hw_create_ctrl_rx_tables(dev); if (ret) { rte_flow_error_set(error, -ret, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, @@ -9559,6 +9678,7 @@ flow_hw_configure(struct rte_eth_dev *dev, mlx5_hws_cnt_pool_destroy(priv->sh, priv->hws_cpool); priv->hws_cpool = NULL; } + action_template_drop_release(dev); mlx5_flow_quota_destroy(dev); flow_hw_destroy_send_to_kernel_action(priv); flow_hw_free_vport_actions(priv); @@ -9621,6 +9741,7 @@ flow_hw_resource_release(struct rte_eth_dev *dev) flow_hw_flush_all_ctrl_flows(dev); flow_hw_cleanup_tx_repr_tagging(dev); flow_hw_cleanup_ctrl_rx_tables(dev); + action_template_drop_release(dev); while (!LIST_EMPTY(&priv->flow_hw_grp)) { grp = LIST_FIRST(&priv->flow_hw_grp); flow_hw_group_unset_miss_group(dev, grp, NULL); -- 2.39.2