From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2CD743B24; Fri, 16 Feb 2024 05:13:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BE7A04027C; Fri, 16 Feb 2024 05:13:58 +0100 (CET) Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) by mails.dpdk.org (Postfix) with ESMTP id 232FB40156 for ; Fri, 16 Feb 2024 05:13:58 +0100 (CET) Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-5d4d15ec7c5so1358189a12.1 for ; Thu, 15 Feb 2024 20:13:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1708056837; x=1708661637; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=OgDrscKZs5M4WMxz+zKECsZn4N2vlOMH6rgjDUMH6rI=; b=cWh/k5WnF2yTfw1SE9zQJJXtCHEco/FvtmsuGfwsSH2AygWlgJjirmb6Nly5fmHbZF Xku7yDqI8HluUsUq2Ql4ZmNri6A83XTgaJ41vkUMAX8jKv1yN5OhRNM8jj8kbFm7mp8n 4damVjVapTU8hBqX5KrPvU6sI7q4VLFjSaExKhsKMjdsCUsBXMwH/nUHxcwW6etrs5nw ipU2GoLRhQCx4qTrGhUbX7kt7BCM0qm5Ai7qg12xoD+XYqGRMT5xXCLW12zYmOKtLqCg WWTnNU+bFRFpAS3zUnH151Xzy2njeQ0UtV6YdQGYYpVr6EkasgJnFu5WVeFPKAFbwh0H sPGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708056837; x=1708661637; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OgDrscKZs5M4WMxz+zKECsZn4N2vlOMH6rgjDUMH6rI=; b=DIK0sOyiap/231e9Lhn7nhb6AUR9fgDCoALMKkoCOhZ5Iyg9GW15qkSKa5+p62lAV9 SIkO5giA/vBYzT7zYjTfXxS7pKHcgqV3krnTu11QkPGM+O4MUXf0FD1YSxuuN+VCcCwc 0OF4ElXy6GdcPNfhGB06hjuBqb1tpJ9a0j5hLKv7y8SDRQ2iMVio/UNIWik/e7wCR/V8 sfAb9Wkwch44IsvNzBJb1OaGr7uH4sLcBqAnEGaTDBlRX4pPkphS0UVZK+OZ1ObLaFSi woO8ICuZPvAP38DdcdlyIWDLsMYegMqsbUoem+IL0UoykU3uva4Zb4/zi/3uXLcmON2C XuBg== X-Forwarded-Encrypted: i=1; AJvYcCW2Z++4LHob1zdbcuu+cLtod2dTUMc6VHRiCnqVJuwe3QHG2kPrv3oHxGY4bQSN2jPyW+/yfMjEc38wUeM= X-Gm-Message-State: AOJu0YxFN3QdRCBFPPHF37QrJiNGru+2etupw0YbjDNJicbhImrK458s 2NK8WBMNmmiP4zjcBT8UqbMECNJGwrYyInAXRdSM0TRrIHbm/9rb9PoZ827J1jCk6C4Fu/3oVGO E X-Google-Smtp-Source: AGHT+IEylSF/nIWt76EnKYzgq3jwVO8/PFC9erQzmzgLaWJlaQbkavhBpIYipJ+MxZ9b2y1Y67qMAA== X-Received: by 2002:a05:6a21:918b:b0:1a0:60b2:451 with SMTP id tp11-20020a056a21918b00b001a060b20451mr4590991pzb.7.1708056837201; Thu, 15 Feb 2024 20:13:57 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id m6-20020a17090a34c600b00298b9f662ccsm4713932pjf.1.2024.02.15.20.13.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 20:13:56 -0800 (PST) Date: Thu, 15 Feb 2024 20:13:54 -0800 From: Stephen Hemminger To: Kumara Parameshwaran Cc: hujiayu.hu@foxmail.com, dev@dpdk.org, jiayu.hu@intel.com Subject: Re: [PATCH v7] app/testpmd : fix packets not getting flushed in heavy-weight mode API Message-ID: <20240215201354.59ffa287@hermes.local> In-Reply-To: <20240216034025.47371-1-kumaraparamesh92@gmail.com> References: <20240117195228.423261-1-kumaraparamesh92@gmail.com> <20240216034025.47371-1-kumaraparamesh92@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 16 Feb 2024 09:10:25 +0530 Kumara Parameshwaran wrote: > +#ifndef RTE_LIB_GRO > return false; > +#else > + gro_enable = gro_ports[fs->rx_port].enable; > + /* > + * Make sure that in case of Heavyweight mode GRO the packets in > + * GRO cache should be flushed as the timer could have expired. > + * > + * The order of condidtions should be the same as gro_ctx is valid Run spell check on the comments please > + * only when gro_flush_cycles is not the GRO_DEFAULT_FLUSH_CYCLES which > + * indicates ligth weight mode GRO > + */ > + if (!gro_enable || (gro_flush_cycles == GRO_DEFAULT_FLUSH_CYCLES) || > + (rte_gro_get_pkt_count(current_fwd_lcore()->gro_ctx) == 0)) > + return false; > +#endif FYI - Linux kernel GRO does a flush when ever NAPI finishes. Pretty much equivalent to this but flushes more frequently.