From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 377B043B40; Fri, 16 Feb 2024 21:46:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D918E4026A; Fri, 16 Feb 2024 21:46:33 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 2BF4540261 for ; Fri, 16 Feb 2024 21:46:32 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 4E62120B2000; Fri, 16 Feb 2024 12:46:31 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 4E62120B2000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1708116391; bh=GoavAFT/l0Ge4gFtTqdOadB/cd32v46xAzyjLOTTaXA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LP2xDTTFNW7dgeuuFqQvVIqZLF9JLaclW1CHfsIVgynTyKNQrpXvMLwBIcljI4Rfy Qi9oBCnJH6QJaR7ZDAR7z4S8KA654kyv6P5xmxPbOIP7cv1qKCNZ3cVZSG0fCFiuDD jaUpWITWHpQ1aMBhgwUFv3eY3HcM27WaLBQ4r2nA= Date: Fri, 16 Feb 2024 12:46:31 -0800 From: Tyler Retzlaff To: David Marchand Cc: dev@dpdk.org, Bruce Richardson , Cristian Dumitrescu , Honnappa Nagarahalli , Sameh Gobriel , Vladimir Medvedkin , Yipeng Wang , mb@smartsharesystems.com, fengchengwen@huawei.com, Dodji Seketeli Subject: Re: [PATCH v2 0/4] more replacement of zero length array Message-ID: <20240216204631.GA6503@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1706134657-17446-1-git-send-email-roretzla@linux.microsoft.com> <1707777366-26000-1-git-send-email-roretzla@linux.microsoft.com> <20240213192042.GA24086@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Feb 16, 2024 at 11:14:27AM +0100, David Marchand wrote: > On Wed, Feb 14, 2024 at 8:36 AM David Marchand > wrote: > > > I'm okay with the change being merged but if there is concern I can drop > > > this patch from the series. > > > > At least, we can't merge it in the current form. > > > > If libabigail gets a fix quickly, DPDK CI will still need a released version. > > So for this patch to be merged now, we need a libabigail suppression rule. > > I don't see a way to precisely waive this issue, so my suggestion is > > to silence any change on the concerned structure here (which should be > > ok, as the pipeline library data struct have been super stable for a > > couple of years). > > Something like: > > > > $ git diff > > diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore > > index 21b8cd6113..d667157909 100644 > > --- a/devtools/libabigail.abignore > > +++ b/devtools/libabigail.abignore > > @@ -33,3 +33,5 @@ > > ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; > > ; Temporary exceptions till next major ABI version ; > > ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; > > +[suppress_type] > > + name = rte_pipeline_table_entry > > Dodji confirmed the issue in libabigail and prepared a fix. > > DPDK still needs a suppression rule (like the one proposed above) if > we want to merge this change before the libabigail fix makes it to all > distribs. > Please resubmit this series with my proposal and a comment pointing at > libabigail bz squashed in patch 4. this works out conveniently, i noticed there are a few more instances that i'll try to add to this series so i'll come back with a new rev. i've marked the series changes requested in patchwork for now. > > > -- > David Marchand