From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 68C6F43AFB; Sat, 17 Feb 2024 17:47:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1F3E9400D7; Sat, 17 Feb 2024 17:47:29 +0100 (CET) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by mails.dpdk.org (Postfix) with ESMTP id DEF0340042 for ; Sat, 17 Feb 2024 17:47:27 +0100 (CET) Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-6e11a779334so1884215b3a.0 for ; Sat, 17 Feb 2024 08:47:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1708188447; x=1708793247; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=L8j4AYrPGfQplVihw6QuEj8g5JEKchwJtThEdwA3o+I=; b=JnGwbFVk3Qmw+ujkhEJa1kl5oxmr3/4rwHGPLdlEE/7938t9AedEq6ZPxHlMxyrmtL QDTULsHEoiA5k6K/+BNFKc4jtE2ss6k9ks65mvHRzr8K8r5kQHJmgKTU7fKbnUalOIHp KoZM6O0in2l/f53KhYNGFqfbQPy9MMaXukCb0H4uthvE8/f/lY672nJ+ymboIl3p682Y xu/s1R0jC5OHkEOtG5iWI4SnEBLuK8eWyEfSi97NA/54pz0+dpX6R5hW5dQ6rhssUJkY 5d0XIqF3vR4xuwFnJutg8/teRw0U42O/Xwk9bTJMKaaj0dpzUzU+lkTtl7HiblOvJO70 39KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708188447; x=1708793247; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=L8j4AYrPGfQplVihw6QuEj8g5JEKchwJtThEdwA3o+I=; b=ibSK8NmsGNopwYjU7zz7gR1G+h3vuKI8YKhdp0niHJfQPFmLXjlVGLLMdyg964+wRF IZrHGbuJKO9AltlALQXURKMHjoubpV49s/inQM5igPfxLWJR69KF/m9PNXcTDQ3LTIjy 7Rv8j0ggNQfvf1aLMdOzkq3JZSj7CiAyxBBoUAhqah1W1gKLAZ/y63kzyev2LoexPKhs Bp5PHRDJNhEmuKURhKSlNcgnmyMp1uCV9xY4rhtN1+IX2XEM15Gl91ZH1BPLiJ81tg0H /Bsx0zEljjkVX1CAmqYE5XrcXvjIWAdheL4vqAXB+9WJbKS3PKnc9QHI1PckZDs0KVJA cR+A== X-Gm-Message-State: AOJu0YweYWoWJWLC8HhUbFkgazGdFRBD4UsPvFutFsQQttshzEHrrfYO ZTMAttAQGmkMUx+t6LD3bER6GIHqxgFhQYyw5O1REZaXv1p0PLpevcciLHHAJmI= X-Google-Smtp-Source: AGHT+IFYr9HYAGEgVmjG66iIsB72wGXeSiMJkjbOAWyjnhUnMw/MorZPXogW7Z6U9FsD7DdAtG5ZRA== X-Received: by 2002:a05:6a00:80f:b0:6e2:f3d4:b5a2 with SMTP id m15-20020a056a00080f00b006e2f3d4b5a2mr2201642pfk.3.1708188446897; Sat, 17 Feb 2024 08:47:26 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id f6-20020a056a0022c600b006e06af90ff4sm1840016pfj.204.2024.02.17.08.47.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Feb 2024 08:47:26 -0800 (PST) Date: Sat, 17 Feb 2024 08:47:25 -0800 From: Stephen Hemminger To: Chaoyong He Cc: dev@dpdk.org, oss-drivers@corigine.com, Long Wu , Peng Zhang Subject: Re: [PATCH] net/nfp: add support of UDP fragmentation offload Message-ID: <20240217084725.5a1c6f34@hermes.local> In-Reply-To: <20240217015410.2163102-1-chaoyong.he@corigine.com> References: <20240217015410.2163102-1-chaoyong.he@corigine.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, 17 Feb 2024 09:54:10 +0800 Chaoyong He wrote: > Add the support of UDP fragmentation offload feature. > > Signed-off-by: Chaoyong He > Reviewed-by: Long Wu > Reviewed-by: Peng Zhang > --- > drivers/common/nfp/nfp_common_ctrl.h | 1 + > drivers/net/nfp/nfd3/nfp_nfd3_dp.c | 7 ++++++- > drivers/net/nfp/nfdk/nfp_nfdk_dp.c | 8 +++++--- > drivers/net/nfp/nfp_net_common.c | 8 ++++++-- > 4 files changed, 18 insertions(+), 6 deletions(-) Looks like this depends on earlier patch, it does not apply directly to main branch. > - if ((ol_flags & RTE_MBUF_F_TX_TCP_SEG) == 0) > + if ((ol_flags & RTE_MBUF_F_TX_TCP_SEG) == 0 && > + (ol_flags & RTE_MBUF_F_TX_UDP_SEG) == 0) > goto clean_txd; That is odd indentation style. Should be: if ((ol_flags & RTE_MBUF_F_TX_TCP_SEG) == 0 && (ol_flags & RTE_MBUF_F_TX_UDP_SEG) == 0) goto clean_txd;