From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B55D43B7B; Tue, 27 Feb 2024 19:07:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 016D740A6B; Tue, 27 Feb 2024 19:07:53 +0100 (CET) Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by mails.dpdk.org (Postfix) with ESMTP id E096040150 for ; Tue, 27 Feb 2024 19:07:51 +0100 (CET) Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-6e55afcf513so27724b3a.1 for ; Tue, 27 Feb 2024 10:07:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709057271; x=1709662071; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=a8upJLds661FLOhq3s0zRy/ipy5CTf3RztYUjgYbnaE=; b=O6blcTPZH7UBH/nQgEWNbj1EPelKuYuJQtAwx4Mxg4+EzYvuACzsxtRW7rTPaUAbuW hc38Dw6TqRhm1UTDGXO2JcDhOZPHbo7jGv1gkCmXSC9V294AJ+gUHO9NN6BcaudCngDA lm501gJPhlb+s9fnoIspnz6AJhhRh0ndl1K6Ufeb6vo9UtVOP6TrpftoYJj8zkCdWTVG yDZ+UPz4nS1QBbHkLhZQA99n/675nn8Hr6FNF1NDk3v92ncOOdPKPdj3vI7U0Xd1HxZk bYi9ldAU5Lnc7s0vbmRNZCWCZhOpgigAfiPUP7/Z4p+zih9XFs7VJkxzZ76vWD3g68yd Xyzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709057271; x=1709662071; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a8upJLds661FLOhq3s0zRy/ipy5CTf3RztYUjgYbnaE=; b=Sn6QQ1VvSz+itJsMcBDiSG8vgruimufSMF/VG2yNfJLZd9f3JagpZ9aXQYM5kd+pgx 8tUIEuP2kdz9TvNV5lPobgjtKaDC0UBmYgr+GyedZzwbpHocp1DkL0RaqAGNpPj2DcM7 xvPjXrFNiXDBzLRd0TDgwelg2eReoP7bYm1jDznsc6I2K6ZkpByeJXksLJNhvGEAKz29 RMlWvkdKqK/INPerG4hd6u88l8jsMGld+v68Ch+leAFxIK6z02TTwwEsHmSFNPJZ17Yo UcJ+DObyKip88FyFFFi7A4rOPdWt+0kKXeLaNQ2QY7+flYj+wjaUQpQQbxDU6jAGd+DQ pzzg== X-Gm-Message-State: AOJu0YxtdbwW0Cv/EsloStDlY3k37J5UOln8I81c3b/Xcivn03VM9Etx I7sNUi9jWp+42mtuENLwnPS1BBl/7AIVuEMsmcB2R4KM0VRw1VxnC28oSj1NyWo= X-Google-Smtp-Source: AGHT+IFYCnONG0lxtkfuzRTJ+re7DcqqFqAM5wVAgGWhwc4eLStuO0KS8i0/LkN79XtCxnC9d/wO1w== X-Received: by 2002:a05:6a00:1388:b0:6e5:46dd:a7c7 with SMTP id t8-20020a056a00138800b006e546dda7c7mr3235975pfg.30.1709057271023; Tue, 27 Feb 2024 10:07:51 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id d13-20020aa7868d000000b006e469e8b634sm6203299pfo.3.2024.02.27.10.07.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 10:07:50 -0800 (PST) Date: Tue, 27 Feb 2024 10:07:48 -0800 From: Stephen Hemminger To: Isaac Boukris Cc: dev@dpdk.org Subject: Re: [PATCH] dumpcap: correctly disable promiscuous mode at exit Message-ID: <20240227100748.086d5bfd@hermes.local> In-Reply-To: <20240227092326.340229-1-iboukris@gmail.com> References: <20240227092326.340229-1-iboukris@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 27 Feb 2024 11:23:26 +0200 Isaac Boukris wrote: > Signed-off-by: Isaac Boukris > --- > app/dumpcap/main.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c > index d57db0589a..88cec43086 100644 > --- a/app/dumpcap/main.c > +++ b/app/dumpcap/main.c > @@ -830,11 +830,12 @@ static void enable_pdump(struct rte_ring *r, struct rte_mempool *mp) > intf->opts.promisc_mode = false; > } else { > ret = rte_eth_promiscuous_enable(intf->port); > - if (ret != 0) > + if (ret != 0) { > fprintf(stderr, > "port %u set promiscuous enable failed: %d\n", > intf->port, ret); > - intf->opts.promisc_mode = false; > + intf->opts.promisc_mode = false; > + } > } > } > ++count; Reviewed-by: Stephen Hemminger