From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id A58C743BF7;
Tue, 27 Feb 2024 17:22:38 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 85720406A2;
Tue, 27 Feb 2024 17:22:38 +0100 (CET)
Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com
[67.231.156.173])
by mails.dpdk.org (Postfix) with ESMTP id CB665402A7
for <dev@dpdk.org>; Tue, 27 Feb 2024 17:22:37 +0100 (CET)
Received: from pps.filterd (m0045851.ppops.net [127.0.0.1])
by mx0b-0016f401.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id
41RFgUwF004861; Tue, 27 Feb 2024 08:22:36 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=
pfpt0220; bh=DW8i0HNylQGRUxBsENpbJ1fd56rGLl0fvJiybIU7a/s=; b=SPA
RZe5WfXzFeeq42wZ+BaQylZb+QYyp0MayOknZnlRL6676e2XJC7m2tvwpY0eHPYG
+6UpX1gCKDYf75tyx910Veq8sVzhz4gbgYJgo3sSXzi0wPW9ZFMZCBUz2SQWlNfw
+6mSLTt6OqN7pB8B2R/4dLzp2MNoT86tVyOuv7z/r4P0t92/iIf6xxxfWH9Gi+Ce
Btq30VVodI1aAv4VXjorcdI3AwmzbrArJE2/tNrvMoAygVZsSSGbipyUnjhmLOgD
+nkM5xxskhzagroIS+Hb6oLvp8DTBdkp6z6/52IlAHhOIpm6W9pAyDU60TUOgpuM
uzTjjoHNFd+rgVqYLNw==
Received: from dc6wp-exch02.marvell.com ([4.21.29.225])
by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3whjm6879a-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
Tue, 27 Feb 2024 08:22:36 -0800 (PST)
Received: from DC6WP-EXCH01.marvell.com (10.76.176.21) by
DC6WP-EXCH02.marvell.com (10.76.176.209) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id
15.2.1258.12; Tue, 27 Feb 2024 08:22:35 -0800
Received: from DC6WP-EXCH02.marvell.com (10.76.176.209) by
DC6WP-EXCH01.marvell.com (10.76.176.21) with Microsoft SMTP Server (TLS) id
15.0.1497.48; Tue, 27 Feb 2024 11:00:44 -0500
Received: from maili.marvell.com (10.69.176.80) by DC6WP-EXCH02.marvell.com
(10.76.176.209) with Microsoft SMTP Server id 15.2.1258.12 via Frontend
Transport; Tue, 27 Feb 2024 08:00:44 -0800
Received: from cavium-OptiPlex-5090-BM14.. (unknown [10.28.36.157])
by maili.marvell.com (Postfix) with ESMTP id 3E9693F717A;
Tue, 27 Feb 2024 08:00:40 -0800 (PST)
From: Amit Prakash Shukla <amitprakashs@marvell.com>
To: Cheng Jiang <honest.jiang@foxmail.com>, Chengwen Feng
<fengchengwen@huawei.com>
CC: <dev@dpdk.org>, <jerinj@marvell.com>, <anoobj@marvell.com>, Kevin Laatz
<kevin.laatz@intel.com>, Bruce Richardson <bruce.richardson@intel.com>,
Pavan Nikhilesh <pbhagavatula@marvell.com>, Gowrishankar Muthukrishnan
<gmuthukrishn@marvell.com>, Amit Prakash Shukla <amitprakashs@marvell.com>
Subject: [PATCH v9 1/4] app/dma-perf: add skip support
Date: Tue, 27 Feb 2024 21:30:28 +0530
Message-ID: <20240227160031.3931694-2-amitprakashs@marvell.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20240227160031.3931694-1-amitprakashs@marvell.com>
References: <cover.1700650397.git.gmuthukrishn@marvell.com>
<20240227160031.3931694-1-amitprakashs@marvell.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-Proofpoint-ORIG-GUID: ZxNYrDq6pMeFlgIad_efQaz7wW-NXOGv
X-Proofpoint-GUID: ZxNYrDq6pMeFlgIad_efQaz7wW-NXOGv
X-Proofpoint-Virus-Version: vendor=baseguard
engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
definitions=2024-02-27_03,2024-02-27_01,2023-05-22_02
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Add support to skip running a dma-perf test-case.
Signed-off-by: Amit Prakash Shukla <amitprakashs@marvell.com>
Acked-by: Anoob Joseph <anoobj@marvell.com>
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
---
app/test-dma-perf/config.ini | 2 ++
app/test-dma-perf/main.c | 48 ++++++++++++++++++++++--------------
app/test-dma-perf/main.h | 1 +
3 files changed, 32 insertions(+), 19 deletions(-)
diff --git a/app/test-dma-perf/config.ini b/app/test-dma-perf/config.ini
index b550f4b23f..4d59234b2a 100644
--- a/app/test-dma-perf/config.ini
+++ b/app/test-dma-perf/config.ini
@@ -36,6 +36,8 @@
; If you do not specify a result file, one will be generated with the same name as the configuration
; file, with the addition of "_result.csv" at the end.
+; "skip" To skip a test-case set skip to 1.
+
[case1]
type=DMA_MEM_COPY
mem_size=10
diff --git a/app/test-dma-perf/main.c b/app/test-dma-perf/main.c
index 544784df50..e9e40e72e7 100644
--- a/app/test-dma-perf/main.c
+++ b/app/test-dma-perf/main.c
@@ -86,6 +86,19 @@ output_header(uint32_t case_id, struct test_configure *case_cfg)
output_csv(true);
}
+static int
+open_output_csv(const char *rst_path_ptr)
+{
+ fd = fopen(rst_path_ptr, "a");
+ if (!fd) {
+ printf("Open output CSV file error.\n");
+ return 1;
+ }
+ output_csv(true);
+ fclose(fd);
+ return 0;
+}
+
static void
run_test_case(struct test_configure *case_cfg)
{
@@ -322,6 +335,7 @@ load_configs(const char *path)
const char *case_type;
const char *lcore_dma;
const char *mem_size_str, *buf_size_str, *ring_size_str, *kick_batch_str;
+ const char *skip;
int args_nr, nb_vp;
bool is_dma;
@@ -341,6 +355,13 @@ load_configs(const char *path)
for (i = 0; i < nb_sections; i++) {
snprintf(section_name, CFG_NAME_LEN, "case%d", i + 1);
test_case = &test_cases[i];
+
+ skip = rte_cfgfile_get_entry(cfgfile, section_name, "skip");
+ if (skip && (atoi(skip) == 1)) {
+ test_case->is_skip = true;
+ continue;
+ }
+
case_type = rte_cfgfile_get_entry(cfgfile, section_name, "type");
if (case_type == NULL) {
printf("Error: No case type in case %d, the test will be finished here.\n",
@@ -525,31 +546,20 @@ main(int argc, char *argv[])
printf("Running cases...\n");
for (i = 0; i < case_nb; i++) {
- if (!test_cases[i].is_valid) {
- printf("Invalid test case %d.\n\n", i + 1);
- snprintf(output_str[0], MAX_OUTPUT_STR_LEN, "Invalid case %d\n", i + 1);
-
- fd = fopen(rst_path_ptr, "a");
- if (!fd) {
- printf("Open output CSV file error.\n");
+ if (test_cases[i].is_skip) {
+ printf("Test case %d configured to be skipped.\n\n", i + 1);
+ snprintf(output_str[0], MAX_OUTPUT_STR_LEN, "Skip the test-case %d\n",
+ i + 1);
+ if (open_output_csv(rst_path_ptr))
return 0;
- }
- output_csv(true);
- fclose(fd);
continue;
}
- if (test_cases[i].test_type == TEST_TYPE_NONE) {
- printf("No valid test type in test case %d.\n\n", i + 1);
+ if (!test_cases[i].is_valid) {
+ printf("Invalid test case %d.\n\n", i + 1);
snprintf(output_str[0], MAX_OUTPUT_STR_LEN, "Invalid case %d\n", i + 1);
-
- fd = fopen(rst_path_ptr, "a");
- if (!fd) {
- printf("Open output CSV file error.\n");
+ if (open_output_csv(rst_path_ptr))
return 0;
- }
- output_csv(true);
- fclose(fd);
continue;
}
diff --git a/app/test-dma-perf/main.h b/app/test-dma-perf/main.h
index 62085e6e8f..32670151af 100644
--- a/app/test-dma-perf/main.h
+++ b/app/test-dma-perf/main.h
@@ -40,6 +40,7 @@ struct lcore_dma_map_t {
struct test_configure {
bool is_valid;
+ bool is_skip;
uint8_t test_type;
const char *test_type_str;
uint16_t src_numa_node;
--
2.34.1