From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A05F43BF0; Tue, 27 Feb 2024 19:14:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 31C31402AE; Tue, 27 Feb 2024 19:14:49 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 7C31740150 for ; Tue, 27 Feb 2024 19:14:47 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 6E5C620B74C0; Tue, 27 Feb 2024 10:14:46 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 6E5C620B74C0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1709057686; bh=4IA94y/4MWytKKwPmHcYEb6S2NEOG6XBTV30IDxT420=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FI1vCJQI5Zdl4qFpIDZNM2pHZHyMy7tjF+4ZkeUhzG5/4DO3SKGFUz0/nHyYKD+KI 0Z6E0V7SrNIuS4UQn11FKI+jaf+G/qax/LANZ7IQ/LmaoO1aHJfNwFxNtUkHKg+2IM 1hpXfxQix4sHyY5JS7UT0lExA8JgfCtsMYM9bdoQ= Date: Tue, 27 Feb 2024 10:14:46 -0800 From: Tyler Retzlaff To: Stephen Hemminger Cc: dev@dpdk.org, Anatoly Burakov , Ashish Gupta , Chenbo Xia , Cristian Dumitrescu , David Hunt , Fan Zhang , Hemant Agrawal , Honnappa Nagarahalli , Jasvinder Singh , Jerin Jacob , Konstantin Ananyev , Maxime Coquelin , Reshma Pattan , Sachin Saxena , Sivaprasad Tummala , Srikanth Yalavarthi , Sunil Kumar Kori , bruce.richardson@intel.com, mb@smartsharesystems.com, thomas@monjalon.net Subject: Re: [PATCH v3 00/16] stop using variadic argument pack extension Message-ID: <20240227181446.GA18561@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1707774557-16012-1-git-send-email-roretzla@linux.microsoft.com> <1708978786-6740-1-git-send-email-roretzla@linux.microsoft.com> <20240226125436.046684e7@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240226125436.046684e7@hermes.local> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Feb 26, 2024 at 12:54:36PM -0800, Stephen Hemminger wrote: > On Mon, 26 Feb 2024 12:19:30 -0800 > Tyler Retzlaff wrote: > > > RTE_LOG_LINE cannot be augmented with a prefix format and arguments > > without the user of RTE_LOG_LINE using the args... and ## args compiler > > extension to conditionally remove trailing comma when the macro receives > > only a single argument. > > > > Provide a new/similar macro RTE_LOG_LINE_PREFIX that accepts the prefix > > format and arguments as separate parameters allowing them to be expanded > > at the correct locations inside of RTE_FMT() allowing the rest of the > > non-prefix format string and arguments to be collapsed to the argument > > pack which can be directly forwarded with __VA_ARGS__ avoiding the need > > for conditional comma removal. > > > > I've done my best to manually check expansions (preprocessed) and compiled > > printf of the logs to validate correct output. > > > > note: due to drastic change in series i have not carried any series acks > > forward. > > The changes look good, you might want to add release note, update coding > style doc, and/or update checkpatch to discourage re-introduction. re-introduction should be protected by the CI. i know checkpatch would be better but i couldn't think of a good way to match an arbitrarily named pack ... reliably where it could potentially cause noise. i'll look into style doc in a separate series since i think there are a couple of things i'd like to propose there now that we are using C11. thanks for the review! > > Series-acked-by: Stephen Hemminger