From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3082243C2C; Wed, 28 Feb 2024 18:24:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0103140E0F; Wed, 28 Feb 2024 18:24:38 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id B280D402E3 for ; Wed, 28 Feb 2024 18:24:36 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 0F93620B74C0; Wed, 28 Feb 2024 09:24:36 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 0F93620B74C0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1709141076; bh=cn1LjQwfh3O/Qkz3/iLSp9p3uoRoW3iawSxYZLLvNMo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LO7C6IpUipW7aMNhhkllPPM9jEj1+9E2VH+GtjWVs12YPTitnVMjK4/TQWqwYJCi3 7Q0bK3uqhPAGIdQwlGvIYMF7JcXKAvq5gfumQr/KZMTx47ahzJpe6rWT68MVPWjZoJ cj1xSZnc13IELe7tRtKb8SiRcqPtXRhWTjwL6Nr4= Date: Wed, 28 Feb 2024 09:24:36 -0800 From: Tyler Retzlaff To: Konstantin Ananyev Cc: David Marchand , Konstantin Ananyev , "dev@dpdk.org" , Anatoly Burakov , Ashish Gupta , Chenbo Xia , Cristian Dumitrescu , David Hunt , Fan Zhang , Hemant Agrawal , Honnappa Nagarahalli , Jasvinder Singh , Jerin Jacob , Maxime Coquelin , Reshma Pattan , Sachin Saxena , Sivaprasad Tummala , Srikanth Yalavarthi , Stephen Hemminger , Sunil Kumar Kori , "bruce.richardson@intel.com" , "mb@smartsharesystems.com" , "thomas@monjalon.net" Subject: Re: [PATCH v3 02/16] bpf: stop using variadic argument pack extension Message-ID: <20240228172436.GA7059@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1707774557-16012-1-git-send-email-roretzla@linux.microsoft.com> <1708978786-6740-1-git-send-email-roretzla@linux.microsoft.com> <1708978786-6740-3-git-send-email-roretzla@linux.microsoft.com> <2b6538605b184359988915c8f3556d67@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2b6538605b184359988915c8f3556d67@huawei.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Feb 28, 2024 at 01:34:59PM +0000, Konstantin Ananyev wrote: > > > > > On Mon, Feb 26, 2024 at 9:20 PM Tyler Retzlaff > > wrote: > > > > > > Use RTE_LOG_LINE_PREFIX instead of RTE_LOG_LINE in macro expansions > > > which allow a prefix and arguments to be inserted into the log line > > > without the need to use the ## args variadic argument pack extension. > > > > > > Signed-off-by: Tyler Retzlaff > > > --- > > > lib/bpf/bpf_impl.h | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/lib/bpf/bpf_impl.h b/lib/bpf/bpf_impl.h > > > index 1a3d97d..680b1e5 100644 > > > --- a/lib/bpf/bpf_impl.h > > > +++ b/lib/bpf/bpf_impl.h > > > @@ -29,8 +29,8 @@ struct rte_bpf { > > > extern int rte_bpf_logtype; > > > #define RTE_LOGTYPE_BPF rte_bpf_logtype > > > > > > -#define RTE_BPF_LOG_LINE(lvl, fmt, args...) \ > > > - RTE_LOG_LINE(lvl, BPF, fmt, ##args) > > > +#define RTE_BPF_LOG_LINE(level, ...) \ > > > + RTE_LOG_LINE_PREFIX(level, BPF, "%s(): ", __func__, __VA_ARGS__) > > > > The patch $topic seems to be removal of variadic argument extension. > > So, I would expect a simple: > > +#define RTE_BPF_LOG_LINE(level, ...) \ > > + RTE_LOG_LINE(level, BPF, __VA_ARGS__) > > > > Konstantin, just to be sure, are you ok with this (debug from my pov) > > prefix addition? > > > > Thanks David for spotting it, yes somehow I missed that. > Actually yes, yours variant looks correct to me. > Konstantin. oh, sorry about this. i did not intend to add prefixes where there were none. would you like me to restore this with David's suggestion or would you like to keep the prefix with __func__? let me know i'll make an adjustment to the series if necessary. >