From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CE59B43BAD; Thu, 29 Feb 2024 22:53:36 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5BD4B42D2A; Thu, 29 Feb 2024 22:53:36 +0100 (CET) Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) by mails.dpdk.org (Postfix) with ESMTP id DDE9F40156 for ; Thu, 29 Feb 2024 22:53:34 +0100 (CET) Received: by mail-ot1-f43.google.com with SMTP id 46e09a7af769-6e48153c13aso763473a34.3 for ; Thu, 29 Feb 2024 13:53:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709243614; x=1709848414; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=MkITFGh6Eeqk1zDf6qq5/4FNofO8y720uA2S+hnJO2M=; b=YODJpQc98NNgY2oyE8+c8t3cgyYAjI+YKui545zuqnv++a74XMEfB6BOzmnpdrDikb ZLbocAsVWy9+bjdJSudZYzNSYay+ZBkNpyt8CyEj54Wbu4K3SEdj+newJ8RUEnCfUKcZ pfz+aGS8oKxl5igeHIYT6NUJXIx1E1aygDq/D1GW0YGWxy2lQKkPfmlUNRaRMOXvT/e6 ue1POwx1cSBU6yd2oM4IS8v01MV0jbGxwfqrNe1OLbelVccSX60/dJqZR8EOnWkSc5j3 K9Y/lMBVll7FlrmeSpDcshNlBDE1bv/4qocB87JXwRo9qz7YYnoAqVif3gM5dDfWDjlL x9Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709243614; x=1709848414; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MkITFGh6Eeqk1zDf6qq5/4FNofO8y720uA2S+hnJO2M=; b=lIXzqspwTbS4l1YyfwRDvQHGtdHhZsbx7pstCCefv4hKGKakAgHEqqdZV208zO+KSB i/3d80GbcAyy/J9Pf6zR2XQkcRLjeKi9KeNzl85MlHqzpBwzUlkxZq6Hv7RiarV0qXCR pbiQYc3VHtBdM1Ugv5Dy+p7nFqxOweDjVnSSOAszv5kXqyat42+xzTDV5hfqaT7FM1hW eD2lHpQHhRMhQmrcgw7z20RTjT8db8jilDN5OT+0wVp9GRcu9psMEFW3MPMol71adjuH UlJxxoRd/5j/+563i51e+Dw3Jvma4V57ukxMPbuEKTT6kfi9wDzvHUnRlXgjDGBVi5Ng S+iQ== X-Forwarded-Encrypted: i=1; AJvYcCURz5R86fFmFyS0bo8mTA4fegYlo6P2dXHEr0ia65WM3zseTqtYkn+dgxUM9yWMALvEwdS4RxodfevP22I= X-Gm-Message-State: AOJu0Yyh5IlQapdNx6Z1o8XgWkN41IonutA15MJ0WT5nlpyXj7LOeh1j nusW3tsKzANIHfcF0c5ff6o8I9sXgb9XfiAqrK0CCy5d6IY2HPiSbfiYIQDJSuw= X-Google-Smtp-Source: AGHT+IHPRtqVd5yj+V7zQARWjHAxNP2zntMKLTswsJN8dLUVRHN3ONKyQD19xKbAt71NwqLaT5NtvA== X-Received: by 2002:a05:6830:1e08:b0:6e4:9081:8561 with SMTP id s8-20020a0568301e0800b006e490818561mr3207918otr.32.1709243613946; Thu, 29 Feb 2024 13:53:33 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id e25-20020a62aa19000000b006e45dce37basm1734796pff.220.2024.02.29.13.53.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 13:53:33 -0800 (PST) Date: Thu, 29 Feb 2024 13:53:32 -0800 From: Stephen Hemminger To: Alan Elder Cc: Long Li , Ferruh Yigit , Andrew Rybchenko , "dev@dpdk.org" Subject: Re: [PATCH] net/netvsc: fix number Tx queues > Rx queues Message-ID: <20240229135332.17f2fa50@hermes.local> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 29 Feb 2024 19:29:11 +0000 Alan Elder wrote: > The previous code allowed the number of Tx queues to be set higher than > the number of Rx queues. If a packet was sent on a Tx queue with index > >= number Rx queues there was a segfault. > > This commit fixes the issue by creating an Rx queue for every Tx queue > meaning that an event buffer is allocated to handle receiving Tx > completion messages. > > mbuf pool and Rx ring are not allocated for these additional Rx queues > and RSS configuration ensures that no packets are received on them. > > Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device") > Cc: sthemmin@microsoft.com > Cc: stable@dpdk.org > > Signed-off-by: Alan Elder Don't have Azure account to test, but looks good to me. Acked-by: Stephen Hemminger