DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Subject: [PATCH 5/6] pipeline: replace use of rand()
Date: Fri,  1 Mar 2024 09:57:10 -0800	[thread overview]
Message-ID: <20240301175842.159967-6-stephen@networkplumber.org> (raw)
In-Reply-To: <20240301175842.159967-1-stephen@networkplumber.org>

The rand() function is weak and using it for salt might be a future
security issue. Use rte_rand() which has a bigger period and more
secure.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/pipeline/rte_swx_ipsec.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/pipeline/rte_swx_ipsec.c b/lib/pipeline/rte_swx_ipsec.c
index 28576c2a4812..eb97b9eb9106 100644
--- a/lib/pipeline/rte_swx_ipsec.c
+++ b/lib/pipeline/rte_swx_ipsec.c
@@ -7,6 +7,7 @@
 #include <arpa/inet.h>
 
 #include <rte_common.h>
+#include <rte_random.h>
 #include <rte_ip.h>
 #include <rte_tailq.h>
 #include <rte_eal_memconfig.h>
@@ -1453,7 +1454,7 @@ crypto_xform_get(struct rte_swx_ipsec_sa_params *p,
 		switch (p->crypto.cipher_auth.cipher.alg) {
 		case RTE_CRYPTO_CIPHER_AES_CBC:
 		case RTE_CRYPTO_CIPHER_3DES_CBC:
-			salt = (uint32_t)rand();
+			salt = rte_rand();
 			break;
 
 		case RTE_CRYPTO_CIPHER_AES_CTR:
-- 
2.43.0


  parent reply	other threads:[~2024-03-01 17:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-01 17:57 [PATCH 0/6] Coverity related fixes Stephen Hemminger
2024-03-01 17:57 ` [PATCH 1/6] test/bpf: make sure mbuf is initialized Stephen Hemminger
2024-03-01 18:09   ` Tyler Retzlaff
2024-03-01 17:57 ` [PATCH 2/6] net/tap: log if netlink ext ack not possible Stephen Hemminger
2024-03-01 17:57 ` [PATCH 3/6] examples/l2fwd-keepalive: use rte_drand_max Stephen Hemminger
2024-03-01 17:57 ` [PATCH 4/6] net/qede: replace use of rand() Stephen Hemminger
2024-03-01 18:10   ` Tyler Retzlaff
2024-03-01 17:57 ` Stephen Hemminger [this message]
2024-03-01 18:11   ` [PATCH 5/6] pipeline: " Tyler Retzlaff
2024-03-01 17:57 ` [PATCH 6/6] baseband/fpga_5gnr: don't use rand() Stephen Hemminger
2024-03-01 18:11   ` Tyler Retzlaff
2024-03-02  1:07   ` Chautru, Nicolas
2024-03-06 20:08 ` [PATCH 0/6] Coverity related fixes David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240301175842.159967-6-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).