From: <shaibran@amazon.com>
To: <ferruh.yigit@amd.com>
Cc: <dev@dpdk.org>, Shai Brandes <shaibran@amazon.com>
Subject: [PATCH 22/33] net/ena/hal: rework Rx ring submission queue
Date: Mon, 4 Mar 2024 11:01:25 +0200 [thread overview]
Message-ID: <20240304090136.861-23-shaibran@amazon.com> (raw)
In-Reply-To: <20240304090136.861-1-shaibran@amazon.com>
From: Shai Brandes <shaibran@amazon.com>
RX ring submission queue descriptors are always located in host memory
This optimization replaces the generic update tail method with a
tailored method for host memory type descriptors to avoid unnecessary if
statement.
Signed-off-by: Shai Brandes <shaibran@amazon.com>
Reviewed-by: Amit Bernstein <amitbern@amazon.com>
---
drivers/net/ena/hal/ena_eth_com.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ena/hal/ena_eth_com.c b/drivers/net/ena/hal/ena_eth_com.c
index b9123f84c3..ebad38d15a 100644
--- a/drivers/net/ena/hal/ena_eth_com.c
+++ b/drivers/net/ena/hal/ena_eth_com.c
@@ -210,11 +210,8 @@ static int ena_com_sq_update_llq_tail(struct ena_com_io_sq *io_sq)
return ENA_COM_OK;
}
-static int ena_com_sq_update_tail(struct ena_com_io_sq *io_sq)
+static int ena_com_sq_update_reqular_queue_tail(struct ena_com_io_sq *io_sq)
{
- if (io_sq->mem_queue_type == ENA_ADMIN_PLACEMENT_POLICY_DEV)
- return ena_com_sq_update_llq_tail(io_sq);
-
io_sq->tail++;
/* Switch phase bit in case of wrap around */
@@ -224,6 +221,14 @@ static int ena_com_sq_update_tail(struct ena_com_io_sq *io_sq)
return ENA_COM_OK;
}
+static int ena_com_sq_update_tail(struct ena_com_io_sq *io_sq)
+{
+ if (io_sq->mem_queue_type == ENA_ADMIN_PLACEMENT_POLICY_DEV)
+ return ena_com_sq_update_llq_tail(io_sq);
+
+ return ena_com_sq_update_reqular_queue_tail(io_sq);
+}
+
static struct ena_eth_io_rx_cdesc_base *
ena_com_rx_cdesc_idx_to_ptr(struct ena_com_io_cq *io_cq, u16 idx)
{
@@ -662,7 +667,7 @@ int ena_com_add_single_rx_desc(struct ena_com_io_sq *io_sq,
desc->buff_addr_hi =
((ena_buf->paddr & GENMASK_ULL(io_sq->dma_addr_bits - 1, 32)) >> 32);
- return ena_com_sq_update_tail(io_sq);
+ return ena_com_sq_update_reqular_queue_tail(io_sq);
}
bool ena_com_cq_empty(struct ena_com_io_cq *io_cq)
--
2.17.1
next prev parent reply other threads:[~2024-03-04 9:05 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 9:01 [PATCH 00/33] net/ena: v2.9.0 driver release shaibran
2024-03-04 9:01 ` [PATCH 01/33] net/ena: rework the metrics multi-process functions shaibran
2024-03-04 9:01 ` [PATCH 02/33] net/ena: report new supported link speed capabilities shaibran
2024-03-04 9:01 ` [PATCH 03/33] net/ena: update imissed stat with Rx overruns shaibran
2024-03-04 9:01 ` [PATCH 04/33] net/ena: sub-optimal configuration notifications support shaibran
2024-03-04 9:01 ` [PATCH 05/33] net/ena: fix fast mbuf free shaibran
2024-03-04 9:01 ` [PATCH 06/33] net/ena: rename base folder to hal shaibran
2024-03-04 9:01 ` [PATCH 07/33] net/ena: restructure the llq policy setting process shaibran
2024-03-04 9:01 ` [PATCH 08/33] net/ena/hal: exponential backoff exp limit shaibran
2024-03-04 9:01 ` [PATCH 09/33] net/ena/hal: add a new csum offload bit shaibran
2024-03-04 9:01 ` [PATCH 10/33] net/ena/hal: added a bus parameter to ena memcpy macro shaibran
2024-03-04 9:01 ` [PATCH 11/33] net/ena/hal: optimize Rx ring submission queue shaibran
2024-03-04 9:01 ` [PATCH 12/33] net/ena/hal: rename fields in completion descriptors shaibran
2024-03-04 9:01 ` [PATCH 13/33] net/ena/hal: use correct read once on u8 field shaibran
2024-03-04 9:01 ` [PATCH 14/33] net/ena/hal: add completion descriptor corruption check shaibran
2024-03-04 9:01 ` [PATCH 15/33] net/ena/hal: malformed Tx descriptor error reason shaibran
2024-03-04 9:01 ` [PATCH 16/33] net/ena/hal: phc feature modifications shaibran
2024-03-04 9:01 ` [PATCH 17/33] net/ena/hal: restructure interrupt handling shaibran
2024-03-04 9:01 ` [PATCH 18/33] net/ena/hal: add unlikely to error checks shaibran
2024-03-04 9:01 ` [PATCH 19/33] net/ena/hal: missing admin interrupt reset reason shaibran
2024-03-04 9:01 ` [PATCH 20/33] net/ena/hal: check for existing keep alive notification shaibran
2024-03-04 9:01 ` [PATCH 21/33] net/ena/hal: modify memory barrier comment shaibran
2024-03-04 9:01 ` shaibran [this message]
2024-03-04 9:01 ` [PATCH 23/33] net/ena/hal: remove operating system type enum shaibran
2024-03-04 9:01 ` [PATCH 24/33] net/ena/hal: handle command abort shaibran
2024-03-04 9:01 ` [PATCH 25/33] net/ena/hal: add support for device reset request shaibran
2024-03-04 9:01 ` [PATCH 26/33] net/ena: cosmetic changes shaibran
2024-03-04 9:01 ` [PATCH 27/33] net/ena/hal: modify customer metrics memory management shaibran
2024-03-04 9:01 ` [PATCH 28/33] net/ena/hal: cosmetic changes shaibran
2024-03-04 9:01 ` [PATCH 29/33] net/ena: update device-preferred size of rings shaibran
2024-03-04 9:01 ` [PATCH 30/33] net/ena: exhaust interrupt callbacks in device close shaibran
2024-03-04 9:01 ` [PATCH 31/33] net/ena: support max large llq depth from the device shaibran
2024-03-04 9:01 ` [PATCH 32/33] net/ena: control path pure polling mode shaibran
2024-03-04 9:01 ` [PATCH 33/33] net/ena: upgrade driver version to 2.9.0 shaibran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240304090136.861-23-shaibran@amazon.com \
--to=shaibran@amazon.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).