From: <shaibran@amazon.com>
To: <ferruh.yigit@amd.com>
Cc: <dev@dpdk.org>, Shai Brandes <shaibran@amazon.com>
Subject: [PATCH 26/33] net/ena: cosmetic changes
Date: Mon, 4 Mar 2024 11:01:29 +0200 [thread overview]
Message-ID: <20240304090136.861-27-shaibran@amazon.com> (raw)
In-Reply-To: <20240304090136.861-1-shaibran@amazon.com>
From: Shai Brandes <shaibran@amazon.com>
This patch makes several changes to improve
the style and readability of the code.
Signed-off-by: Shai Brandes <shaibran@amazon.com>
Reviewed-by: Amit Bernstein <amitbern@amazon.com>
---
drivers/net/ena/hal/ena_com.c | 15 ++++++---------
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers/net/ena/hal/ena_com.c b/drivers/net/ena/hal/ena_com.c
index 1c88a82ffc..2db21e7895 100644
--- a/drivers/net/ena/hal/ena_com.c
+++ b/drivers/net/ena/hal/ena_com.c
@@ -1808,7 +1808,7 @@ int ena_com_phc_config(struct ena_com_dev *ena_dev)
/* Supporting only PHC V0 (readless mode with error bound) */
if (get_feat_resp.u.phc.version != ENA_ADMIN_PHC_FEATURE_VERSION_0) {
- ena_trc_err(ena_dev, "Unsupprted PHC version (0x%X), error: %d\n",
+ ena_trc_err(ena_dev, "Unsupported PHC version (0x%X), error: %d\n",
get_feat_resp.u.phc.version,
ENA_COM_UNSUPPORTED);
return ENA_COM_UNSUPPORTED;
@@ -1914,15 +1914,14 @@ int ena_com_phc_get_timestamp(struct ena_com_dev *ena_dev, u64 *timestamp)
/* PHC is in active state, update statistics according to req_id and error_flags */
if ((READ_ONCE16(read_resp->req_id) != phc->req_id) ||
- (read_resp->error_flags & ENA_PHC_ERROR_FLAGS)) {
+ (read_resp->error_flags & ENA_PHC_ERROR_FLAGS))
/* Device didn't update req_id during blocking time or timestamp is invalid,
* this indicates on a device error
*/
phc->stats.phc_err++;
- } else {
+ else
/* Device updated req_id during blocking time with valid timestamp */
phc->stats.phc_exp++;
- }
}
/* Setting relative timeouts */
@@ -2431,7 +2430,7 @@ void ena_com_aenq_intr_handler(struct ena_com_dev *ena_dev, void *data)
timestamp = (u64)aenq_common->timestamp_low |
((u64)aenq_common->timestamp_high << 32);
- ena_trc_dbg(ena_dev, "AENQ! Group[%x] Syndrome[%x] timestamp: [%" ENA_PRIU64 "s]\n",
+ ena_trc_dbg(ena_dev, "AENQ! Group[%x] Syndrome[%x] timestamp: [%" ENA_PRIu64 "s]\n",
aenq_common->group,
aenq_common->syndrome,
timestamp);
@@ -3233,16 +3232,15 @@ int ena_com_allocate_customer_metrics_buffer(struct ena_com_dev *ena_dev)
{
struct ena_customer_metrics *customer_metrics = &ena_dev->customer_metrics;
+ customer_metrics->buffer_len = ENA_CUSTOMER_METRICS_BUFFER_SIZE;
ENA_MEM_ALLOC_COHERENT(ena_dev->dmadev,
customer_metrics->buffer_len,
customer_metrics->buffer_virt_addr,
customer_metrics->buffer_dma_addr,
customer_metrics->buffer_dma_handle);
- if (unlikely(customer_metrics->buffer_virt_addr == NULL))
+ if (unlikely(!customer_metrics->buffer_virt_addr))
return ENA_COM_NO_MEM;
- customer_metrics->buffer_len = ENA_CUSTOMER_METRICS_BUFFER_SIZE;
-
return 0;
}
@@ -3285,7 +3283,6 @@ void ena_com_delete_customer_metrics_buffer(struct ena_com_dev *ena_dev)
customer_metrics->buffer_dma_addr,
customer_metrics->buffer_dma_handle);
customer_metrics->buffer_virt_addr = NULL;
- customer_metrics->buffer_len = 0;
}
}
--
2.17.1
next prev parent reply other threads:[~2024-03-04 9:06 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 9:01 [PATCH 00/33] net/ena: v2.9.0 driver release shaibran
2024-03-04 9:01 ` [PATCH 01/33] net/ena: rework the metrics multi-process functions shaibran
2024-03-04 9:01 ` [PATCH 02/33] net/ena: report new supported link speed capabilities shaibran
2024-03-04 9:01 ` [PATCH 03/33] net/ena: update imissed stat with Rx overruns shaibran
2024-03-04 9:01 ` [PATCH 04/33] net/ena: sub-optimal configuration notifications support shaibran
2024-03-04 9:01 ` [PATCH 05/33] net/ena: fix fast mbuf free shaibran
2024-03-04 9:01 ` [PATCH 06/33] net/ena: rename base folder to hal shaibran
2024-03-04 9:01 ` [PATCH 07/33] net/ena: restructure the llq policy setting process shaibran
2024-03-04 9:01 ` [PATCH 08/33] net/ena/hal: exponential backoff exp limit shaibran
2024-03-04 9:01 ` [PATCH 09/33] net/ena/hal: add a new csum offload bit shaibran
2024-03-04 9:01 ` [PATCH 10/33] net/ena/hal: added a bus parameter to ena memcpy macro shaibran
2024-03-04 9:01 ` [PATCH 11/33] net/ena/hal: optimize Rx ring submission queue shaibran
2024-03-04 9:01 ` [PATCH 12/33] net/ena/hal: rename fields in completion descriptors shaibran
2024-03-04 9:01 ` [PATCH 13/33] net/ena/hal: use correct read once on u8 field shaibran
2024-03-04 9:01 ` [PATCH 14/33] net/ena/hal: add completion descriptor corruption check shaibran
2024-03-04 9:01 ` [PATCH 15/33] net/ena/hal: malformed Tx descriptor error reason shaibran
2024-03-04 9:01 ` [PATCH 16/33] net/ena/hal: phc feature modifications shaibran
2024-03-04 9:01 ` [PATCH 17/33] net/ena/hal: restructure interrupt handling shaibran
2024-03-04 9:01 ` [PATCH 18/33] net/ena/hal: add unlikely to error checks shaibran
2024-03-04 9:01 ` [PATCH 19/33] net/ena/hal: missing admin interrupt reset reason shaibran
2024-03-04 9:01 ` [PATCH 20/33] net/ena/hal: check for existing keep alive notification shaibran
2024-03-04 9:01 ` [PATCH 21/33] net/ena/hal: modify memory barrier comment shaibran
2024-03-04 9:01 ` [PATCH 22/33] net/ena/hal: rework Rx ring submission queue shaibran
2024-03-04 9:01 ` [PATCH 23/33] net/ena/hal: remove operating system type enum shaibran
2024-03-04 9:01 ` [PATCH 24/33] net/ena/hal: handle command abort shaibran
2024-03-04 9:01 ` [PATCH 25/33] net/ena/hal: add support for device reset request shaibran
2024-03-04 9:01 ` shaibran [this message]
2024-03-04 9:01 ` [PATCH 27/33] net/ena/hal: modify customer metrics memory management shaibran
2024-03-04 9:01 ` [PATCH 28/33] net/ena/hal: cosmetic changes shaibran
2024-03-04 9:01 ` [PATCH 29/33] net/ena: update device-preferred size of rings shaibran
2024-03-04 9:01 ` [PATCH 30/33] net/ena: exhaust interrupt callbacks in device close shaibran
2024-03-04 9:01 ` [PATCH 31/33] net/ena: support max large llq depth from the device shaibran
2024-03-04 9:01 ` [PATCH 32/33] net/ena: control path pure polling mode shaibran
2024-03-04 9:01 ` [PATCH 33/33] net/ena: upgrade driver version to 2.9.0 shaibran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240304090136.861-27-shaibran@amazon.com \
--to=shaibran@amazon.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).