From: <shaibran@amazon.com>
To: <ferruh.yigit@amd.com>
Cc: <dev@dpdk.org>, Shai Brandes <shaibran@amazon.com>
Subject: [PATCH v2 19/33] net/ena/hal: missing admin interrupt reset reason
Date: Mon, 4 Mar 2024 14:29:28 +0200 [thread overview]
Message-ID: <20240304122942.3496-20-shaibran@amazon.com> (raw)
In-Reply-To: <20240304122942.3496-1-shaibran@amazon.com>
From: Shai Brandes <shaibran@amazon.com>
There can be cases when we trigger reset if an admin interrupt
is missing.
In order to identify this use-case specifically,
this commit adds a new reset reason.
Signed-off-by: Shai Brandes <shaibran@amazon.com>
Reviewed-by: Amit Bernstein <amitbern@amazon.com>
---
drivers/net/ena/hal/ena_com.c | 2 ++
drivers/net/ena/hal/ena_com.h | 12 ++++++++++++
drivers/net/ena/hal/ena_defs/ena_regs_defs.h | 1 +
3 files changed, 15 insertions(+)
diff --git a/drivers/net/ena/hal/ena_com.c b/drivers/net/ena/hal/ena_com.c
index d2de5e172d..8e9c112715 100644
--- a/drivers/net/ena/hal/ena_com.c
+++ b/drivers/net/ena/hal/ena_com.c
@@ -803,6 +803,7 @@ static int ena_com_wait_and_process_admin_cq_interrupts(struct ena_comp_ctx *com
ENA_SPINLOCK_UNLOCK(admin_queue->q_lock, flags);
if (comp_ctx->status == ENA_CMD_COMPLETED) {
+ admin_queue->is_missing_admin_interrupt = true;
ena_trc_err(admin_queue->ena_dev,
"The ena device sent a completion but the driver didn't receive a MSI-X interrupt (cmd %d), autopolling mode is %s\n",
comp_ctx->cmd_opcode, admin_queue->auto_polling ? "ON" : "OFF");
@@ -2138,6 +2139,7 @@ int ena_com_admin_init(struct ena_com_dev *ena_dev,
admin_queue->ena_dev = ena_dev;
admin_queue->running_state = true;
+ admin_queue->is_missing_admin_interrupt = false;
return 0;
error:
diff --git a/drivers/net/ena/hal/ena_com.h b/drivers/net/ena/hal/ena_com.h
index c62016cc06..c999cd2381 100644
--- a/drivers/net/ena/hal/ena_com.h
+++ b/drivers/net/ena/hal/ena_com.h
@@ -237,6 +237,8 @@ struct ena_com_admin_queue {
*/
bool running_state;
+ bool is_missing_admin_interrupt;
+
/* Count the number of outstanding admin commands */
ena_atomic32_t outstanding_cmds;
@@ -1089,6 +1091,16 @@ int ena_com_config_dev_mode(struct ena_com_dev *ena_dev,
struct ena_admin_feature_llq_desc *llq_features,
struct ena_llq_configurations *llq_default_config);
+/* ena_com_get_missing_admin_interrupt - Return if there is a missing admin interrupt
+ * @ena_dev: ENA communication layer struct
+ *
+ * @return - true if there is a missing admin interrupt or false otherwise
+ */
+static inline bool ena_com_get_missing_admin_interrupt(struct ena_com_dev *ena_dev)
+{
+ return ena_dev->admin_queue.is_missing_admin_interrupt;
+}
+
/* ena_com_io_sq_to_ena_dev - Extract ena_com_dev using contained field io_sq.
* @io_sq: IO submit queue struct
*
diff --git a/drivers/net/ena/hal/ena_defs/ena_regs_defs.h b/drivers/net/ena/hal/ena_defs/ena_regs_defs.h
index a94025dc77..db6a97d675 100644
--- a/drivers/net/ena/hal/ena_defs/ena_regs_defs.h
+++ b/drivers/net/ena/hal/ena_defs/ena_regs_defs.h
@@ -24,6 +24,7 @@ enum ena_regs_reset_reason_types {
ENA_REGS_RESET_SUSPECTED_POLL_STARVATION = 15,
ENA_REGS_RESET_RX_DESCRIPTOR_MALFORMED = 16,
ENA_REGS_RESET_TX_DESCRIPTOR_MALFORMED = 17,
+ ENA_REGS_RESET_MISSING_ADMIN_INTERRUPT = 18,
ENA_REGS_RESET_LAST,
};
--
2.17.1
next prev parent reply other threads:[~2024-03-04 12:32 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 12:29 [PATCH v2 00/33] net/ena: v2.9.0 driver release shaibran
2024-03-04 12:29 ` [PATCH v2 01/33] net/ena: rework the metrics multi-process functions shaibran
2024-03-04 12:29 ` [PATCH v2 02/33] net/ena: report new supported link speed capabilities shaibran
2024-03-04 12:29 ` [PATCH v2 03/33] net/ena: update imissed stat with Rx overruns shaibran
2024-03-04 12:29 ` [PATCH v2 04/33] net/ena: sub-optimal configuration notifications support shaibran
2024-03-04 12:29 ` [PATCH v2 05/33] net/ena: fix fast mbuf free shaibran
2024-03-04 12:29 ` [PATCH v2 06/33] net/ena: rename base folder to hal shaibran
2024-03-04 12:29 ` [PATCH v2 07/33] net/ena: restructure the llq policy setting process shaibran
2024-03-04 12:29 ` [PATCH v2 08/33] net/ena/hal: exponential backoff exp limit shaibran
2024-03-04 12:29 ` [PATCH v2 09/33] net/ena/hal: add a new csum offload bit shaibran
2024-03-04 12:29 ` [PATCH v2 10/33] net/ena/hal: added a bus parameter to ena memcpy macro shaibran
2024-03-04 12:29 ` [PATCH v2 11/33] net/ena/hal: optimize Rx ring submission queue shaibran
2024-03-04 12:29 ` [PATCH v2 12/33] net/ena/hal: rename fields in completion descriptors shaibran
2024-03-04 12:29 ` [PATCH v2 13/33] net/ena/hal: use correct read once on u8 field shaibran
2024-03-04 12:29 ` [PATCH v2 14/33] net/ena/hal: add completion descriptor corruption check shaibran
2024-03-04 12:29 ` [PATCH v2 15/33] net/ena/hal: malformed Tx descriptor error reason shaibran
2024-03-04 12:29 ` [PATCH v2 16/33] net/ena/hal: phc feature modifications shaibran
2024-03-04 12:29 ` [PATCH v2 17/33] net/ena/hal: restructure interrupt handling shaibran
2024-03-04 12:29 ` [PATCH v2 18/33] net/ena/hal: add unlikely to error checks shaibran
2024-03-04 12:29 ` shaibran [this message]
2024-03-04 12:29 ` [PATCH v2 20/33] net/ena/hal: check for existing keep alive notification shaibran
2024-03-04 12:29 ` [PATCH v2 21/33] net/ena/hal: modify memory barrier comment shaibran
2024-03-04 12:29 ` [PATCH v2 22/33] net/ena/hal: rework Rx ring submission queue shaibran
2024-03-04 12:29 ` [PATCH v2 23/33] net/ena/hal: remove operating system type enum shaibran
2024-03-04 12:29 ` [PATCH v2 24/33] net/ena/hal: handle command abort shaibran
2024-03-04 12:29 ` [PATCH v2 25/33] net/ena/hal: add support for device reset request shaibran
2024-03-04 12:29 ` [PATCH v2 26/33] net/ena: cosmetic changes shaibran
2024-03-04 12:29 ` [PATCH v2 27/33] net/ena/hal: modify customer metrics memory management shaibran
2024-03-04 12:29 ` [PATCH v2 28/33] net/ena/hal: cosmetic changes shaibran
2024-03-04 12:29 ` [PATCH v2 29/33] net/ena: update device-preferred size of rings shaibran
2024-03-04 12:29 ` [PATCH v2 30/33] net/ena: exhaust interrupt callbacks in device close shaibran
2024-03-04 12:29 ` [PATCH v2 31/33] net/ena: support max large llq depth from the device shaibran
2024-03-04 12:29 ` [PATCH v2 32/33] net/ena: control path pure polling mode shaibran
2024-03-04 12:29 ` [PATCH v2 33/33] net/ena: upgrade driver version to 2.9.0 shaibran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240304122942.3496-20-shaibran@amazon.com \
--to=shaibran@amazon.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).