From: <shaibran@amazon.com>
To: <ferruh.yigit@amd.com>
Cc: <dev@dpdk.org>, Shai Brandes <shaibran@amazon.com>
Subject: [PATCH v2 04/33] net/ena: sub-optimal configuration notifications support
Date: Mon, 4 Mar 2024 14:29:13 +0200 [thread overview]
Message-ID: <20240304122942.3496-5-shaibran@amazon.com> (raw)
In-Reply-To: <20240304122942.3496-1-shaibran@amazon.com>
From: Shai Brandes <shaibran@amazon.com>
ENA device will send asynchronous notifications to the
driver in order to notify users about sub-optimal configurations
and refer them to public AWS documentation for further action.
Signed-off-by: Shai Brandes <shaibran@amazon.com>
Reviewed-by: Amit Bernstein <amitbern@amazon.com>
---
doc/guides/rel_notes/release_24_03.rst | 1 +
.../net/ena/base/ena_defs/ena_admin_defs.h | 11 +++++++-
drivers/net/ena/ena_ethdev.c | 26 +++++++++++++++++--
3 files changed, 35 insertions(+), 3 deletions(-)
diff --git a/doc/guides/rel_notes/release_24_03.rst b/doc/guides/rel_notes/release_24_03.rst
index fb66d67d32..f47073c7dc 100644
--- a/doc/guides/rel_notes/release_24_03.rst
+++ b/doc/guides/rel_notes/release_24_03.rst
@@ -104,6 +104,7 @@ New Features
* **Updated Amazon ena (Elastic Network Adapter) net driver.**
* Removed the reporting of `rx_overruns` errors from xstats and instead updated `imissed` stat with its value.
+ * Added support for sub-optimal configuration notifications from the device.
* **Updated Atomic Rules' Arkville driver.**
diff --git a/drivers/net/ena/base/ena_defs/ena_admin_defs.h b/drivers/net/ena/base/ena_defs/ena_admin_defs.h
index fa43e22918..4172916551 100644
--- a/drivers/net/ena/base/ena_defs/ena_admin_defs.h
+++ b/drivers/net/ena/base/ena_defs/ena_admin_defs.h
@@ -1214,7 +1214,8 @@ enum ena_admin_aenq_group {
ENA_ADMIN_NOTIFICATION = 3,
ENA_ADMIN_KEEP_ALIVE = 4,
ENA_ADMIN_REFRESH_CAPABILITIES = 5,
- ENA_ADMIN_AENQ_GROUPS_NUM = 6,
+ ENA_ADMIN_CONF_NOTIFICATIONS = 6,
+ ENA_ADMIN_AENQ_GROUPS_NUM = 7,
};
enum ena_admin_aenq_notification_syndrome {
@@ -1251,6 +1252,14 @@ struct ena_admin_aenq_keep_alive_desc {
uint32_t rx_overruns_high;
};
+struct ena_admin_aenq_conf_notifications_desc {
+ struct ena_admin_aenq_common_desc aenq_common_desc;
+
+ uint64_t notifications_bitmap;
+
+ uint64_t reserved;
+};
+
struct ena_admin_ena_mmio_req_read_less_resp {
uint16_t req_id;
diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
index d3f395a832..3157237c0d 100644
--- a/drivers/net/ena/ena_ethdev.c
+++ b/drivers/net/ena/ena_ethdev.c
@@ -36,6 +36,10 @@
#define ENA_MIN_RING_DESC 128
+#define BITS_PER_BYTE 8
+
+#define BITS_PER_TYPE(type) (sizeof(type) * BITS_PER_BYTE)
+
/*
* We should try to keep ENA_CLEANUP_BUF_SIZE lower than
* RTE_MEMPOOL_CACHE_MAX_SIZE, so we can fit this in mempool local cache.
@@ -1842,7 +1846,8 @@ static int ena_device_init(struct ena_adapter *adapter,
BIT(ENA_ADMIN_NOTIFICATION) |
BIT(ENA_ADMIN_KEEP_ALIVE) |
BIT(ENA_ADMIN_FATAL_ERROR) |
- BIT(ENA_ADMIN_WARNING);
+ BIT(ENA_ADMIN_WARNING) |
+ BIT(ENA_ADMIN_CONF_NOTIFICATIONS);
aenq_groups &= get_feat_ctx->aenq.supported_groups;
@@ -4021,6 +4026,22 @@ static void ena_keep_alive(void *adapter_data,
adapter->dev_stats.tx_drops = tx_drops;
}
+static void ena_suboptimal_configuration(__rte_unused void *adapter_data,
+ struct ena_admin_aenq_entry *aenq_e)
+{
+ struct ena_admin_aenq_conf_notifications_desc *desc;
+ int bit, num_bits;
+
+ desc = (struct ena_admin_aenq_conf_notifications_desc *)aenq_e;
+ num_bits = BITS_PER_TYPE(desc->notifications_bitmap);
+ for (bit = 0; bit < num_bits; bit++) {
+ if (desc->notifications_bitmap & RTE_BIT64(bit)) {
+ PMD_DRV_LOG(WARNING,
+ "Sub-optimal configuration notification code: %d\n", bit + 1);
+ }
+ }
+}
+
/**
* This handler will called for unknown event group or unimplemented handlers
**/
@@ -4035,7 +4056,8 @@ static struct ena_aenq_handlers aenq_handlers = {
.handlers = {
[ENA_ADMIN_LINK_CHANGE] = ena_update_on_link_change,
[ENA_ADMIN_NOTIFICATION] = ena_notification,
- [ENA_ADMIN_KEEP_ALIVE] = ena_keep_alive
+ [ENA_ADMIN_KEEP_ALIVE] = ena_keep_alive,
+ [ENA_ADMIN_CONF_NOTIFICATIONS] = ena_suboptimal_configuration
},
.unimplemented_handler = unimplemented_aenq_handler
};
--
2.17.1
next prev parent reply other threads:[~2024-03-04 12:31 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 12:29 [PATCH v2 00/33] net/ena: v2.9.0 driver release shaibran
2024-03-04 12:29 ` [PATCH v2 01/33] net/ena: rework the metrics multi-process functions shaibran
2024-03-04 12:29 ` [PATCH v2 02/33] net/ena: report new supported link speed capabilities shaibran
2024-03-04 12:29 ` [PATCH v2 03/33] net/ena: update imissed stat with Rx overruns shaibran
2024-03-04 12:29 ` shaibran [this message]
2024-03-04 12:29 ` [PATCH v2 05/33] net/ena: fix fast mbuf free shaibran
2024-03-04 12:29 ` [PATCH v2 06/33] net/ena: rename base folder to hal shaibran
2024-03-04 12:29 ` [PATCH v2 07/33] net/ena: restructure the llq policy setting process shaibran
2024-03-04 12:29 ` [PATCH v2 08/33] net/ena/hal: exponential backoff exp limit shaibran
2024-03-04 12:29 ` [PATCH v2 09/33] net/ena/hal: add a new csum offload bit shaibran
2024-03-04 12:29 ` [PATCH v2 10/33] net/ena/hal: added a bus parameter to ena memcpy macro shaibran
2024-03-04 12:29 ` [PATCH v2 11/33] net/ena/hal: optimize Rx ring submission queue shaibran
2024-03-04 12:29 ` [PATCH v2 12/33] net/ena/hal: rename fields in completion descriptors shaibran
2024-03-04 12:29 ` [PATCH v2 13/33] net/ena/hal: use correct read once on u8 field shaibran
2024-03-04 12:29 ` [PATCH v2 14/33] net/ena/hal: add completion descriptor corruption check shaibran
2024-03-04 12:29 ` [PATCH v2 15/33] net/ena/hal: malformed Tx descriptor error reason shaibran
2024-03-04 12:29 ` [PATCH v2 16/33] net/ena/hal: phc feature modifications shaibran
2024-03-04 12:29 ` [PATCH v2 17/33] net/ena/hal: restructure interrupt handling shaibran
2024-03-04 12:29 ` [PATCH v2 18/33] net/ena/hal: add unlikely to error checks shaibran
2024-03-04 12:29 ` [PATCH v2 19/33] net/ena/hal: missing admin interrupt reset reason shaibran
2024-03-04 12:29 ` [PATCH v2 20/33] net/ena/hal: check for existing keep alive notification shaibran
2024-03-04 12:29 ` [PATCH v2 21/33] net/ena/hal: modify memory barrier comment shaibran
2024-03-04 12:29 ` [PATCH v2 22/33] net/ena/hal: rework Rx ring submission queue shaibran
2024-03-04 12:29 ` [PATCH v2 23/33] net/ena/hal: remove operating system type enum shaibran
2024-03-04 12:29 ` [PATCH v2 24/33] net/ena/hal: handle command abort shaibran
2024-03-04 12:29 ` [PATCH v2 25/33] net/ena/hal: add support for device reset request shaibran
2024-03-04 12:29 ` [PATCH v2 26/33] net/ena: cosmetic changes shaibran
2024-03-04 12:29 ` [PATCH v2 27/33] net/ena/hal: modify customer metrics memory management shaibran
2024-03-04 12:29 ` [PATCH v2 28/33] net/ena/hal: cosmetic changes shaibran
2024-03-04 12:29 ` [PATCH v2 29/33] net/ena: update device-preferred size of rings shaibran
2024-03-04 12:29 ` [PATCH v2 30/33] net/ena: exhaust interrupt callbacks in device close shaibran
2024-03-04 12:29 ` [PATCH v2 31/33] net/ena: support max large llq depth from the device shaibran
2024-03-04 12:29 ` [PATCH v2 32/33] net/ena: control path pure polling mode shaibran
2024-03-04 12:29 ` [PATCH v2 33/33] net/ena: upgrade driver version to 2.9.0 shaibran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240304122942.3496-5-shaibran@amazon.com \
--to=shaibran@amazon.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).