DPDK patches and discussions
 help / color / mirror / Atom feed
From: <shaibran@amazon.com>
To: <ferruh.yigit@amd.com>
Cc: <dev@dpdk.org>, Shai Brandes <shaibran@amazon.com>
Subject: [PATCH v2 08/33] net/ena/hal: exponential backoff exp limit
Date: Mon, 4 Mar 2024 14:29:17 +0200	[thread overview]
Message-ID: <20240304122942.3496-9-shaibran@amazon.com> (raw)
In-Reply-To: <20240304122942.3496-1-shaibran@amazon.com>

From: Shai Brandes <shaibran@amazon.com>

limits the exponent in the exponential backoff
mechanism in order to avoid the value overflowing.

Signed-off-by: Shai Brandes <shaibran@amazon.com>
Reviewed-by: Amit Bernstein <amitbern@amazon.com>
---
 drivers/net/ena/hal/ena_com.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ena/hal/ena_com.c b/drivers/net/ena/hal/ena_com.c
index 6953a1fa33..31c37b0ab3 100644
--- a/drivers/net/ena/hal/ena_com.c
+++ b/drivers/net/ena/hal/ena_com.c
@@ -34,6 +34,8 @@
 
 #define ENA_REGS_ADMIN_INTR_MASK 1
 
+#define ENA_MAX_BACKOFF_DELAY_EXP 16U
+
 #define ENA_MIN_ADMIN_POLL_US 100
 
 #define ENA_MAX_ADMIN_POLL_US 5000
@@ -545,8 +547,9 @@ static int ena_com_comp_status_to_errno(struct ena_com_admin_queue *admin_queue,
 
 static void ena_delay_exponential_backoff_us(u32 exp, u32 delay_us)
 {
+	exp = ENA_MIN32(ENA_MAX_BACKOFF_DELAY_EXP, exp);
 	delay_us = ENA_MAX32(ENA_MIN_ADMIN_POLL_US, delay_us);
-	delay_us = ENA_MIN32(delay_us * (1U << exp), ENA_MAX_ADMIN_POLL_US);
+	delay_us = ENA_MIN32(ENA_MAX_ADMIN_POLL_US, delay_us * (1U << exp));
 	ENA_USLEEP(delay_us);
 }
 
-- 
2.17.1


  parent reply	other threads:[~2024-03-04 12:30 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-04 12:29 [PATCH v2 00/33] net/ena: v2.9.0 driver release shaibran
2024-03-04 12:29 ` [PATCH v2 01/33] net/ena: rework the metrics multi-process functions shaibran
2024-03-04 12:29 ` [PATCH v2 02/33] net/ena: report new supported link speed capabilities shaibran
2024-03-04 12:29 ` [PATCH v2 03/33] net/ena: update imissed stat with Rx overruns shaibran
2024-03-04 12:29 ` [PATCH v2 04/33] net/ena: sub-optimal configuration notifications support shaibran
2024-03-04 12:29 ` [PATCH v2 05/33] net/ena: fix fast mbuf free shaibran
2024-03-04 12:29 ` [PATCH v2 06/33] net/ena: rename base folder to hal shaibran
2024-03-04 12:29 ` [PATCH v2 07/33] net/ena: restructure the llq policy setting process shaibran
2024-03-04 12:29 ` shaibran [this message]
2024-03-04 12:29 ` [PATCH v2 09/33] net/ena/hal: add a new csum offload bit shaibran
2024-03-04 12:29 ` [PATCH v2 10/33] net/ena/hal: added a bus parameter to ena memcpy macro shaibran
2024-03-04 12:29 ` [PATCH v2 11/33] net/ena/hal: optimize Rx ring submission queue shaibran
2024-03-04 12:29 ` [PATCH v2 12/33] net/ena/hal: rename fields in completion descriptors shaibran
2024-03-04 12:29 ` [PATCH v2 13/33] net/ena/hal: use correct read once on u8 field shaibran
2024-03-04 12:29 ` [PATCH v2 14/33] net/ena/hal: add completion descriptor corruption check shaibran
2024-03-04 12:29 ` [PATCH v2 15/33] net/ena/hal: malformed Tx descriptor error reason shaibran
2024-03-04 12:29 ` [PATCH v2 16/33] net/ena/hal: phc feature modifications shaibran
2024-03-04 12:29 ` [PATCH v2 17/33] net/ena/hal: restructure interrupt handling shaibran
2024-03-04 12:29 ` [PATCH v2 18/33] net/ena/hal: add unlikely to error checks shaibran
2024-03-04 12:29 ` [PATCH v2 19/33] net/ena/hal: missing admin interrupt reset reason shaibran
2024-03-04 12:29 ` [PATCH v2 20/33] net/ena/hal: check for existing keep alive notification shaibran
2024-03-04 12:29 ` [PATCH v2 21/33] net/ena/hal: modify memory barrier comment shaibran
2024-03-04 12:29 ` [PATCH v2 22/33] net/ena/hal: rework Rx ring submission queue shaibran
2024-03-04 12:29 ` [PATCH v2 23/33] net/ena/hal: remove operating system type enum shaibran
2024-03-04 12:29 ` [PATCH v2 24/33] net/ena/hal: handle command abort shaibran
2024-03-04 12:29 ` [PATCH v2 25/33] net/ena/hal: add support for device reset request shaibran
2024-03-04 12:29 ` [PATCH v2 26/33] net/ena: cosmetic changes shaibran
2024-03-04 12:29 ` [PATCH v2 27/33] net/ena/hal: modify customer metrics memory management shaibran
2024-03-04 12:29 ` [PATCH v2 28/33] net/ena/hal: cosmetic changes shaibran
2024-03-04 12:29 ` [PATCH v2 29/33] net/ena: update device-preferred size of rings shaibran
2024-03-04 12:29 ` [PATCH v2 30/33] net/ena: exhaust interrupt callbacks in device close shaibran
2024-03-04 12:29 ` [PATCH v2 31/33] net/ena: support max large llq depth from the device shaibran
2024-03-04 12:29 ` [PATCH v2 32/33] net/ena: control path pure polling mode shaibran
2024-03-04 12:29 ` [PATCH v2 33/33] net/ena: upgrade driver version to 2.9.0 shaibran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240304122942.3496-9-shaibran@amazon.com \
    --to=shaibran@amazon.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).