DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] config/arm: add Marvell Odyssey
@ 2024-03-05 10:17 Anoob Joseph
  2024-03-05 11:13 ` [PATCH v2] " Anoob Joseph
  0 siblings, 1 reply; 9+ messages in thread
From: Anoob Joseph @ 2024-03-05 10:17 UTC (permalink / raw)
  To: Honnappa Nagarahalli, Juraj Linkeš, thomas
  Cc: david.marchand, Jerin Jacob, nd, Pavan Nikhilesh, Ruifeng Wang,
	wathsala.vithanage, dev

Add meson build configuration for Marvell Odyssey platform with 64-bit
ARM Neoverse V2 cores.

Signed-off-by: Anoob Joseph <anoobj@marvell.com>
---

Depends-on: series-31141 ("config/arm: add Neoverse V2 part number")

 config/arm/arm64_odyssey_linux_gcc-marvell | 17 +++++++++++++++++
 config/arm/meson.build                     | 15 +++++++++++++++
 2 files changed, 32 insertions(+)
 create mode 100644 config/arm/arm64_odyssey_linux_gcc-marvell

diff --git a/config/arm/arm64_odyssey_linux_gcc-marvell b/config/arm/arm64_odyssey_linux_gcc-marvell
new file mode 100644
index 0000000000..69b5cd42d8
--- /dev/null
+++ b/config/arm/arm64_odyssey_linux_gcc-marvell
@@ -0,0 +1,17 @@
+[binaries]
+c = ['ccache', 'aarch64-marvell-linux-gnu-gcc']
+cpp = ['ccache', 'aarch64-marvell-linux-gnu-g++']
+ar = 'aarch64-marvell-linux-gnu-gcc-ar'
+strip = 'aarch64-marvell-linux-gnu-strip'
+pkgconfig = 'aarch64-linux-gnu-pkg-config'
+
+[host_machine]
+system = 'linux'
+cpu_family = 'aarch64'
+cpu = 'armv9-a'
+endian = 'little'
+
+[properties]
+platform = 'odyssey'
+
+[built-in options]
diff --git a/config/arm/meson.build b/config/arm/meson.build
index 3886d0e2dc..94159efaa4 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -500,6 +500,20 @@ soc_n2 = {
     'numa': false
 }
 
+soc_odyssey = {
+    'description' : 'Marvell Odyssey',
+    'implementer' : '0x41',
+    'flags': [
+        ['RTE_MAX_LCORE', 80],
+        ['RTE_MAX_NUMA_NODES', 1],
+        ['RTE_MEMPOOL_ALIGN', 128],
+    ],
+    'part_number': '0xd4f',
+    'extra_march_features': ['crypto'],
+    'numa': false,
+    'sve_acle': false
+}
+
 soc_cn9k = {
     'description': 'Marvell OCTEON 9',
     'implementer': '0x43',
@@ -617,6 +631,7 @@ socs = {
     'kunpeng930': soc_kunpeng930,
     'n1sdp': soc_n1sdp,
     'n2': soc_n2,
+    'odyssey' : soc_odyssey,
     'stingray': soc_stingray,
     'thunderx2': soc_thunderx2,
     'thunderxt88': soc_thunderxt88,
-- 
2.25.1


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH v2] config/arm: add Marvell Odyssey
  2024-03-05 10:17 [PATCH] config/arm: add Marvell Odyssey Anoob Joseph
@ 2024-03-05 11:13 ` Anoob Joseph
  2024-03-06  2:37   ` Ruifeng Wang
                     ` (3 more replies)
  0 siblings, 4 replies; 9+ messages in thread
From: Anoob Joseph @ 2024-03-05 11:13 UTC (permalink / raw)
  To: Honnappa Nagarahalli, Juraj Linkeš, thomas
  Cc: david.marchand, Jerin Jacob, nd, Pavan Nikhilesh, Ruifeng Wang,
	wathsala.vithanage, dev

Add meson build configuration for Marvell Odyssey platform with 64-bit
ARM Neoverse V2 cores.

Signed-off-by: Anoob Joseph <anoobj@marvell.com>
---

Depends-on: series-31141 ("config/arm: add Neoverse V2 part number")

Changes in v2:
- Renamed config file

 config/arm/arm64_odyssey_linux_gcc | 17 +++++++++++++++++
 config/arm/meson.build             | 15 +++++++++++++++
 2 files changed, 32 insertions(+)
 create mode 100644 config/arm/arm64_odyssey_linux_gcc

diff --git a/config/arm/arm64_odyssey_linux_gcc b/config/arm/arm64_odyssey_linux_gcc
new file mode 100644
index 0000000000..69b5cd42d8
--- /dev/null
+++ b/config/arm/arm64_odyssey_linux_gcc
@@ -0,0 +1,17 @@
+[binaries]
+c = ['ccache', 'aarch64-marvell-linux-gnu-gcc']
+cpp = ['ccache', 'aarch64-marvell-linux-gnu-g++']
+ar = 'aarch64-marvell-linux-gnu-gcc-ar'
+strip = 'aarch64-marvell-linux-gnu-strip'
+pkgconfig = 'aarch64-linux-gnu-pkg-config'
+
+[host_machine]
+system = 'linux'
+cpu_family = 'aarch64'
+cpu = 'armv9-a'
+endian = 'little'
+
+[properties]
+platform = 'odyssey'
+
+[built-in options]
diff --git a/config/arm/meson.build b/config/arm/meson.build
index 3886d0e2dc..94159efaa4 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -500,6 +500,20 @@ soc_n2 = {
     'numa': false
 }
 
+soc_odyssey = {
+    'description' : 'Marvell Odyssey',
+    'implementer' : '0x41',
+    'flags': [
+        ['RTE_MAX_LCORE', 80],
+        ['RTE_MAX_NUMA_NODES', 1],
+        ['RTE_MEMPOOL_ALIGN', 128],
+    ],
+    'part_number': '0xd4f',
+    'extra_march_features': ['crypto'],
+    'numa': false,
+    'sve_acle': false
+}
+
 soc_cn9k = {
     'description': 'Marvell OCTEON 9',
     'implementer': '0x43',
@@ -617,6 +631,7 @@ socs = {
     'kunpeng930': soc_kunpeng930,
     'n1sdp': soc_n1sdp,
     'n2': soc_n2,
+    'odyssey' : soc_odyssey,
     'stingray': soc_stingray,
     'thunderx2': soc_thunderx2,
     'thunderxt88': soc_thunderxt88,
-- 
2.25.1


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2] config/arm: add Marvell Odyssey
  2024-03-05 11:13 ` [PATCH v2] " Anoob Joseph
@ 2024-03-06  2:37   ` Ruifeng Wang
  2024-03-06  3:19   ` Honnappa Nagarahalli
                     ` (2 subsequent siblings)
  3 siblings, 0 replies; 9+ messages in thread
From: Ruifeng Wang @ 2024-03-06  2:37 UTC (permalink / raw)
  To: Anoob Joseph, Honnappa Nagarahalli, Juraj Linkeš, thomas
  Cc: david.marchand, Jerin Jacob, nd, Pavan Nikhilesh,
	wathsala.vithanage, dev



On 2024/3/5 7:13 PM, Anoob Joseph wrote:
> Add meson build configuration for Marvell Odyssey platform with 64-bit
> ARM Neoverse V2 cores.
> 
> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> ---
> 
> Depends-on: series-31141 ("config/arm: add Neoverse V2 part number")
> 
> Changes in v2:
> - Renamed config file
> 
>   config/arm/arm64_odyssey_linux_gcc | 17 +++++++++++++++++
>   config/arm/meson.build             | 15 +++++++++++++++
>   2 files changed, 32 insertions(+)
>   create mode 100644 config/arm/arm64_odyssey_linux_gcc
> 
> diff --git a/config/arm/arm64_odyssey_linux_gcc b/config/arm/arm64_odyssey_linux_gcc
> new file mode 100644
> index 0000000000..69b5cd42d8
> --- /dev/null
> +++ b/config/arm/arm64_odyssey_linux_gcc
> @@ -0,0 +1,17 @@
> +[binaries]
> +c = ['ccache', 'aarch64-marvell-linux-gnu-gcc']
> +cpp = ['ccache', 'aarch64-marvell-linux-gnu-g++']
> +ar = 'aarch64-marvell-linux-gnu-gcc-ar'
> +strip = 'aarch64-marvell-linux-gnu-strip'
> +pkgconfig = 'aarch64-linux-gnu-pkg-config'
> +
> +[host_machine]
> +system = 'linux'
> +cpu_family = 'aarch64'
> +cpu = 'armv9-a'
> +endian = 'little'
> +
> +[properties]
> +platform = 'odyssey'
> +
> +[built-in options]
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index 3886d0e2dc..94159efaa4 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -500,6 +500,20 @@ soc_n2 = {
>       'numa': false
>   }
>   
> +soc_odyssey = {
> +    'description' : 'Marvell Odyssey',
> +    'implementer' : '0x41',
> +    'flags': [
> +        ['RTE_MAX_LCORE', 80],
> +        ['RTE_MAX_NUMA_NODES', 1],
> +        ['RTE_MEMPOOL_ALIGN', 128],
> +    ],
> +    'part_number': '0xd4f',
> +    'extra_march_features': ['crypto'],
> +    'numa': false,
> +    'sve_acle': false
> +}
> +
>   soc_cn9k = {
>       'description': 'Marvell OCTEON 9',
>       'implementer': '0x43',
> @@ -617,6 +631,7 @@ socs = {
>       'kunpeng930': soc_kunpeng930,
>       'n1sdp': soc_n1sdp,
>       'n2': soc_n2,
> +    'odyssey' : soc_odyssey,

The SoC string list above also needs update. It is for documentation.
With the change:
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>

>       'stingray': soc_stingray,
>       'thunderx2': soc_thunderx2,
>       'thunderxt88': soc_thunderxt88,

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2] config/arm: add Marvell Odyssey
  2024-03-05 11:13 ` [PATCH v2] " Anoob Joseph
  2024-03-06  2:37   ` Ruifeng Wang
@ 2024-03-06  3:19   ` Honnappa Nagarahalli
  2024-03-06  4:41     ` Anoob Joseph
  2024-03-06  5:03   ` Honnappa Nagarahalli
  2024-03-06  5:50   ` [PATCH v3] " Anoob Joseph
  3 siblings, 1 reply; 9+ messages in thread
From: Honnappa Nagarahalli @ 2024-03-06  3:19 UTC (permalink / raw)
  To: Anoob Joseph
  Cc: Juraj Linkeš,
	thomas, David Marchand, jerinj, nd, Pavan Nikhilesh,
	Ruifeng Wang, Wathsala Wathawana Vithanage, dev



> On Mar 5, 2024, at 5:13 AM, Anoob Joseph <anoobj@marvell.com> wrote:
> 
> Add meson build configuration for Marvell Odyssey platform with 64-bit
> ARM Neoverse V2 cores.
> 
> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> ---
> 
> Depends-on: series-31141 ("config/arm: add Neoverse V2 part number")
> 
> Changes in v2:
> - Renamed config file
> 
> config/arm/arm64_odyssey_linux_gcc | 17 +++++++++++++++++
> config/arm/meson.build             | 15 +++++++++++++++
> 2 files changed, 32 insertions(+)
> create mode 100644 config/arm/arm64_odyssey_linux_gcc
> 
> diff --git a/config/arm/arm64_odyssey_linux_gcc b/config/arm/arm64_odyssey_linux_gcc
> new file mode 100644
> index 0000000000..69b5cd42d8
> --- /dev/null
> +++ b/config/arm/arm64_odyssey_linux_gcc
> @@ -0,0 +1,17 @@
> +[binaries]
> +c = ['ccache', 'aarch64-marvell-linux-gnu-gcc']
> +cpp = ['ccache', 'aarch64-marvell-linux-gnu-g++']
> +ar = 'aarch64-marvell-linux-gnu-gcc-ar'
> +strip = 'aarch64-marvell-linux-gnu-strip'
> +pkgconfig = 'aarch64-linux-gnu-pkg-config'
> +
> +[host_machine]
> +system = 'linux'
> +cpu_family = 'aarch64'
> +cpu = 'armv9-a'
> +endian = 'little'
> +
> +[properties]
> +platform = 'odyssey'
> +
> +[built-in options]

Just thinking out loud, given that this is a 80 core V2 machine, do we need cross compilation support? I have the same question for Grace machine as well. I am thinking we should have cross compilation support only for embedded platforms.


> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index 3886d0e2dc..94159efaa4 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -500,6 +500,20 @@ soc_n2 = {
>     'numa': false
> }
> 
> +soc_odyssey = {
> +    'description' : 'Marvell Odyssey',
> +    'implementer' : '0x41',
> +    'flags': [
> +        ['RTE_MAX_LCORE', 80],
> +        ['RTE_MAX_NUMA_NODES', 1],
> +        ['RTE_MEMPOOL_ALIGN', 128],
> +    ],
> +    'part_number': '0xd4f',
> +    'extra_march_features': ['crypto'],
> +    'numa': false,
> +    'sve_acle': false
> +}
> +
Can you move it such that it is sorted alphabetically?

> soc_cn9k = {
>     'description': 'Marvell OCTEON 9',
>     'implementer': '0x43',
> @@ -617,6 +631,7 @@ socs = {
>     'kunpeng930': soc_kunpeng930,
>     'n1sdp': soc_n1sdp,
>     'n2': soc_n2,
> +    'odyssey' : soc_odyssey,
>     'stingray': soc_stingray,
>     'thunderx2': soc_thunderx2,
>     'thunderxt88': soc_thunderxt88,
> -- 
> 2.25.1
> 


^ permalink raw reply	[flat|nested] 9+ messages in thread

* RE: [PATCH v2] config/arm: add Marvell Odyssey
  2024-03-06  3:19   ` Honnappa Nagarahalli
@ 2024-03-06  4:41     ` Anoob Joseph
  2024-03-06  5:00       ` Honnappa Nagarahalli
  0 siblings, 1 reply; 9+ messages in thread
From: Anoob Joseph @ 2024-03-06  4:41 UTC (permalink / raw)
  To: Honnappa Nagarahalli
  Cc: Juraj Linkeš,
	thomas, David Marchand, Jerin Jacob, nd,
	Pavan Nikhilesh Bhagavatula, Ruifeng Wang,
	Wathsala Wathawana Vithanage, dev

Hi Honnappa,

Thanks for the review. Please see inline.

Thanks,
Anoob

> -----Original Message-----
> From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
> Sent: Wednesday, March 6, 2024 8:50 AM
> To: Anoob Joseph <anoobj@marvell.com>
> Cc: Juraj Linkeš <juraj.linkes@pantheon.tech>; thomas@monjalon.net; David
> Marchand <david.marchand@redhat.com>; Jerin Jacob <jerinj@marvell.com>; nd
> <nd@arm.com>; Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>;
> Ruifeng Wang <Ruifeng.Wang@arm.com>; Wathsala Wathawana Vithanage
> <wathsala.vithanage@arm.com>; dev@dpdk.org
> Subject: [EXTERNAL] Re: [PATCH v2] config/arm: add Marvell Odyssey
> 
> Prioritize security for external emails: Confirm sender and content safety before
> clicking links or opening attachments
> 
> ----------------------------------------------------------------------
> 
> 
> > On Mar 5, 2024, at 5:13 AM, Anoob Joseph <anoobj@marvell.com> wrote:
> >
> > Add meson build configuration for Marvell Odyssey platform with 64-bit
> > ARM Neoverse V2 cores.
> >
> > Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> > ---
> >
> > Depends-on: series-31141 ("config/arm: add Neoverse V2 part number")
> >
> > Changes in v2:
> > - Renamed config file
> >
> > config/arm/arm64_odyssey_linux_gcc | 17 +++++++++++++++++
> > config/arm/meson.build             | 15 +++++++++++++++
> > 2 files changed, 32 insertions(+)
> > create mode 100644 config/arm/arm64_odyssey_linux_gcc
> >
> > diff --git a/config/arm/arm64_odyssey_linux_gcc
> > b/config/arm/arm64_odyssey_linux_gcc
> > new file mode 100644
> > index 0000000000..69b5cd42d8
> > --- /dev/null
> > +++ b/config/arm/arm64_odyssey_linux_gcc
> > @@ -0,0 +1,17 @@
> > +[binaries]
> > +c = ['ccache', 'aarch64-marvell-linux-gnu-gcc'] cpp = ['ccache',
> > +'aarch64-marvell-linux-gnu-g++'] ar =
> > +'aarch64-marvell-linux-gnu-gcc-ar'
> > +strip = 'aarch64-marvell-linux-gnu-strip'
> > +pkgconfig = 'aarch64-linux-gnu-pkg-config'
> > +
> > +[host_machine]
> > +system = 'linux'
> > +cpu_family = 'aarch64'
> > +cpu = 'armv9-a'
> > +endian = 'little'
> > +
> > +[properties]
> > +platform = 'odyssey'
> > +
> > +[built-in options]
> 
> Just thinking out loud, given that this is a 80 core V2 machine, do we need cross
> compilation support? I have the same question for Grace machine as well. I am
> thinking we should have cross compilation support only for embedded platforms.

[Anoob] DPDK binaries may not be built natively in all cases. When there are standard release packages with pre-built binaries, it would help in having cross compilation. 

> 
> 
> > diff --git a/config/arm/meson.build b/config/arm/meson.build index
> > 3886d0e2dc..94159efaa4 100644
> > --- a/config/arm/meson.build
> > +++ b/config/arm/meson.build
> > @@ -500,6 +500,20 @@ soc_n2 = {
> >     'numa': false
> > }
> >
> > +soc_odyssey = {
> > +    'description' : 'Marvell Odyssey',
> > +    'implementer' : '0x41',
> > +    'flags': [
> > +        ['RTE_MAX_LCORE', 80],
> > +        ['RTE_MAX_NUMA_NODES', 1],
> > +        ['RTE_MEMPOOL_ALIGN', 128],
> > +    ],
> > +    'part_number': '0xd4f',
> > +    'extra_march_features': ['crypto'],
> > +    'numa': false,
> > +    'sve_acle': false
> > +}
> > +
> Can you move it such that it is sorted alphabetically?

[Anoob] soc_cn9k portion is not following alphabetical order. I think it is so because of the renaming from soc_octeontx2 to soc_cn9k. I can push a separate patch to have this addressed. New addition in this patch is following alphabetical order. soc_odyssey is added between n2 & stingray.

> 
> > soc_cn9k = {
> >     'description': 'Marvell OCTEON 9',
> >     'implementer': '0x43',
> > @@ -617,6 +631,7 @@ socs = {
> >     'kunpeng930': soc_kunpeng930,
> >     'n1sdp': soc_n1sdp,
> >     'n2': soc_n2,
> > +    'odyssey' : soc_odyssey,
> >     'stingray': soc_stingray,
> >     'thunderx2': soc_thunderx2,
> >     'thunderxt88': soc_thunderxt88,
> > --
> > 2.25.1
> >


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2] config/arm: add Marvell Odyssey
  2024-03-06  4:41     ` Anoob Joseph
@ 2024-03-06  5:00       ` Honnappa Nagarahalli
  0 siblings, 0 replies; 9+ messages in thread
From: Honnappa Nagarahalli @ 2024-03-06  5:00 UTC (permalink / raw)
  To: Anoob Joseph
  Cc: Juraj Linkeš,
	thomas, David Marchand, jerinj, nd, Pavan Nikhilesh Bhagavatula,
	Ruifeng Wang, Wathsala Wathawana Vithanage, dev



> On Mar 5, 2024, at 10:41 PM, Anoob Joseph <anoobj@marvell.com> wrote:
> 
> Hi Honnappa,
> 
> Thanks for the review. Please see inline.
> 
> Thanks,
> Anoob
> 
>> -----Original Message-----
>> From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
>> Sent: Wednesday, March 6, 2024 8:50 AM
>> To: Anoob Joseph <anoobj@marvell.com>
>> Cc: Juraj Linkeš <juraj.linkes@pantheon.tech>; thomas@monjalon.net; David
>> Marchand <david.marchand@redhat.com>; Jerin Jacob <jerinj@marvell.com>; nd
>> <nd@arm.com>; Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>;
>> Ruifeng Wang <Ruifeng.Wang@arm.com>; Wathsala Wathawana Vithanage
>> <wathsala.vithanage@arm.com>; dev@dpdk.org
>> Subject: [EXTERNAL] Re: [PATCH v2] config/arm: add Marvell Odyssey
>> 
>> Prioritize security for external emails: Confirm sender and content safety before
>> clicking links or opening attachments
>> 
>> ----------------------------------------------------------------------
>> 
>> 
>>> On Mar 5, 2024, at 5:13 AM, Anoob Joseph <anoobj@marvell.com> wrote:
>>> 
>>> Add meson build configuration for Marvell Odyssey platform with 64-bit
>>> ARM Neoverse V2 cores.
>>> 
>>> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
>>> ---
>>> 
>>> Depends-on: series-31141 ("config/arm: add Neoverse V2 part number")
>>> 
>>> Changes in v2:
>>> - Renamed config file
>>> 
>>> config/arm/arm64_odyssey_linux_gcc | 17 +++++++++++++++++
>>> config/arm/meson.build             | 15 +++++++++++++++
>>> 2 files changed, 32 insertions(+)
>>> create mode 100644 config/arm/arm64_odyssey_linux_gcc
>>> 
>>> diff --git a/config/arm/arm64_odyssey_linux_gcc
>>> b/config/arm/arm64_odyssey_linux_gcc
>>> new file mode 100644
>>> index 0000000000..69b5cd42d8
>>> --- /dev/null
>>> +++ b/config/arm/arm64_odyssey_linux_gcc
>>> @@ -0,0 +1,17 @@
>>> +[binaries]
>>> +c = ['ccache', 'aarch64-marvell-linux-gnu-gcc'] cpp = ['ccache',
>>> +'aarch64-marvell-linux-gnu-g++'] ar =
>>> +'aarch64-marvell-linux-gnu-gcc-ar'
>>> +strip = 'aarch64-marvell-linux-gnu-strip'
>>> +pkgconfig = 'aarch64-linux-gnu-pkg-config'
>>> +
>>> +[host_machine]
>>> +system = 'linux'
>>> +cpu_family = 'aarch64'
>>> +cpu = 'armv9-a'
>>> +endian = 'little'
>>> +
>>> +[properties]
>>> +platform = 'odyssey'
>>> +
>>> +[built-in options]
>> 
>> Just thinking out loud, given that this is a 80 core V2 machine, do we need cross
>> compilation support? I have the same question for Grace machine as well. I am
>> thinking we should have cross compilation support only for embedded platforms.
> 
> [Anoob] DPDK binaries may not be built natively in all cases. When there are standard release packages with pre-built binaries, it would help in having cross compilation.
Ack

> 
>> 
>> 
>>> diff --git a/config/arm/meson.build b/config/arm/meson.build index
>>> 3886d0e2dc..94159efaa4 100644
>>> --- a/config/arm/meson.build
>>> +++ b/config/arm/meson.build
>>> @@ -500,6 +500,20 @@ soc_n2 = {
>>>    'numa': false
>>> }
>>> 
>>> +soc_odyssey = {
>>> +    'description' : 'Marvell Odyssey',
>>> +    'implementer' : '0x41',
>>> +    'flags': [
>>> +        ['RTE_MAX_LCORE', 80],
>>> +        ['RTE_MAX_NUMA_NODES', 1],
>>> +        ['RTE_MEMPOOL_ALIGN', 128],
>>> +    ],
>>> +    'part_number': '0xd4f',
>>> +    'extra_march_features': ['crypto'],
>>> +    'numa': false,
>>> +    'sve_acle': false
>>> +}
>>> +
>> Can you move it such that it is sorted alphabetically?
> 
> [Anoob] soc_cn9k portion is not following alphabetical order. I think it is so because of the renaming from soc_octeontx2 to soc_cn9k. I can push a separate patch to have this addressed. New addition in this patch is following alphabetical order. soc_odyssey is added between n2 & stingray.
Yes, please push a separate patch for cn9k.

> 
>> 
>>> soc_cn9k = {
>>>    'description': 'Marvell OCTEON 9',
>>>    'implementer': '0x43',
>>> @@ -617,6 +631,7 @@ socs = {
>>>    'kunpeng930': soc_kunpeng930,
>>>    'n1sdp': soc_n1sdp,
>>>    'n2': soc_n2,
>>> +    'odyssey' : soc_odyssey,
>>>    'stingray': soc_stingray,
>>>    'thunderx2': soc_thunderx2,
>>>    'thunderxt88': soc_thunderxt88,
>>> --
>>> 2.25.1
>>> 
> 


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2] config/arm: add Marvell Odyssey
  2024-03-05 11:13 ` [PATCH v2] " Anoob Joseph
  2024-03-06  2:37   ` Ruifeng Wang
  2024-03-06  3:19   ` Honnappa Nagarahalli
@ 2024-03-06  5:03   ` Honnappa Nagarahalli
  2024-03-06  5:50   ` [PATCH v3] " Anoob Joseph
  3 siblings, 0 replies; 9+ messages in thread
From: Honnappa Nagarahalli @ 2024-03-06  5:03 UTC (permalink / raw)
  To: Anoob Joseph
  Cc: Juraj Linkeš,
	thomas, David Marchand, jerinj, nd, Pavan Nikhilesh,
	Ruifeng Wang, Wathsala Wathawana Vithanage, dev



> On Mar 5, 2024, at 5:13 AM, Anoob Joseph <anoobj@marvell.com> wrote:
> 
> Add meson build configuration for Marvell Odyssey platform with 64-bit
> ARM Neoverse V2 cores.
> 
> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

> ---
> 
> Depends-on: series-31141 ("config/arm: add Neoverse V2 part number")
> 
> Changes in v2:
> - Renamed config file
> 
> config/arm/arm64_odyssey_linux_gcc | 17 +++++++++++++++++
> config/arm/meson.build             | 15 +++++++++++++++
> 2 files changed, 32 insertions(+)
> create mode 100644 config/arm/arm64_odyssey_linux_gcc
> 
> diff --git a/config/arm/arm64_odyssey_linux_gcc b/config/arm/arm64_odyssey_linux_gcc
> new file mode 100644
> index 0000000000..69b5cd42d8
> --- /dev/null
> +++ b/config/arm/arm64_odyssey_linux_gcc
> @@ -0,0 +1,17 @@
> +[binaries]
> +c = ['ccache', 'aarch64-marvell-linux-gnu-gcc']
> +cpp = ['ccache', 'aarch64-marvell-linux-gnu-g++']
> +ar = 'aarch64-marvell-linux-gnu-gcc-ar'
> +strip = 'aarch64-marvell-linux-gnu-strip'
> +pkgconfig = 'aarch64-linux-gnu-pkg-config'
> +
> +[host_machine]
> +system = 'linux'
> +cpu_family = 'aarch64'
> +cpu = 'armv9-a'
> +endian = 'little'
> +
> +[properties]
> +platform = 'odyssey'
> +
> +[built-in options]
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index 3886d0e2dc..94159efaa4 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -500,6 +500,20 @@ soc_n2 = {
>     'numa': false
> }
> 
> +soc_odyssey = {
> +    'description' : 'Marvell Odyssey',
> +    'implementer' : '0x41',
> +    'flags': [
> +        ['RTE_MAX_LCORE', 80],
> +        ['RTE_MAX_NUMA_NODES', 1],
> +        ['RTE_MEMPOOL_ALIGN', 128],
> +    ],
> +    'part_number': '0xd4f',
> +    'extra_march_features': ['crypto'],
> +    'numa': false,
> +    'sve_acle': false
> +}
> +
> soc_cn9k = {
>     'description': 'Marvell OCTEON 9',
>     'implementer': '0x43',
> @@ -617,6 +631,7 @@ socs = {
>     'kunpeng930': soc_kunpeng930,
>     'n1sdp': soc_n1sdp,
>     'n2': soc_n2,
> +    'odyssey' : soc_odyssey,
>     'stingray': soc_stingray,
>     'thunderx2': soc_thunderx2,
>     'thunderxt88': soc_thunderxt88,
> -- 
> 2.25.1
> 


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH v3] config/arm: add Marvell Odyssey
  2024-03-05 11:13 ` [PATCH v2] " Anoob Joseph
                     ` (2 preceding siblings ...)
  2024-03-06  5:03   ` Honnappa Nagarahalli
@ 2024-03-06  5:50   ` Anoob Joseph
  2024-03-06 15:42     ` Thomas Monjalon
  3 siblings, 1 reply; 9+ messages in thread
From: Anoob Joseph @ 2024-03-06  5:50 UTC (permalink / raw)
  To: Honnappa Nagarahalli, Juraj Linkeš, thomas
  Cc: david.marchand, Jerin Jacob, nd, Pavan Nikhilesh, Ruifeng Wang,
	wathsala.vithanage, dev

Add meson build configuration for Marvell Odyssey platform with 64-bit
ARM Neoverse V2 cores.

Signed-off-by: Anoob Joseph <anoobj@marvell.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---

Depends-on: series-31141 ("config/arm: add Neoverse V2 part number")

Changes in v3:
- Added string for Odyssey
- Minor shuffling of fields to make it similar to other entries

Changes in v2:
- Renamed config file

 config/arm/arm64_odyssey_linux_gcc | 17 +++++++++++++++++
 config/arm/meson.build             | 15 +++++++++++++++
 2 files changed, 32 insertions(+)
 create mode 100644 config/arm/arm64_odyssey_linux_gcc

diff --git a/config/arm/arm64_odyssey_linux_gcc b/config/arm/arm64_odyssey_linux_gcc
new file mode 100644
index 0000000000..69b5cd42d8
--- /dev/null
+++ b/config/arm/arm64_odyssey_linux_gcc
@@ -0,0 +1,17 @@
+[binaries]
+c = ['ccache', 'aarch64-marvell-linux-gnu-gcc']
+cpp = ['ccache', 'aarch64-marvell-linux-gnu-g++']
+ar = 'aarch64-marvell-linux-gnu-gcc-ar'
+strip = 'aarch64-marvell-linux-gnu-strip'
+pkgconfig = 'aarch64-linux-gnu-pkg-config'
+
+[host_machine]
+system = 'linux'
+cpu_family = 'aarch64'
+cpu = 'armv9-a'
+endian = 'little'
+
+[properties]
+platform = 'odyssey'
+
+[built-in options]
diff --git a/config/arm/meson.build b/config/arm/meson.build
index 3886d0e2dc..f6c9a41a88 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -500,6 +500,19 @@ soc_n2 = {
     'numa': false
 }
 
+soc_odyssey = {
+    'description': 'Marvell Odyssey',
+    'implementer': '0x41',
+    'part_number': '0xd4f',
+    'extra_march_features': ['crypto'],
+    'numa': false,
+    'flags': [
+        ['RTE_MAX_LCORE', 80],
+        ['RTE_MAX_NUMA_NODES', 1],
+        ['RTE_MEMPOOL_ALIGN', 128],
+    ],
+}
+
 soc_cn9k = {
     'description': 'Marvell OCTEON 9',
     'implementer': '0x43',
@@ -583,6 +596,7 @@ kunpeng920:      HiSilicon Kunpeng 920
 kunpeng930:      HiSilicon Kunpeng 930
 n1sdp:           Arm Neoverse N1SDP
 n2:              Arm Neoverse N2
+odyssey:         Marvell Odyssey
 stingray:        Broadcom Stingray
 thunderx2:       Marvell ThunderX2 T99
 thunderxt88:     Marvell ThunderX T88
@@ -617,6 +631,7 @@ socs = {
     'kunpeng930': soc_kunpeng930,
     'n1sdp': soc_n1sdp,
     'n2': soc_n2,
+    'odyssey' : soc_odyssey,
     'stingray': soc_stingray,
     'thunderx2': soc_thunderx2,
     'thunderxt88': soc_thunderxt88,
-- 
2.25.1


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v3] config/arm: add Marvell Odyssey
  2024-03-06  5:50   ` [PATCH v3] " Anoob Joseph
@ 2024-03-06 15:42     ` Thomas Monjalon
  0 siblings, 0 replies; 9+ messages in thread
From: Thomas Monjalon @ 2024-03-06 15:42 UTC (permalink / raw)
  To: Anoob Joseph
  Cc: Honnappa Nagarahalli, Juraj Linkeš,
	dev, david.marchand, Jerin Jacob, nd, Pavan Nikhilesh,
	Ruifeng Wang, wathsala.vithanage, dev

06/03/2024 06:50, Anoob Joseph:
> --- /dev/null
> +++ b/config/arm/arm64_odyssey_linux_gcc
> @@ -0,0 +1,17 @@
> +[binaries]
> +c = ['ccache', 'aarch64-marvell-linux-gnu-gcc']
> +cpp = ['ccache', 'aarch64-marvell-linux-gnu-g++']
> +ar = 'aarch64-marvell-linux-gnu-gcc-ar'
> +strip = 'aarch64-marvell-linux-gnu-strip'
> +pkgconfig = 'aarch64-linux-gnu-pkg-config'
> +
> +[host_machine]
> +system = 'linux'
> +cpu_family = 'aarch64'
> +cpu = 'armv9-a'
> +endian = 'little'
> +
> +[properties]
> +platform = 'odyssey'
> +
> +[built-in options]

This section is empty and has never been used in the past,
so I suppose I can remove it.

> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> +soc_odyssey = {
> +    'description': 'Marvell Odyssey',
> +    'implementer': '0x41',
> +    'part_number': '0xd4f',
> +    'extra_march_features': ['crypto'],
> +    'numa': false,
> +    'flags': [
> +        ['RTE_MAX_LCORE', 80],
> +        ['RTE_MAX_NUMA_NODES', 1],
> +        ['RTE_MEMPOOL_ALIGN', 128],
> +    ],
> +}

Applied, thanks.



^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2024-03-06 15:42 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-05 10:17 [PATCH] config/arm: add Marvell Odyssey Anoob Joseph
2024-03-05 11:13 ` [PATCH v2] " Anoob Joseph
2024-03-06  2:37   ` Ruifeng Wang
2024-03-06  3:19   ` Honnappa Nagarahalli
2024-03-06  4:41     ` Anoob Joseph
2024-03-06  5:00       ` Honnappa Nagarahalli
2024-03-06  5:03   ` Honnappa Nagarahalli
2024-03-06  5:50   ` [PATCH v3] " Anoob Joseph
2024-03-06 15:42     ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).