From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1489A43C5D; Wed, 6 Mar 2024 22:22:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B59F940276; Wed, 6 Mar 2024 22:22:36 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id B85F2400EF for <dev@dpdk.org>; Wed, 6 Mar 2024 22:22:35 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 17D3C20B74C0; Wed, 6 Mar 2024 13:22:35 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 17D3C20B74C0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1709760155; bh=2EGOrPv2dkLV6oOImuwxcI/7Q9DYOBdnJx2k4LoqlSM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UCv10b0xBGN+aYWNGBZzkdVHDlqT43x5cfC9OnciNJCs/2JJdcdvaeLmO6XkLMG97 fkAH6utgna3BdkVvC/OTsBnbnDxIVjhsJhqjND1A8V36bHZEml9HNwWAAdGJdY2fZ5 /tWBCk3UotVQZOondKWtPZ50Q8xKihsBvDeBpBl4= Date: Wed, 6 Mar 2024 13:22:35 -0800 From: Tyler Retzlaff <roretzla@linux.microsoft.com> To: David Marchand <david.marchand@redhat.com> Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>, Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>, Vladimir Medvedkin <vladimir.medvedkin@intel.com>, mb@smartsharesystems.com Subject: Re: [PATCH v2 0/3] use rte macros instead of GCC __attribute Message-ID: <20240306212235.GA1082@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1709075273-6885-1-git-send-email-roretzla@linux.microsoft.com> <1709146076-22254-1-git-send-email-roretzla@linux.microsoft.com> <CAJFAV8wF9zJ6sN024=eXJ5LMD9hV-y6TH7ur5XVF6+5a1M9L6w@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <CAJFAV8wF9zJ6sN024=eXJ5LMD9hV-y6TH7ur5XVF6+5a1M9L6w@mail.gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Wed, Mar 06, 2024 at 09:49:31PM +0100, David Marchand wrote: > On Wed, Feb 28, 2024 at 7:48 PM Tyler Retzlaff > <roretzla@linux.microsoft.com> wrote: > > > > Clean up direct uses of GCC __attribute__ in libs outside of EAL. A > > checkpatch check already warns for new additions. > > > > v2: > > * fix typo __rte_pure -> __rte_may_alias in rcu commit message > > > > Tyler Retzlaff (3): > > eal: add rte pure attribute macro > > lpm: use rte macro instead of GCC attribute > > rcu: use rte macro instead of GCC attribute > > > > lib/eal/include/rte_common.h | 9 +++++++++ > > lib/lpm/rte_lpm.c | 4 ++-- > > lib/lpm/rte_lpm6.c | 2 +- > > lib/rcu/rcu_qsbr_pvt.h | 2 +- > > 4 files changed, 13 insertions(+), 4 deletions(-) > > Introducing __rte_pure and converting lib/lpm looks fine. > But please finish the job for the other occurence in the tree as it is > a mechanical change. Sure, it's trivial that I don't have to burn it in on lib first. Will submit an updated rev. > > Thanks. > > -- > David Marchand