DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thierry Herbelot <thierry.herbelot@6wind.com>
To: dev@dpdk.org
Cc: Thierry Herbelot <thierry.herbelot@6wind.com>,
	Thomas Monjalon <thomas@monjalon.net>,
	Harman Kalra <hkalra@marvell.com>,
	Ferruh Yigit <ferruh.yigit@amd.com>,
	Olivier Matz <olivier.matz@6wind.com>
Subject: [V4] ethdev: restore eth_da init at startup of rte_eth_devargs_parse()
Date: Mon, 11 Mar 2024 13:55:18 +0100	[thread overview]
Message-ID: <20240311125518.2714496-1-thierry.herbelot@6wind.com> (raw)
In-Reply-To: <20240311115722.2708497-1-thierry.herbelot@6wind.com>

Commit 9a9eb104edf6 ("ethdev: parse multiple representor devargs") removes
the following variable initialization in rte_eth_devargs_parse():

    memset(eth_da, 0, sizeof(*eth_da));

Restore the memset, as this causes regression in ixgbe PCI probe.

As the listed commit introduces a new argument: nb_da, the memset
takes it into account.

Fixes: 9a9eb104edf6 ("ethdev: parse multiple representor devargs")
Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
V4: use nb_da to define the size of the memset
V3: fix variable name
V2: fix git hash length

 lib/ethdev/ethdev_driver.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/ethdev/ethdev_driver.c b/lib/ethdev/ethdev_driver.c
index 1660dd3f2a46..f48c0eb8bc5a 100644
--- a/lib/ethdev/ethdev_driver.c
+++ b/lib/ethdev/ethdev_driver.c
@@ -617,6 +617,8 @@ rte_eth_devargs_parse(const char *dargs, struct rte_eth_devargs *eth_devargs,
 	unsigned int i;
 	int result = 0;
 
+	memset(eth_devargs, 0, nb_da * sizeof(*eth_devargs));
+
 	result = eth_dev_devargs_tokenise(&args, dargs);
 	if (result < 0)
 		goto parse_cleanup;
-- 
2.39.2


  reply	other threads:[~2024-03-11 12:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-11 11:44 [PATCH] " Thierry Herbelot
2024-03-11 11:51 ` [V2] " Thierry Herbelot
2024-03-11 11:57   ` [V3] ethdev: restore eth_devargs " Thierry Herbelot
2024-03-11 12:55     ` Thierry Herbelot [this message]
2024-03-11 14:56       ` [V4] ethdev: restore eth_da " Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240311125518.2714496-1-thierry.herbelot@6wind.com \
    --to=thierry.herbelot@6wind.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=hkalra@marvell.com \
    --cc=olivier.matz@6wind.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).