From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH] windows: install sched.h header
Date: Tue, 12 Mar 2024 10:55:53 -0700 [thread overview]
Message-ID: <20240312175553.GA15867@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <1930676.GKX7oQKdZx@thomas>
On Tue, Jan 30, 2024 at 05:52:54PM +0100, Thomas Monjalon wrote:
> 20/12/2023 10:11, Bruce Richardson:
> > On Tue, Dec 19, 2023 at 12:17:37PM -0800, Tyler Retzlaff wrote:
> > > rte_os.h includes sched.h so install sched.h to allow DPDK installed to
> > > DESTDIR to be usable.
>
> Why other files don't need to be exported as well?
after reviewing all other files it was found that only sched.h is being
included by an installed / public header. all other headers in
windows/include are used internally only.
>
> > > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > > ---
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>
> That's a fix which may need to be backported.
found the commit that added sched.h and added a Fixes tag.
thanks!
next prev parent reply other threads:[~2024-03-12 17:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 20:17 Tyler Retzlaff
2023-12-20 9:11 ` Bruce Richardson
2024-01-30 16:52 ` Thomas Monjalon
2024-03-12 17:55 ` Tyler Retzlaff [this message]
2024-03-12 17:54 ` [PATCH v2] " Tyler Retzlaff
2024-05-29 13:25 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240312175553.GA15867@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=roretzla@linux.microsoft.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).