* [PATCH] windows: install sched.h header
@ 2023-12-19 20:17 Tyler Retzlaff
2023-12-20 9:11 ` Bruce Richardson
2024-03-12 17:54 ` [PATCH v2] " Tyler Retzlaff
0 siblings, 2 replies; 6+ messages in thread
From: Tyler Retzlaff @ 2023-12-19 20:17 UTC (permalink / raw)
To: dev; +Cc: Tyler Retzlaff
rte_os.h includes sched.h so install sched.h to allow DPDK installed to
DESTDIR to be usable.
Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
---
lib/eal/windows/include/meson.build | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/eal/windows/include/meson.build b/lib/eal/windows/include/meson.build
index 5fb1962..e985a77 100644
--- a/lib/eal/windows/include/meson.build
+++ b/lib/eal/windows/include/meson.build
@@ -6,4 +6,5 @@ includes += include_directories('.')
headers += files(
'rte_os.h',
'rte_windows.h',
+ 'sched.h',
)
--
1.8.3.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] windows: install sched.h header
2023-12-19 20:17 [PATCH] windows: install sched.h header Tyler Retzlaff
@ 2023-12-20 9:11 ` Bruce Richardson
2024-01-30 16:52 ` Thomas Monjalon
2024-03-12 17:54 ` [PATCH v2] " Tyler Retzlaff
1 sibling, 1 reply; 6+ messages in thread
From: Bruce Richardson @ 2023-12-20 9:11 UTC (permalink / raw)
To: Tyler Retzlaff; +Cc: dev
On Tue, Dec 19, 2023 at 12:17:37PM -0800, Tyler Retzlaff wrote:
> rte_os.h includes sched.h so install sched.h to allow DPDK installed to
> DESTDIR to be usable.
>
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] windows: install sched.h header
2023-12-20 9:11 ` Bruce Richardson
@ 2024-01-30 16:52 ` Thomas Monjalon
2024-03-12 17:55 ` Tyler Retzlaff
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2024-01-30 16:52 UTC (permalink / raw)
To: Tyler Retzlaff; +Cc: dev, Bruce Richardson
20/12/2023 10:11, Bruce Richardson:
> On Tue, Dec 19, 2023 at 12:17:37PM -0800, Tyler Retzlaff wrote:
> > rte_os.h includes sched.h so install sched.h to allow DPDK installed to
> > DESTDIR to be usable.
Why other files don't need to be exported as well?
> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > ---
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
That's a fix which may need to be backported.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] windows: install sched.h header
2023-12-19 20:17 [PATCH] windows: install sched.h header Tyler Retzlaff
2023-12-20 9:11 ` Bruce Richardson
@ 2024-03-12 17:54 ` Tyler Retzlaff
2024-05-29 13:25 ` Thomas Monjalon
1 sibling, 1 reply; 6+ messages in thread
From: Tyler Retzlaff @ 2024-03-12 17:54 UTC (permalink / raw)
To: dev
Cc: Bruce Richardson, Dmitry Kozlyuk, Pallavi Kadam, Ranjit Menon,
Tyler Retzlaff, Thomas Monjalon, stable
rte_os.h includes sched.h so install sched.h to allow DPDK installed to
DESTDIR to be usable.
Fixes: e8428a9d89f1 ("eal/windows: add some basic functions and macros")
Cc: stable@dpdk.org
Cc: pallavi.kadam@intel.com
Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
v2:
* reviewed all other headers to see if any should be added to
the series, no other headers need to be installed as they are
not exposed through already installed / public headers.
* add Fixes tag as suggested by Thomas
lib/eal/windows/include/meson.build | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/eal/windows/include/meson.build b/lib/eal/windows/include/meson.build
index 5fb1962..e985a77 100644
--- a/lib/eal/windows/include/meson.build
+++ b/lib/eal/windows/include/meson.build
@@ -6,4 +6,5 @@ includes += include_directories('.')
headers += files(
'rte_os.h',
'rte_windows.h',
+ 'sched.h',
)
--
1.8.3.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] windows: install sched.h header
2024-01-30 16:52 ` Thomas Monjalon
@ 2024-03-12 17:55 ` Tyler Retzlaff
0 siblings, 0 replies; 6+ messages in thread
From: Tyler Retzlaff @ 2024-03-12 17:55 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, Bruce Richardson
On Tue, Jan 30, 2024 at 05:52:54PM +0100, Thomas Monjalon wrote:
> 20/12/2023 10:11, Bruce Richardson:
> > On Tue, Dec 19, 2023 at 12:17:37PM -0800, Tyler Retzlaff wrote:
> > > rte_os.h includes sched.h so install sched.h to allow DPDK installed to
> > > DESTDIR to be usable.
>
> Why other files don't need to be exported as well?
after reviewing all other files it was found that only sched.h is being
included by an installed / public header. all other headers in
windows/include are used internally only.
>
> > > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > > ---
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>
> That's a fix which may need to be backported.
found the commit that added sched.h and added a Fixes tag.
thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] windows: install sched.h header
2024-03-12 17:54 ` [PATCH v2] " Tyler Retzlaff
@ 2024-05-29 13:25 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2024-05-29 13:25 UTC (permalink / raw)
To: Tyler Retzlaff
Cc: dev, stable, Bruce Richardson, Dmitry Kozlyuk, Pallavi Kadam,
Ranjit Menon
12/03/2024 18:54, Tyler Retzlaff:
> rte_os.h includes sched.h so install sched.h to allow DPDK installed to
> DESTDIR to be usable.
>
> Fixes: e8428a9d89f1 ("eal/windows: add some basic functions and macros")
> Cc: stable@dpdk.org
> Cc: pallavi.kadam@intel.com
>
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-05-29 13:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-19 20:17 [PATCH] windows: install sched.h header Tyler Retzlaff
2023-12-20 9:11 ` Bruce Richardson
2024-01-30 16:52 ` Thomas Monjalon
2024-03-12 17:55 ` Tyler Retzlaff
2024-03-12 17:54 ` [PATCH v2] " Tyler Retzlaff
2024-05-29 13:25 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).