DPDK patches and discussions
 help / color / mirror / Atom feed
From: Chaoyong He <chaoyong.he@corigine.com>
To: dev@dpdk.org
Cc: oss-drivers@corigine.com, Chaoyong He <chaoyong.he@corigine.com>,
	long.wu@corigine.com, stable@dpdk.org,
	Peng Zhang <peng.zhang@corigine.com>
Subject: [PATCH 2/8] net/nfp: fix string overflow
Date: Thu, 14 Mar 2024 15:05:30 +0800	[thread overview]
Message-ID: <20240314070536.3169210-3-chaoyong.he@corigine.com> (raw)
In-Reply-To: <20240314070536.3169210-1-chaoyong.he@corigine.com>

CI found in the logic of 'nfp_sync_pci_inner_handle_alloc()', use
'strcpy()' may cause string overflow, fix it by use 'rte_strlcpy()'.

Coverity issue: 414937
Fixes: 6b4273a03779 ("net/nfp: add synchronization module")
Cc: long.wu@corigine.com
Cc: stable@dpdk.org

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
---
 drivers/net/nfp/nfpcore/nfp_sync.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/nfp/nfpcore/nfp_sync.c b/drivers/net/nfp/nfpcore/nfp_sync.c
index 8bc38d6585..686cdf8eb1 100644
--- a/drivers/net/nfp/nfpcore/nfp_sync.c
+++ b/drivers/net/nfp/nfpcore/nfp_sync.c
@@ -9,6 +9,7 @@
 #include <rte_malloc.h>
 #include <rte_memzone.h>
 #include <rte_spinlock.h>
+#include <rte_string_fns.h>
 
 #include "nfp_logs.h"
 
@@ -266,7 +267,7 @@ nfp_sync_pci_inner_handle_alloc(struct nfp_sync *sync,
 	for (i = 0; i < NFP_SYNC_PCI_MAX; i++) {
 		if (strlen(sync->pci[i].pci_name) == 0) {
 			pci_avail_id = i;
-			strcpy(sync->pci[pci_avail_id].pci_name, pci_name);
+			rte_strlcpy(sync->pci[pci_avail_id].pci_name, pci_name, PCI_PRI_STR_SIZE);
 			goto common_alloc;
 		}
 	}
-- 
2.39.1


  parent reply	other threads:[~2024-03-14  7:06 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-14  7:05 [PATCH 0/8] fix some coverity issues Chaoyong He
2024-03-14  7:05 ` [PATCH 1/8] net/nfp: fix return value check Chaoyong He
2024-03-14  7:05 ` Chaoyong He [this message]
2024-03-14  7:05 ` [PATCH 3/8] net/nfp: fix unreachable control flow Chaoyong He
2024-03-14  7:05 ` [PATCH 4/8] net/nfp: fix check return value Chaoyong He
2024-03-14  7:05 ` [PATCH 5/8] net/nfp: fix unreachable loop flow Chaoyong He
2024-03-14  7:05 ` [PATCH 6/8] net/nfp: fix null pointer dereference Chaoyong He
2024-03-14  7:05 ` [PATCH 7/8] net/nfp: fix dereference after null check Chaoyong He
2024-03-14  7:05 ` [PATCH 8/8] net/nfp: fix tainted scalar Chaoyong He
2024-03-14  7:40 ` [PATCH v2 0/8] fix some coverity issues Chaoyong He
2024-03-14  7:40   ` [PATCH v2 1/8] net/nfp: fix return value check Chaoyong He
2024-03-14  7:40   ` [PATCH v2 2/8] net/nfp: fix string overflow Chaoyong He
2024-03-14  7:40   ` [PATCH v2 3/8] net/nfp: fix unreachable control flow Chaoyong He
2024-03-14  7:40   ` [PATCH v2 4/8] net/nfp: fix check return value Chaoyong He
2024-03-14  7:40   ` [PATCH v2 5/8] net/nfp: fix unreachable loop flow Chaoyong He
2024-03-14  7:40   ` [PATCH v2 6/8] net/nfp: fix null pointer dereference Chaoyong He
2024-03-14  7:40   ` [PATCH v2 7/8] net/nfp: fix dereference after null check Chaoyong He
2024-03-14  7:40   ` [PATCH v2 8/8] net/nfp: fix tainted scalar Chaoyong He
2024-03-14 11:01   ` [PATCH v2 0/8] fix some coverity issues Ferruh Yigit
2024-03-14 10:58 ` [PATCH " Ferruh Yigit
2024-03-14 11:01   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240314070536.3169210-3-chaoyong.he@corigine.com \
    --to=chaoyong.he@corigine.com \
    --cc=dev@dpdk.org \
    --cc=long.wu@corigine.com \
    --cc=oss-drivers@corigine.com \
    --cc=peng.zhang@corigine.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).