DPDK patches and discussions
 help / color / mirror / Atom feed
From: Chaoyong He <chaoyong.he@corigine.com>
To: dev@dpdk.org
Cc: oss-drivers@corigine.com, Chaoyong He <chaoyong.he@corigine.com>,
	long.wu@corigine.com, stable@dpdk.org,
	Peng Zhang <peng.zhang@corigine.com>
Subject: [PATCH v2 4/8] net/nfp: fix check return value
Date: Thu, 14 Mar 2024 15:40:20 +0800	[thread overview]
Message-ID: <20240314074024.3199555-5-chaoyong.he@corigine.com> (raw)
In-Reply-To: <20240314074024.3199555-1-chaoyong.he@corigine.com>

CI found in 'nfp_service_disable()', not check the return value of API
'rte_service_map_lcore_set()'.

Coverity issue: 414939
Fixes: 600f6d2c7704 ("net/nfp: add service module")
Cc: long.wu@corigine.com
Cc: stable@dpdk.org

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
---
 drivers/net/nfp/nfp_service.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/net/nfp/nfp_service.c b/drivers/net/nfp/nfp_service.c
index f49fa6addf..24d60857ac 100644
--- a/drivers/net/nfp/nfp_service.c
+++ b/drivers/net/nfp/nfp_service.c
@@ -90,6 +90,7 @@ nfp_service_enable(const struct rte_service_spec *service_spec,
 int
 nfp_service_disable(struct nfp_service_info *info)
 {
+	int ret;
 	uint32_t i;
 	const char *service_name;
 
@@ -107,10 +108,16 @@ nfp_service_disable(struct nfp_service_info *info)
 			break;
 		rte_delay_ms(1);
 	}
+
 	if (i == NFP_SERVICE_DISABLE_WAIT_COUNT)
 		PMD_DRV_LOG(ERR, "Could not stop service %s", service_name);
 
-	rte_service_map_lcore_set(info->id, info->lcore, 0);
+	ret = rte_service_map_lcore_set(info->id, info->lcore, 0);
+	if (ret != 0) {
+		PMD_DRV_LOG(DEBUG, "Could not unmap flower service");
+		return -ENOENT;
+	}
+
 	rte_service_component_unregister(info->id);
 
 	return 0;
-- 
2.39.1


  parent reply	other threads:[~2024-03-14  7:41 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-14  7:05 [PATCH 0/8] fix some coverity issues Chaoyong He
2024-03-14  7:05 ` [PATCH 1/8] net/nfp: fix return value check Chaoyong He
2024-03-14  7:05 ` [PATCH 2/8] net/nfp: fix string overflow Chaoyong He
2024-03-14  7:05 ` [PATCH 3/8] net/nfp: fix unreachable control flow Chaoyong He
2024-03-14  7:05 ` [PATCH 4/8] net/nfp: fix check return value Chaoyong He
2024-03-14  7:05 ` [PATCH 5/8] net/nfp: fix unreachable loop flow Chaoyong He
2024-03-14  7:05 ` [PATCH 6/8] net/nfp: fix null pointer dereference Chaoyong He
2024-03-14  7:05 ` [PATCH 7/8] net/nfp: fix dereference after null check Chaoyong He
2024-03-14  7:05 ` [PATCH 8/8] net/nfp: fix tainted scalar Chaoyong He
2024-03-14  7:40 ` [PATCH v2 0/8] fix some coverity issues Chaoyong He
2024-03-14  7:40   ` [PATCH v2 1/8] net/nfp: fix return value check Chaoyong He
2024-03-14  7:40   ` [PATCH v2 2/8] net/nfp: fix string overflow Chaoyong He
2024-03-14  7:40   ` [PATCH v2 3/8] net/nfp: fix unreachable control flow Chaoyong He
2024-03-14  7:40   ` Chaoyong He [this message]
2024-03-14  7:40   ` [PATCH v2 5/8] net/nfp: fix unreachable loop flow Chaoyong He
2024-03-14  7:40   ` [PATCH v2 6/8] net/nfp: fix null pointer dereference Chaoyong He
2024-03-14  7:40   ` [PATCH v2 7/8] net/nfp: fix dereference after null check Chaoyong He
2024-03-14  7:40   ` [PATCH v2 8/8] net/nfp: fix tainted scalar Chaoyong He
2024-03-14 11:01   ` [PATCH v2 0/8] fix some coverity issues Ferruh Yigit
2024-03-14 10:58 ` [PATCH " Ferruh Yigit
2024-03-14 11:01   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240314074024.3199555-5-chaoyong.he@corigine.com \
    --to=chaoyong.he@corigine.com \
    --cc=dev@dpdk.org \
    --cc=long.wu@corigine.com \
    --cc=oss-drivers@corigine.com \
    --cc=peng.zhang@corigine.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).