DPDK patches and discussions
 help / color / mirror / Atom feed
From: Chaoyong He <chaoyong.he@corigine.com>
To: dev@dpdk.org
Cc: oss-drivers@corigine.com, Chaoyong He <chaoyong.he@corigine.com>,
	stable@dpdk.org, Long Wu <long.wu@corigine.com>,
	Peng Zhang <peng.zhang@corigine.com>
Subject: [PATCH v2 6/8] net/nfp: fix null pointer dereference
Date: Thu, 14 Mar 2024 15:40:22 +0800	[thread overview]
Message-ID: <20240314074024.3199555-7-chaoyong.he@corigine.com> (raw)
In-Reply-To: <20240314074024.3199555-1-chaoyong.he@corigine.com>

CI found there are null pointer dereference in 'nfp_flow_merge_l4()'.

Coverity issue: 414942
Fixes: 94438b093702 ("net/nfp: support TCP/UDP/SCTP flow items")
Cc: stable@dpdk.org

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
---
 drivers/net/nfp/nfp_net_flow.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/net/nfp/nfp_net_flow.c b/drivers/net/nfp/nfp_net_flow.c
index 251974edb4..ea743eed73 100644
--- a/drivers/net/nfp/nfp_net_flow.c
+++ b/drivers/net/nfp/nfp_net_flow.c
@@ -349,12 +349,15 @@ nfp_flow_merge_l4(struct rte_flow *nfp_flow,
 
 		ipv4->src_port = rte_be_to_cpu_16(spec->hdr.src_port);
 		ipv4->dst_port = rte_be_to_cpu_16(spec->hdr.dst_port);
-	} else {
+	} else if (ipv6 != NULL) {
 		ipv6->src_port_mask = rte_be_to_cpu_16(mask->hdr.src_port);
 		ipv6->dst_port_mask = rte_be_to_cpu_16(mask->hdr.dst_port);
 
 		ipv6->src_port = rte_be_to_cpu_16(spec->hdr.src_port);
 		ipv6->dst_port = rte_be_to_cpu_16(spec->hdr.dst_port);
+	} else {
+		PMD_DRV_LOG(ERR, "No valid L3 layer pointer.");
+		return -EINVAL;
 	}
 
 	return 0;
-- 
2.39.1


  parent reply	other threads:[~2024-03-14  7:41 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-14  7:05 [PATCH 0/8] fix some coverity issues Chaoyong He
2024-03-14  7:05 ` [PATCH 1/8] net/nfp: fix return value check Chaoyong He
2024-03-14  7:05 ` [PATCH 2/8] net/nfp: fix string overflow Chaoyong He
2024-03-14  7:05 ` [PATCH 3/8] net/nfp: fix unreachable control flow Chaoyong He
2024-03-14  7:05 ` [PATCH 4/8] net/nfp: fix check return value Chaoyong He
2024-03-14  7:05 ` [PATCH 5/8] net/nfp: fix unreachable loop flow Chaoyong He
2024-03-14  7:05 ` [PATCH 6/8] net/nfp: fix null pointer dereference Chaoyong He
2024-03-14  7:05 ` [PATCH 7/8] net/nfp: fix dereference after null check Chaoyong He
2024-03-14  7:05 ` [PATCH 8/8] net/nfp: fix tainted scalar Chaoyong He
2024-03-14  7:40 ` [PATCH v2 0/8] fix some coverity issues Chaoyong He
2024-03-14  7:40   ` [PATCH v2 1/8] net/nfp: fix return value check Chaoyong He
2024-03-14  7:40   ` [PATCH v2 2/8] net/nfp: fix string overflow Chaoyong He
2024-03-14  7:40   ` [PATCH v2 3/8] net/nfp: fix unreachable control flow Chaoyong He
2024-03-14  7:40   ` [PATCH v2 4/8] net/nfp: fix check return value Chaoyong He
2024-03-14  7:40   ` [PATCH v2 5/8] net/nfp: fix unreachable loop flow Chaoyong He
2024-03-14  7:40   ` Chaoyong He [this message]
2024-03-14  7:40   ` [PATCH v2 7/8] net/nfp: fix dereference after null check Chaoyong He
2024-03-14  7:40   ` [PATCH v2 8/8] net/nfp: fix tainted scalar Chaoyong He
2024-03-14 11:01   ` [PATCH v2 0/8] fix some coverity issues Ferruh Yigit
2024-03-14 10:58 ` [PATCH " Ferruh Yigit
2024-03-14 11:01   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240314074024.3199555-7-chaoyong.he@corigine.com \
    --to=chaoyong.he@corigine.com \
    --cc=dev@dpdk.org \
    --cc=long.wu@corigine.com \
    --cc=oss-drivers@corigine.com \
    --cc=peng.zhang@corigine.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).