From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0EDF343CB2; Thu, 14 Mar 2024 10:17:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7EE6C42E7E; Thu, 14 Mar 2024 10:17:34 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id D961142E6D for ; Thu, 14 Mar 2024 10:17:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710407851; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L/18u6ae0kli5zs6MT0v2c7m3+DYgVhOaeTySpFiNQA=; b=gVbtdul39JoYTxr1FnR+YA1EZq0eqBlZ8Nh0bk0H2v/QUgWlxH5MCuABWYODerLKWmIn80 QOOC7eGrNvS9ElmoGMQujj2EC/mOhU+Q5F0ckUu+drT7iKsouV+gKF0nydCpYOv6riN5Ch W4WgoprBnAgZYqLIXigTe82/icD6cbo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-446-rYa23I8MPSOhm0F__TwvhA-1; Thu, 14 Mar 2024 05:17:27 -0400 X-MC-Unique: rYa23I8MPSOhm0F__TwvhA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 69ECD1884973; Thu, 14 Mar 2024 09:17:27 +0000 (UTC) Received: from dmarchan.redhat.com (unknown [10.45.225.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id A5054C017A0; Thu, 14 Mar 2024 09:17:26 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: Aman Singh , Yuying Zhang Subject: [PATCH v2 4/6] app/testpmd: enhance queue count check Date: Thu, 14 Mar 2024 10:17:05 +0100 Message-ID: <20240314091708.1542769-5-david.marchand@redhat.com> In-Reply-To: <20240314091708.1542769-1-david.marchand@redhat.com> References: <20240308144841.3615262-1-david.marchand@redhat.com> <20240314091708.1542769-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Checking the number of rxq/txq in the middle of option parsing is confusing. Besides, a check on nb_rxq / nb_txq check already exists after option parsing. Only keep this latter check and make testpmd quit in this case. Signed-off-by: David Marchand --- Changes since v1: - moved the check and termination out of argument parsing, --- app/test-pmd/parameters.c | 4 ---- app/test-pmd/testpmd.c | 3 +-- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index a4c09e2a2b..fc5cf3a195 100644 --- a/app/test-pmd/parameters.c +++ b/app/test-pmd/parameters.c @@ -1098,10 +1098,6 @@ launch_args_parse(int argc, char** argv) n + nb_rxq, get_allowed_max_nb_rxq(&pid)); } - if (!nb_rxq && !nb_txq) { - rte_exit(EXIT_FAILURE, "Either rx or tx queues should " - "be non-zero\n"); - } if (!strcmp(lgopts[opt_idx].name, "hairpin-mode")) { char *end = NULL; unsigned int n; diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 9e4e99e53b..81d905d759 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -4619,8 +4619,7 @@ main(int argc, char** argv) } if (!nb_rxq && !nb_txq) - fprintf(stderr, - "Warning: Either rx or tx queues should be non-zero\n"); + rte_exit(EXIT_FAILURE, "Either rx or tx queues should be non-zero\n"); if (nb_rxq > 1 && nb_rxq > nb_txq) fprintf(stderr, -- 2.44.0