From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DF0C43D17; Thu, 21 Mar 2024 17:17:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EEF6942DF5; Thu, 21 Mar 2024 17:17:31 +0100 (CET) Received: from mail-oa1-f54.google.com (mail-oa1-f54.google.com [209.85.160.54]) by mails.dpdk.org (Postfix) with ESMTP id 18792427E1 for ; Thu, 21 Mar 2024 17:17:30 +0100 (CET) Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-22222357d76so453056fac.2 for ; Thu, 21 Mar 2024 09:17:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1711037850; x=1711642650; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Nj6jIqUFW0rlyfwHhidWD2j4d4a0Rcwr1fefGVhNkKk=; b=ymL3zrrEYHSwTmxcoXxgDY/WWNgJmB9b8SuUFo0sQZJnFgnRYhz+s3CiiLkjSQqwqA OBBdkClwORA+Uzqib83TaP0RaA8o2D3OZWAiVkEPYN6pS11AW4B0MzEjzdF3TmEwzciS js8PReDjKi/OrZWCnCW/gJAZfK8dd4SE5GbNMi0yh7qtC7dhMzrczk/ODj/MoA+p2IIr TisE8gt3ArQeZGYrAKFoAHdU3Aha5CYDCrSAgymRFhATD5Ktvp9AtA2L2vvAgeIMori9 Hy838ohrKKi+63XMM20bmFHknw0X2E9ndC29s+jKT2tV2k+ku1qJKgWtoJf+E1f1fcaj Uv3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711037850; x=1711642650; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Nj6jIqUFW0rlyfwHhidWD2j4d4a0Rcwr1fefGVhNkKk=; b=ANwwJPrIb5D+w7bfPHKa2OqVgjxHMWC9oO/+x37WZ5KPtQq96MGaQIkvzc+HeMbA68 7XqGCW52YF6HO5IVLNiTdzY3xiQkHPxx6RhX1N4COeWrPLfTp+Izy0/GRZwPII/JgwcI vqWCgPPQEU1kCvt3RB1c5IXXr8fpODq361vRv2cgQbftppoouxP0vDuYTOBYeMoLQuBa QvJRN+BbSrd69WXuzv5LN/GTLl+lDV36cT7z0etd5HXd0/S1KFqOAl9F7KZyK6r7pgco 2K5yRURQERIRg9yCZyxGzFfhbgAg8OjNkdXQpPplvWnTkrwN1ZxFim8KboJpMT+bW3B7 NKvg== X-Gm-Message-State: AOJu0YyRvHiaVmFoN4Lvs2+7Svf/4SPPNTc/TLEoT59NjQ1n5SIF/9IZ IxXKzZdj+nqlvmRzr/2lVv0RA1A8hDECMdscKC1IvlqdxtrBf9JSNPVPuJTMMgYYlyDvOodS1cQ 5 X-Google-Smtp-Source: AGHT+IH5AwqKq8AKiAa6wFu25sNjHNKI8rat4508mKtyggdDj6wyhqDHO6jDGvXO/dhmAx5Ool4i9w== X-Received: by 2002:a05:6358:7f0b:b0:17e:69cf:2105 with SMTP id p11-20020a0563587f0b00b0017e69cf2105mr2957674rwn.29.1711037520253; Thu, 21 Mar 2024 09:12:00 -0700 (PDT) Received: from hermes.local (204-195-123-203.wavecable.com. [204.195.123.203]) by smtp.gmail.com with ESMTPSA id w62-20020a638241000000b005e485fbd455sm41815pgd.45.2024.03.21.09.11.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Mar 2024 09:11:59 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v10 05/10] eal: do not duplicate rte_init_alert() messages Date: Thu, 21 Mar 2024 09:00:21 -0700 Message-ID: <20240321161146.340421-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240321161146.340421-1-stephen@networkplumber.org> References: <20200814173441.23086-1-stephen@networkplumber.org> <20240321161146.340421-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The message already goes through logging, and does not need to be printed on stderr. Message level should be ALERT to match function name. Signed-off-by: Stephen Hemminger --- lib/eal/freebsd/eal.c | 3 +-- lib/eal/linux/eal.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c index 777770176339..e3f25f619715 100644 --- a/lib/eal/freebsd/eal.c +++ b/lib/eal/freebsd/eal.c @@ -530,8 +530,7 @@ rte_eal_iopl_init(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* Launch threads, called at application init(). */ diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c index e515f3cbc8a8..461f0c093357 100644 --- a/lib/eal/linux/eal.c +++ b/lib/eal/linux/eal.c @@ -840,8 +840,7 @@ static int rte_eal_vfio_setup(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* -- 2.43.0