From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B0C3E43D17; Thu, 21 Mar 2024 17:22:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9C9C242E19; Thu, 21 Mar 2024 17:22:31 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 6F2CA42E13 for ; Thu, 21 Mar 2024 17:22:29 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id B9D8520B74C0; Thu, 21 Mar 2024 09:22:28 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B9D8520B74C0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1711038148; bh=OQD3XlxaX2oYwEijg57V1orTeQCrL/oiCjhSmKRWaJw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bLU5e4YTZA/AFI0VLCcxkiIBuIMsp+3o1Ln/MQf1rtIFk9SdVXQzNMd6O0lct2u55 ImNnYUIP72PfrGwqsJnpa9Op9DEPgkPTCAX6/QKA8bogm/xs1Gb+KmWGzjC8gTkNZ0 VcajQVB69gIGBJ3wudd4MJwu2fMwto+Od714bcIQ= Date: Thu, 21 Mar 2024 09:22:28 -0700 From: Tyler Retzlaff To: Stephen Hemminger Cc: dev@dpdk.org, Mattias =?iso-8859-1?Q?R=F6nnblom?= , Morten =?iso-8859-1?Q?Br=F8rup?= , Abdullah Sevincer , Ajit Khaparde , Alok Prasad , Anatoly Burakov , Andrew Rybchenko , Anoob Joseph , Bruce Richardson , Byron Marohn , Chenbo Xia , Chengwen Feng , Ciara Loftus , Ciara Power , Dariusz Sosnowski , David Hunt , Devendra Singh Rawat , Erik Gabriel Carrillo , Guoyang Zhou , Harman Kalra , Harry van Haaren , Honnappa Nagarahalli , Jakub Grajciar , Jerin Jacob , Jeroen de Borst , Jian Wang , Jiawen Wu , Jie Hai , Jingjing Wu , Joshua Washington , Joyce Kong , Junfeng Guo , Kevin Laatz , Konstantin Ananyev , Liang Ma , Long Li , Maciej Czekaj , Matan Azrad , Maxime Coquelin , Nicolas Chautru , Ori Kam , Pavan Nikhilesh , Peter Mccarthy , Rahul Lakkireddy , Reshma Pattan , Rosen Xu , Ruifeng Wang , Rushil Gupta , Sameh Gobriel , Sivaprasad Tummala , Somnath Kotur , Suanming Mou , Sunil Kumar Kori , Sunil Uttarwar , Tetsuya Mukawa , Vamsi Attunuru , Viacheslav Ovsiienko , Vladimir Medvedkin , Xiaoyun Wang , Yipeng Wang , Yisen Zhuang , Yuying Zhang , Ziyang Xuan Subject: Re: [PATCH 00/46] use stdatomic API Message-ID: <20240321162228.GC11257@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1710967892-7046-1-git-send-email-roretzla@linux.microsoft.com> <20240321083323.098c93da@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240321083323.098c93da@hermes.local> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Mar 21, 2024 at 08:33:23AM -0700, Stephen Hemminger wrote: > On Wed, 20 Mar 2024 13:50:46 -0700 > Tyler Retzlaff wrote: > > > This series converts all non-generic built atomics to use the rte_atomic > > macros that allow optional enablement of standard C11 atomics. > > > > Use of generic atomics for non-scalar types are not converted in this > > change and will be evaluated as a part of a separate series. > > > > Note if this series ends up requiring too much rebasing due to tree > > churn before it is merged i will break it up into smaller series. > > Maybe a coccinelle script to automate this and check/fix future usages? it also isn't strictly a 1:1 replacement so some __atomic_ could be text replaced sometimes you need to evaluate arguments on e.g. compare exchange to pick the right macro, sometimes there are generic vs scalar version to deal with. we already have a checkpatches check but right now it is (I think) being ignored when merging changes to drivers that have not been converted. so if we get things converted there shouldn't be any further reason to accept series that are being flagged by checkpatches. > > Series-acked-by: Stephen Hemminger