From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E9DA843D00;
	Thu, 21 Mar 2024 18:49:09 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 74DEE42D45;
	Thu, 21 Mar 2024 18:49:09 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 664F2402C2
 for <dev@dpdk.org>; Thu, 21 Mar 2024 18:49:07 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 9609620B74C0; Thu, 21 Mar 2024 10:49:06 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 9609620B74C0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1711043346;
 bh=UtnypcI0+Hm9UMQnHFCmJKgxSRs7KDtm30S+7QiIuxI=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=CBM4OwJqRcno2UW3ESe1iEzZ/I3Gl1ZsIkOUn3bFGhvqxWKvOMXtd2RN5gb0PPln2
 BCMOm8hzb3STZBeXskVu/ZNf1l8Loc5tvKMfEtQhtDvwejKnkacmUe0Rbv1XK+v1Wi
 g6ZqCrZQcB0gymthwGCe+z11vO/uqjqpFCHuJH6A=
Date: Thu, 21 Mar 2024 10:49:06 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [PATCH v10 08/10] eal: add option to put timestamp on console
 output
Message-ID: <20240321174906.GA4897@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20200814173441.23086-1-stephen@networkplumber.org>
 <20240321161146.340421-1-stephen@networkplumber.org>
 <20240321161146.340421-9-stephen@networkplumber.org>
 <20240321171131.GD27371@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
 <20240321101636.0bab71ae@hermes.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240321101636.0bab71ae@hermes.local>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Thu, Mar 21, 2024 at 10:16:36AM -0700, Stephen Hemminger wrote:
> On Thu, 21 Mar 2024 10:11:31 -0700
> Tyler Retzlaff <roretzla@linux.microsoft.com> wrote:
> 
> > >  
> > >  
> > > +Console timestamp
> > > +~~~~~~~~~~~~~~~~~
> > > +
> > > +On Linux and FreeBSD, an optional timestamp can be added before each
> > > +message by adding the ``--log-timestamp`` option.  
> > 
> > i don't think Windows should be excluded from the feature, in general
> > core libraries that get features should cover all platforms.
> 
> The problem is that current Linux/FreeBSD log code depends on fopencookie()
> to work. I could not find a way to do that on Windows.

but that looks like it is part of general log initialization. surely
when we are talking about logging a timestamp to a console we're just
talking about a standard stream and a format string for Windows?

i'll try to study more to gain a better understanding.

thanks