From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C063E43D36; Sun, 24 Mar 2024 03:41:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EFCD4402F0; Sun, 24 Mar 2024 03:41:26 +0100 (CET) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by mails.dpdk.org (Postfix) with ESMTP id 2D53E402E3 for ; Sun, 24 Mar 2024 03:41:23 +0100 (CET) Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-29fbe140c24so2349164a91.0 for ; Sat, 23 Mar 2024 19:41:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1711248082; x=1711852882; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H26hsjphdH2pd0aElhNbFTheietDSMGNDC4gVBIN+HU=; b=kcP1GWukIhSMgrBWzIvakimaSkBqpHj9qnKXs6MltfnuunIjBFpHyEkWjoJL0rlHlC 4BELFvt2hBch2409qBH30ZWyDobeVbYZ2Odk3V9pHzy/xzAVUJuAPt8ksvGrmsqxcZ3o 0mCoh0G5fjyd5jN6Kmgn0KfXlR2x696WIxQ2cSRbdJrFcobZvx2hxd7AeYpfD8DNHBJy CfGqDtpeWM88imrZU6DGeoKQf1E8rXAWpzAMSmzADcy9L51KAKNNj6riz7W2+qpb7LP0 CC7xuyBtXqKfiZX+WNgIYvj1SCpvBOJpeucaVCDmfxSzc4Uf6n6fQF17KaIxlA0R5Q85 GGnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711248082; x=1711852882; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H26hsjphdH2pd0aElhNbFTheietDSMGNDC4gVBIN+HU=; b=N/A7UnReMcqcSUSe3OMmls+kXV3XAJyqohpG6BH1+AezG6Zwn44QeEG+NoxbAEKwW9 F1obXVcKD0/atng2l7F7fIk4DyDE7U4WDnpAmtJ11QR0uu/bSkABfneEo5/ZRG+dU9HE 5dJjmqGd4fiDYh7Yg47KA2mKZ6zgtc9zzlXoTs4xvYgY5Xxjn1Xnpp03aoIwqzlVO/K1 8qpyk885s1csreaAvzYBNrlyoxoXfybZQsJ9ncsh9mtIpL+9lnWm+sniiInWnCsw4qSU IkznUqAhNoANOj6go4oY5ynJJJjZdskElFfGblbLwu2/z9nmUGQJ1hyvk3C5yLv+DAUE 1yaA== X-Gm-Message-State: AOJu0YxcoH/Won8DSlpOXdS8JvDTbhIzb/Q2X2GMFjV1AuuoDqjmbcz5 vzQd6NG/DS4ihg7H/l5BPKOQ1+F8XThgaEbnaVt9OsnOAimhQNOiI9ZWnql7ElYtrNa9a13MxH4 g X-Google-Smtp-Source: AGHT+IFfvx85PusfXZ817p8aWD5Gfo/kv9qK/jA7+z1+kDEhPiVZulGfwHzXPEbY3St8Yo+ZyjqFow== X-Received: by 2002:a17:902:d2cf:b0:1de:f840:fb22 with SMTP id n15-20020a170902d2cf00b001def840fb22mr4378484plc.12.1711248082294; Sat, 23 Mar 2024 19:41:22 -0700 (PDT) Received: from hermes.local (204-195-123-203.wavecable.com. [204.195.123.203]) by smtp.gmail.com with ESMTPSA id q17-20020a17090311d100b001dc3c4e7a12sm2244980plh.14.2024.03.23.19.41.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Mar 2024 19:41:21 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Bruce Richardson Subject: [PATCH v11 3/9] eal: do not duplicate rte_init_alert() messages Date: Sat, 23 Mar 2024 19:33:25 -0700 Message-ID: <20240324024109.306614-4-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324024109.306614-1-stephen@networkplumber.org> References: <20200814173441.23086-1-stephen@networkplumber.org> <20240324024109.306614-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The message already goes through logging, and does not need to be printed on stderr. Message level should be ALERT to match function name. Signed-off-by: Stephen Hemminger --- lib/eal/freebsd/eal.c | 3 +-- lib/eal/linux/eal.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c index 9825bcea0b..17b56f38aa 100644 --- a/lib/eal/freebsd/eal.c +++ b/lib/eal/freebsd/eal.c @@ -529,8 +529,7 @@ rte_eal_iopl_init(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* Launch threads, called at application init(). */ diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c index bffeb1f34e..23dc26b124 100644 --- a/lib/eal/linux/eal.c +++ b/lib/eal/linux/eal.c @@ -840,8 +840,7 @@ static int rte_eal_vfio_setup(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* -- 2.43.0