From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3520343D49; Mon, 25 Mar 2024 21:54:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 78D9E40DD8; Mon, 25 Mar 2024 21:54:24 +0100 (CET) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id E7A2640C35 for ; Mon, 25 Mar 2024 21:54:20 +0100 (CET) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1e04ac200a6so33569465ad.1 for ; Mon, 25 Mar 2024 13:54:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1711400060; x=1712004860; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H26hsjphdH2pd0aElhNbFTheietDSMGNDC4gVBIN+HU=; b=0lwrIJYxvNLf0a39fcRhlraOvEYAA1lH7mWpaTn6q288vpNniCPZVpcMiaRpYt4a2k XhaeyUQBc3BoT5AcgGbdxHevhQH5arMHutBifyz2tOyS7JAc2ira++RswQUXVCMrchbL 2pCdGM51NlpI+R/B/vDhnM8Tx4Tzhje9OJtHkUvCzfOF6Z7eKWh12MSTyKXJCbYOgnpM 07vvz6kD+L+AhifoxWZbaKfHWzZQCGJapKgJtucTjr0N6JO+OUChZdHlFCqu638k5BxP zYraZdIa5liOVx5SFhCNKsyXhF4bpzKe+vXBmUpDSrSAAJmGQyGdVTJ3BCR1l8ZfWZwX F1EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711400060; x=1712004860; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H26hsjphdH2pd0aElhNbFTheietDSMGNDC4gVBIN+HU=; b=E3G07RR1FrlhBI3n7ndMrq/6Au00mC3/gIab/ev2PnMHbSB3Q8pSpZdz8xz2L1YCvn bTNeRp+QD1zm+wDiiUrsCVVAFl4yRIjbCQIVP6J+LeY3H94vMc2nTqIASGATkTpYA3j1 pYq3A1fYcImaih7sXfVblbMPh4O9juglQzM63Z7rA8Uw/GbebLr/pHvXfNfpV0MWDfWX ce1JblHQSUjEQtkiJksyZs2TLE4qKucJAk4BJ7wnjoxgAFKjBdX/CYSv5wUUbmXCxa/c 8KO+kPaIp78efqCB0EOuDRedJ6RwyoiSxdv0KFUGoLIVXauZVqrfoqmWE1KvX0+TOuJ9 e/iw== X-Gm-Message-State: AOJu0YzurqgedKZMg6n6Lf2ziyuVaPF9aDczXRyQtlWccsr/91DqOTST LLX9FKpOnYEQ/6Gsx7vlqlfcPm9Fckg1FaBhER+mAMlzGrQnOi+oveRoM+zntrz+p233EDUfK0e 0 X-Google-Smtp-Source: AGHT+IEEQwPjz1V90YIKqM817KDpWwBSP7Ql6ZPqU/+Kc2f22bJqNnCvNs7UgzC3embE/XvgM3QAxA== X-Received: by 2002:a17:902:d4d0:b0:1dd:df89:5c2 with SMTP id o16-20020a170902d4d000b001dddf8905c2mr11219004plg.22.1711400060120; Mon, 25 Mar 2024 13:54:20 -0700 (PDT) Received: from hermes.local (204-195-123-203.wavecable.com. [204.195.123.203]) by smtp.gmail.com with ESMTPSA id b18-20020a170903229200b001e0b5eee802sm3164487plh.123.2024.03.25.13.54.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 13:54:19 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Bruce Richardson Subject: [PATCH v12 04/14] eal: do not duplicate rte_init_alert() messages Date: Mon, 25 Mar 2024 13:47:01 -0700 Message-ID: <20240325205405.669897-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240325205405.669897-1-stephen@networkplumber.org> References: <20200814173441.23086-1-stephen@networkplumber.org> <20240325205405.669897-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The message already goes through logging, and does not need to be printed on stderr. Message level should be ALERT to match function name. Signed-off-by: Stephen Hemminger --- lib/eal/freebsd/eal.c | 3 +-- lib/eal/linux/eal.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c index 9825bcea0b..17b56f38aa 100644 --- a/lib/eal/freebsd/eal.c +++ b/lib/eal/freebsd/eal.c @@ -529,8 +529,7 @@ rte_eal_iopl_init(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* Launch threads, called at application init(). */ diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c index bffeb1f34e..23dc26b124 100644 --- a/lib/eal/linux/eal.c +++ b/lib/eal/linux/eal.c @@ -840,8 +840,7 @@ static int rte_eal_vfio_setup(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* -- 2.43.0