From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1A87743D4E; Tue, 26 Mar 2024 02:59:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8BDD240DDD; Tue, 26 Mar 2024 02:58:47 +0100 (CET) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id EA9F040A7D for ; Tue, 26 Mar 2024 02:58:42 +0100 (CET) Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1dddbe47ac1so37761775ad.1 for ; Mon, 25 Mar 2024 18:58:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1711418322; x=1712023122; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H26hsjphdH2pd0aElhNbFTheietDSMGNDC4gVBIN+HU=; b=Nh0kwJZczl7Ip84rM45p7bkIxbx1PvWHhZQN32IBpACG/z5KDqB5AqjPU9auxlBZsM dFQCfnnQAAjNAGhSpOTsQaqp9mr1f1rQg8guTjeJGzkFzd3PvEWFGQ8+9jUbc29UFdjt bBQDa5gOpnNYHGer0bwJFakAiGpvRH5FKAUGaDrodupH1OjPswJD2QtUD4J6aazVyzxn o074DTWs9bJozlRg8TCSj/faO4RwtLKL0Zw6vsinW7+EUdX5Es7VIdeYT8wS2bGGI014 7K6vNJgueMuQTrlET+QkdmBEfJZ5WiR43YV7GXHOIgq0fhClx5HfbcPynrGkjS1oBB94 /JsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711418322; x=1712023122; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H26hsjphdH2pd0aElhNbFTheietDSMGNDC4gVBIN+HU=; b=Qcr1MXVExZAwgO8EwfO1Pjjc/xEGR8cJePBBqBl8FrvO/LLiM2y8K2alEz8KKf0HgY dXvlTVbUFsySYjSBxg6ky2DzVxTIQ0jdK0xWG4dvVmEFJK0YBhuUgXh42InJFk3waXTg ROE9+jGViiVca17CZ8GXBzedCPrEVuHFlisNWD+Kgl8673EjnqB4sc7AXHX+3Icw8WEE ytdrWaWWH3908atiXzNxFDFff4iVMn0GI8rHVpZ0PQqriWjuQ1n20oTals0VGHlcXuHS AGwWW/7iNVryY0d1alRr27C45MJ3k69ZAKZJ5u57I7dXJMxaY9Q7EkU0QTzrKgvTUIlI 7CKQ== X-Gm-Message-State: AOJu0Yx/VM0/s4xtqqreWw9wh5Jpqr9dS8tW1VzKX7tPRNDA8GR7LvdS clhY8TlLLVWxxUXaeRu77q0ylxW2bKwx0XEVkxdLbEEII3YvYb3/WkM80d5f78ABlh/NDyiI4xa a X-Google-Smtp-Source: AGHT+IF4yplOQ6zzqliVl8Fk09M63UEMsts0x54aaNqLfZsAfJ/dAXC24kz4MoJNHCX6bKPtePfFbA== X-Received: by 2002:a17:902:c1d5:b0:1e0:c070:b082 with SMTP id c21-20020a170902c1d500b001e0c070b082mr164266plc.14.1711418322061; Mon, 25 Mar 2024 18:58:42 -0700 (PDT) Received: from hermes.local (204-195-123-203.wavecable.com. [204.195.123.203]) by smtp.gmail.com with ESMTPSA id u19-20020a63d353000000b005dc88b232a5sm6571541pgi.26.2024.03.25.18.58.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 18:58:41 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Bruce Richardson Subject: [PATCH v13 04/11] eal: do not duplicate rte_init_alert() messages Date: Mon, 25 Mar 2024 18:56:59 -0700 Message-ID: <20240326015827.825648-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240326015827.825648-1-stephen@networkplumber.org> References: <20200814173441.23086-1-stephen@networkplumber.org> <20240326015827.825648-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The message already goes through logging, and does not need to be printed on stderr. Message level should be ALERT to match function name. Signed-off-by: Stephen Hemminger --- lib/eal/freebsd/eal.c | 3 +-- lib/eal/linux/eal.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c index 9825bcea0b..17b56f38aa 100644 --- a/lib/eal/freebsd/eal.c +++ b/lib/eal/freebsd/eal.c @@ -529,8 +529,7 @@ rte_eal_iopl_init(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* Launch threads, called at application init(). */ diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c index bffeb1f34e..23dc26b124 100644 --- a/lib/eal/linux/eal.c +++ b/lib/eal/linux/eal.c @@ -840,8 +840,7 @@ static int rte_eal_vfio_setup(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* -- 2.43.0