From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 350B543D5A; Tue, 26 Mar 2024 18:36:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E13DA410FC; Tue, 26 Mar 2024 18:36:14 +0100 (CET) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mails.dpdk.org (Postfix) with ESMTP id B1FD540EF0 for ; Tue, 26 Mar 2024 18:36:09 +0100 (CET) Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-6e6ee9e3cffso27648b3a.1 for ; Tue, 26 Mar 2024 10:36:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1711474569; x=1712079369; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H26hsjphdH2pd0aElhNbFTheietDSMGNDC4gVBIN+HU=; b=GpYQbx/FxPlyjPX7Nax8u7pyrtaQFp7FyAtIeB8FoxiSrIss7oYi7zMRFAht7cMqjK ZZjWn/Ky8X3jTy+dgutQ96hZ1H6QySFv23dTGxBLp1yqAjmPEl8eeKKJGauEWTkt8nO+ IeEBQbUKTu3DmFlyWYuhXyvPgJOBB9OzDoNNjxMvZts9w8fJuWEr0iq687BRLxzy30Ix l9vtLgeE1mJ3IxoVWOWL7BXOYtAFp0oVAPofrhWHtJVDlEe282LTTejGGRthyETzR3BW mo0hjZmuYA0tjvEIWPjGYqoMNhYL/gG8+5QxDXGx6q9BB687wu5oR2lrYL9Np7ewXzU5 HqoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711474569; x=1712079369; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H26hsjphdH2pd0aElhNbFTheietDSMGNDC4gVBIN+HU=; b=BcjtABZcEivPxWa69SJmMcgxVZN6UYqeAAuzGI8gioijD3wcTJKV416cLD3ppp8btq AX3ikXBkDAL63n0BReF026hB0W1HMAlMJI47cnuIzmAdeLtdMGevuh9Wq7PnVbSU9ctQ XDyAy4TZ/xjT3jVU4ygmHLHXN97e0rh3iaSneSHH8IYTNqp8lE4LpMAWO4PsOnG6bEbT uBIDA0RpKvO72KCmOSvcOggYRpawlBxayZF7hXPpcXsDD7ta7GAaRHZDxJEBtp7Od/Wh m8F7ns4EipzIC00iUSfsn6lb/rzRR/3NnmDd75BavpouswQ98/sSgs1qlx66WuouDIpb QF1Q== X-Gm-Message-State: AOJu0YxuELGpKYANl5KcgrVH6GmwGQlALD7TOdaJJuPN/qCHlhM4pnlT cBNf1a1OwF7/JEfyQ/JhmTsmI0tp+SyhXjefVyjOFtInmVbVwys/YCe8u8brfIs1H9mRqdV1ozy L X-Google-Smtp-Source: AGHT+IEcJD6GxDxRrOEw6TCjOE8niKTqN8ecUufv9eU6CIYDtDYoOkk2VEPHEDmKchc4jMkzXzxlfQ== X-Received: by 2002:a05:6a00:190e:b0:6e6:88ee:8429 with SMTP id y14-20020a056a00190e00b006e688ee8429mr2606712pfi.11.1711474568827; Tue, 26 Mar 2024 10:36:08 -0700 (PDT) Received: from hermes.local (204-195-123-203.wavecable.com. [204.195.123.203]) by smtp.gmail.com with ESMTPSA id u6-20020aa78386000000b006e58da8bb6asm6205546pfm.132.2024.03.26.10.36.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 10:36:08 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Bruce Richardson Subject: [PATCH v14 06/15] eal: do not duplicate rte_init_alert() messages Date: Tue, 26 Mar 2024 10:34:26 -0700 Message-ID: <20240326173552.97249-7-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240326173552.97249-1-stephen@networkplumber.org> References: <20200814173441.23086-1-stephen@networkplumber.org> <20240326173552.97249-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The message already goes through logging, and does not need to be printed on stderr. Message level should be ALERT to match function name. Signed-off-by: Stephen Hemminger --- lib/eal/freebsd/eal.c | 3 +-- lib/eal/linux/eal.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c index 9825bcea0b..17b56f38aa 100644 --- a/lib/eal/freebsd/eal.c +++ b/lib/eal/freebsd/eal.c @@ -529,8 +529,7 @@ rte_eal_iopl_init(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* Launch threads, called at application init(). */ diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c index bffeb1f34e..23dc26b124 100644 --- a/lib/eal/linux/eal.c +++ b/lib/eal/linux/eal.c @@ -840,8 +840,7 @@ static int rte_eal_vfio_setup(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* -- 2.43.0