From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1D81043D5B; Wed, 27 Mar 2024 01:29:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9E274402A3; Wed, 27 Mar 2024 01:29:11 +0100 (CET) Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by mails.dpdk.org (Postfix) with ESMTP id 38C4D402A3 for ; Wed, 27 Mar 2024 01:29:10 +0100 (CET) Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-5ce6b5e3c4eso3206790a12.2 for ; Tue, 26 Mar 2024 17:29:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1711499349; x=1712104149; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=y8URvnSj+k3dBeU6JgQBW/OxxJhxJby7KTPyGQyzpbs=; b=Nj99PjyrXovuHU/ERwof0nKg47qsFa/5QBDK/fMsgfOUw1MPvOt6vgTugg0rwOi3+G xKzWQh7gXiK31fDNzpS32gjOAcf8eq3hHzoMiadvblNRe5mGyMATziCxirpPhZTqtLC+ hyv58ew+CP2i8rtSIKSK6BePateez3m7LfY2LDLjBWumqsm/MNHI363JmfRUsQxXEwpf KvfjCXlmuvUXoIbr0l8w9Yen5mQbQNn17yor9RQbKaRcps02yZsMu4/BOJ1PiBhTJsaA sVUxVhKX0Rp6Pnlw+0Dz5cv+1qDufVz+iX7cLiXG8uM5rWCatR9TTEe+tQR8bxJ1WUY9 4/VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711499349; x=1712104149; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y8URvnSj+k3dBeU6JgQBW/OxxJhxJby7KTPyGQyzpbs=; b=UsRoGdY7oV0k/nduMSXuusac0vkYt3ZXluhg+7XpXnL6whNRkh8hfg1ptplX5PWR8Z TTN+1wcRVzPem3tgEFkZfhUBhOYCWmbvlMH3qp6U0yqQdiETVVTp2r7/MHN/HMnJ7F51 clYONbsJ3mvFXw+bya5wrI95lm1gvJ/aiW6LLi54tBN//R4VrYopf3Nb1BQ1Mf5OwPmh ExwLO4YmMMCrMZCkd/gM66F7yZH4Hklp0MuLDLrObEzSVYybxtUfycZB63F8SB1A8HOD rPbN4We6HdEmJ8soaB2OhxgxevA+cgqVyTPPIYC50zo1yvkXifV5LnpKxtF3z2Duy5iG V4Pw== X-Gm-Message-State: AOJu0YzgQ6FN5hbVV1qqnMzf+czBClQD81J4mQXAJN7wqkO+2FT11pov prcAzIskXVrW11dwQtL4xW37waZ5+DlXReajjEV3eqsgxxCKEnLy8o8onY6Ppo0HvqEetpcRm6r a X-Google-Smtp-Source: AGHT+IGR2vd8WCLHsPCA6S+c2KWVXqxkgqvLvg8VBz6jGP6q9/k5GcG5Ejm4XKYw+h765oDnlTR7bw== X-Received: by 2002:a17:90b:4d8f:b0:2a0:844b:4270 with SMTP id oj15-20020a17090b4d8f00b002a0844b4270mr1185605pjb.46.1711499348871; Tue, 26 Mar 2024 17:29:08 -0700 (PDT) Received: from hermes.local (204-195-123-203.wavecable.com. [204.195.123.203]) by smtp.gmail.com with ESMTPSA id w15-20020a17090ad60f00b002a04eef22c5sm225383pju.44.2024.03.26.17.29.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 17:29:08 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v15 00/15] Logging unification and improvements Date: Tue, 26 Mar 2024 17:26:59 -0700 Message-ID: <20240327002859.203006-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20200814173441.23086-1-stephen@networkplumber.org> References: <20200814173441.23086-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Improvements and unification of logging library (for 24.07 release). This version works on all platforms: Linux, Windows and FreeBSD. This is update to rework patch set. It adds several new features to the console log output. * Putting a timestamp on console output which is useful for analyzing performance of startup codes. Timestamp is optional and must be enabled on command line. * Displaying console output with colors. It uses the standard conventions used by many other Linux commands for colorized display. The default is to enable color if the console output is going to a terminal. But it can be always on or disabled by command line flag. This default was chosen based on what dmesg(1) command does. I find color helpful because DPDK drivers and libraries print lots of not very useful messages. And having error messages highlighted in bold face helps. This might also get users to pay more attention to error messages. Many bug reports have earlier messages that are lost because there are so many info messages. * Add support for automatic detection of systemd journal protocol. If running as systemd service will get enhanced logging. * Use of syslog is optional and the meaning of the --syslog flag has changed. The default is *not* to use syslog. Add myself as maintainer for log because by now have added more than previous authors... Will add a release note in next release (after this is merged) v15 - fix log test cases avoid use of malloc (ie vasprintf) in log path because malloc pool maybe corrupted. Stephen Hemminger (15): maintainers: add for log library windows: make getopt functions have const properties windows: add os shim for localtime_r windows: common wrapper for vasprintf and asprintf eal: make eal_log_level_parse common eal: do not duplicate rte_init_alert() messages eal: change rte_exit() output to match rte_log() log: move handling of syslog facility out of eal eal: initialize log before everything else log: drop syslog support, and make code common log: add hook for printing log messages log: add timestamp option log: add optional support of syslog log: add support for systemd journal log: colorize log output MAINTAINERS | 1 + app/test/test_eal_flags.c | 64 +- doc/guides/linux_gsg/linux_eal_parameters.rst | 27 - doc/guides/prog_guide/log_lib.rst | 57 ++ drivers/bus/pci/pci_common.c | 32 - lib/eal/common/eal_common_debug.c | 10 +- lib/eal/common/eal_common_options.c | 126 ++-- lib/eal/common/eal_options.h | 5 + lib/eal/common/eal_private.h | 10 - lib/eal/freebsd/eal.c | 64 +- lib/eal/linux/eal.c | 68 +- lib/eal/windows/eal.c | 77 +-- lib/eal/windows/getopt.c | 23 +- lib/eal/windows/include/getopt.h | 8 +- lib/eal/windows/include/rte_os_shim.h | 56 ++ lib/log/log.c | 646 +++++++++++++++++- lib/log/log_freebsd.c | 5 +- lib/log/log_internal.h | 25 +- lib/log/log_linux.c | 61 -- lib/log/log_windows.c | 18 - lib/log/meson.build | 5 +- lib/log/version.map | 4 +- 22 files changed, 964 insertions(+), 428 deletions(-) delete mode 100644 lib/log/log_linux.c delete mode 100644 lib/log/log_windows.c -- 2.43.0