From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3AF4943D5B; Wed, 27 Mar 2024 01:29:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8A8FB42830; Wed, 27 Mar 2024 01:29:20 +0100 (CET) Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by mails.dpdk.org (Postfix) with ESMTP id D1834410E6 for ; Wed, 27 Mar 2024 01:29:14 +0100 (CET) Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-29f1686ff12so4112773a91.1 for ; Tue, 26 Mar 2024 17:29:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1711499354; x=1712104154; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H26hsjphdH2pd0aElhNbFTheietDSMGNDC4gVBIN+HU=; b=t7lTbRqRPJgg4sqGVAZufivEY0sE38jiyjVNqCPdb0lCc39SewNJJDCzyk1eaMNVJU fH95ZzgYK9xEoGWUIQ2euQX7tiBpwgUQKtR2HqRqPW8kia1+Dr+QpgfBxs6GMkUOqa3h JFp5ufjzY6WaIdWL7GD57HggT2WI7tRm4qdmuUkR6vadUm9IFBv0rYst7Xw1LCHTt5XG AYpl7nA8uTz+NthhAqdA2ijFgJytUoLPbBQJtBu0Ii3UpeiPtvHasVm5MZbwpaIS8AjR y7MyDvAXYQxZdc+VBpIrd5c7s7Do31Jyq7z93g6u/lnHuL+Cu5MF06O7eru63GaKUeH9 0Xrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711499354; x=1712104154; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H26hsjphdH2pd0aElhNbFTheietDSMGNDC4gVBIN+HU=; b=IHEEF/BnWWkUAFxABe0v7DJej4K519ApJj4Op6jUxgM+RV4c4Vnq1hHdomiG+Z6zPk l4pnSx7y5dm51+QPOBJdA/phzXgK/CwFSsg6MLX+gOXcgArRHedmobDmW2bhgk3LfxjB 5kHYyTSGDlAGGqVGMunIoM1vTOfnlY5bu549RRskoCM5+RNuNJ76vKqxynqR239CTpQP wtnnAghwXceIwG2zC8qjvGkHO7jHAgBuc9x6cgMYTt46SsaQN//W+GNXQpi4M4l8ZC3T hkh4qoEFcRs9Jf6IyDFZw+Pno5Nly7iJuqzP0Un7vI0j+pp/ic+XnCuam2HFIFlb0oLe lDtA== X-Gm-Message-State: AOJu0YzrHLa013/QISCyit/S1N66lmtS/j2Hf/41OJAtZGzxDEq/TxCl m2zOn1d6c4i350WOjXl12R4WYnaiOGqB/LsyXhxBTFyhBwWfvketGYXC41rnmeuGHMu/qxjQfoy I X-Google-Smtp-Source: AGHT+IGMTKpX0FV5kG/ot8BofuLuF8oEyZdMi5EacxB1X+44/MLYeJ5K9dVBGmu/SKKDmGOsd92kNg== X-Received: by 2002:a17:90a:af85:b0:2a0:3b32:77f6 with SMTP id w5-20020a17090aaf8500b002a03b3277f6mr2698893pjq.29.1711499354107; Tue, 26 Mar 2024 17:29:14 -0700 (PDT) Received: from hermes.local (204-195-123-203.wavecable.com. [204.195.123.203]) by smtp.gmail.com with ESMTPSA id w15-20020a17090ad60f00b002a04eef22c5sm225383pju.44.2024.03.26.17.29.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 17:29:13 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Bruce Richardson Subject: [PATCH v15 06/15] eal: do not duplicate rte_init_alert() messages Date: Tue, 26 Mar 2024 17:27:05 -0700 Message-ID: <20240327002859.203006-7-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240327002859.203006-1-stephen@networkplumber.org> References: <20200814173441.23086-1-stephen@networkplumber.org> <20240327002859.203006-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The message already goes through logging, and does not need to be printed on stderr. Message level should be ALERT to match function name. Signed-off-by: Stephen Hemminger --- lib/eal/freebsd/eal.c | 3 +-- lib/eal/linux/eal.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c index 9825bcea0b..17b56f38aa 100644 --- a/lib/eal/freebsd/eal.c +++ b/lib/eal/freebsd/eal.c @@ -529,8 +529,7 @@ rte_eal_iopl_init(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* Launch threads, called at application init(). */ diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c index bffeb1f34e..23dc26b124 100644 --- a/lib/eal/linux/eal.c +++ b/lib/eal/linux/eal.c @@ -840,8 +840,7 @@ static int rte_eal_vfio_setup(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* -- 2.43.0