From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D25C43D55; Wed, 27 Mar 2024 17:48:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5F9FB427E3; Wed, 27 Mar 2024 17:47:46 +0100 (CET) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mails.dpdk.org (Postfix) with ESMTP id 9481C40E6E for ; Wed, 27 Mar 2024 17:47:41 +0100 (CET) Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-6e7425a6714so80875b3a.0 for ; Wed, 27 Mar 2024 09:47:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1711558061; x=1712162861; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H26hsjphdH2pd0aElhNbFTheietDSMGNDC4gVBIN+HU=; b=va3PwPOX1PEaF1SWo1nfNu738m54S6TceA16Uz5cFqqk3e5tvCHbnRI8rqHMzHyp+w I++9RaApnoDzZuJW/Oj2pQv+e/X7Tij1/QTlNXvh252g/GXGkOkTteiP9lKB9ceE537z zp1D4NN/QnqwAAmIMDcILBjyvL2R+CDACjrG2YYLFv3MhD+sF3TBFRHA5ccoWJqyQPZ8 XIbE1BrimcLgjoJgZnWKDvO5KLzbKVML+hThwib7Nz61VJZsaGWg7svqluiNUhdifB82 Qn9WwhnnZHvg5UTwTXP1Eqml+52Sln6mOc9O6hWFH7WtKprIvTk6CjpxyzhaOmFKa+N7 4OzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711558061; x=1712162861; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H26hsjphdH2pd0aElhNbFTheietDSMGNDC4gVBIN+HU=; b=wTEEaE+UEp/6DBXTKWkCDtgvthX8/oVKcv3rGjf18/9UW9iylRLU+DqYCABA3mXl17 rZTLBODcl06jU6/q7PVdF6IZv1hyRYLYzDJ1dus73wyBcJCyduxvr4V48kebSIA22fMB a+fPI18mAzneHFJNQwoyKl9HtPma88g6IFphOY9Efejo38Gb7d/cb5n1h7Qkfys47Bwg dYkFbtdGcqBMS493VRqyN27GBy4s8ZaD8+Hn2b1+vmlIGH7W0hPbJoKtx8VzoODLZE91 Dw01NdSv5q8B66ll2YZXmrRRPsVqYKbBzlB2G5GJs+7WOmLNW5jPNOShG8pXwL7T79ah TQpA== X-Gm-Message-State: AOJu0Yx+encRm6As4kZDimYJCboGCpW08RAyxd29FwdFv4+3Fgw2i2b0 bL9jYZ6XfQiH+jb0Bujdl+PfArmGLER7/oR2iIdxO5l822Q2udvJEa8Mlf3ddq5gU4vMc1Cyp2Z V X-Google-Smtp-Source: AGHT+IF2m+WF7liHpgaIHHQ7Ne3CsbvoAQ5lV9A+OZLNEN/Bzb+Prm+ycON/StVQkVl4h4ITSxmJ6Q== X-Received: by 2002:a05:6a00:1143:b0:6e9:74d7:7092 with SMTP id b3-20020a056a00114300b006e974d77092mr432797pfm.24.1711558060777; Wed, 27 Mar 2024 09:47:40 -0700 (PDT) Received: from hermes.local (204-195-123-203.wavecable.com. [204.195.123.203]) by smtp.gmail.com with ESMTPSA id a33-20020a056a0011e100b006e580678dfbsm5160873pfu.193.2024.03.27.09.47.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 09:47:40 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Bruce Richardson Subject: [PATCH v16 06/15] eal: do not duplicate rte_init_alert() messages Date: Wed, 27 Mar 2024 09:45:24 -0700 Message-ID: <20240327164726.68732-7-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240327164726.68732-1-stephen@networkplumber.org> References: <20200814173441.23086-1-stephen@networkplumber.org> <20240327164726.68732-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The message already goes through logging, and does not need to be printed on stderr. Message level should be ALERT to match function name. Signed-off-by: Stephen Hemminger --- lib/eal/freebsd/eal.c | 3 +-- lib/eal/linux/eal.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c index 9825bcea0b..17b56f38aa 100644 --- a/lib/eal/freebsd/eal.c +++ b/lib/eal/freebsd/eal.c @@ -529,8 +529,7 @@ rte_eal_iopl_init(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* Launch threads, called at application init(). */ diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c index bffeb1f34e..23dc26b124 100644 --- a/lib/eal/linux/eal.c +++ b/lib/eal/linux/eal.c @@ -840,8 +840,7 @@ static int rte_eal_vfio_setup(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* -- 2.43.0