From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 6654743CAA;
	Wed, 27 Mar 2024 18:14:06 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 4FBB9402B2;
	Wed, 27 Mar 2024 18:14:06 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 149E9402A3
 for <dev@dpdk.org>; Wed, 27 Mar 2024 18:14:05 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 6450D2098E07; Wed, 27 Mar 2024 10:14:04 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 6450D2098E07
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1711559644;
 bh=pkLmAeAMRasNMVUr1Djnqy3Zbi+FyHFEVFEVMF1LnDM=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=I2MVbBp/XaN7VsGqtSvNkDnL0R6mkbTA8t4zyyPLGV7cD6uFifRMxjaAmWwinUK2B
 KKFrjhMw1vAkcXZAejZYfF3L4B5H4p8Sf7I6rVCutP58YG9CgUQGrn3uc4F28I9S4M
 GmunGctXvz9V5HnmpDkyPCtgHgxtpa+zBJsaxBns=
Date: Wed, 27 Mar 2024 10:14:04 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
 Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
 Pallavi Kadam <pallavi.kadam@intel.com>
Subject: Re: [PATCH v16 09/15] eal: initialize log before everything else
Message-ID: <20240327171404.GG8905@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20200814173441.23086-1-stephen@networkplumber.org>
 <20240327164726.68732-1-stephen@networkplumber.org>
 <20240327164726.68732-10-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240327164726.68732-10-stephen@networkplumber.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Wed, Mar 27, 2024 at 09:45:27AM -0700, Stephen Hemminger wrote:
> In order for all log messages (including CPU mismatch) to
> come out through the logging library, it must be initialized
> as early in rte_eal_init() as possible on all platforms.
> 
> Where it was done before was likely historical based on
> the support of non-OS isolated CPU's which required a shared
> memory buffer; that support was dropped before DPDK was
> publicly released.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---

Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>