From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0126843D74; Fri, 29 Mar 2024 03:53:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7D3B940268; Fri, 29 Mar 2024 03:53:58 +0100 (CET) Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com [209.85.210.52]) by mails.dpdk.org (Postfix) with ESMTP id 9434140042 for ; Fri, 29 Mar 2024 03:53:56 +0100 (CET) Received: by mail-ot1-f52.google.com with SMTP id 46e09a7af769-6e50e8dcc72so781348a34.3 for ; Thu, 28 Mar 2024 19:53:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1711680836; x=1712285636; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=oFRC2UcddFHQnQtv9X+fy/EypCiyHCDBcciCRxrzQUw=; b=no3M/sM2RuqatIrFJ50Z4J8vkkAtgbp883EwseY8mrXIizdvVsEuMefkQGCzNKkqE6 gwTAvLp+vpAxoRLx+LT16ZSvrecn7mEKdQbyo9MGthYAeeIT1A5CxpX1qflfRpudLK/Z XREaI7L+rB0nF2NPBmeSchh4kuz+D7q1YLJRPkcs9zj51etgqNCtDrTPImulgEYHRex4 ShbvKFq69ydjRsp3GhWabgEuLA3c27PlHj1HjKJn4TYgPwCGLkKV2bjB9DyBzmTEQbm8 x4XJHnTSgxQNgid09M1v5NycUDvUU+xCZM0LVhMseH5TRIqZ5u/7wDTLf0WxhW+pDloD U6OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711680836; x=1712285636; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oFRC2UcddFHQnQtv9X+fy/EypCiyHCDBcciCRxrzQUw=; b=D1jyExrxIpQxW24x/M8FgSN8CyBtfh8ESSh9zbLh3c67pi3HSF7B9JKdrGnzAI4aqe h7oSr5AI1vKZbhwH7VUkl2LmROaOuz3r5+0WPIEllgQUq8pfLG+w928wse2ozR0JAWsZ wiu/sY/+R+qN5MjNWPBExJbLUG8qC64qjhVgdJLq3eoxR1Pzkh2TguiP8xo1G+xhTEWo RGqo5XdmiBz9E/MuiZM3MxlAEcoPJ6ejHs5Bwf+p4+S6L5SoqribuBjo/cDcJ7cHxqX/ 4YNQ5mOtiG6kb9kQ568aN6Yo7K/Nv7e5msCE0MPKYCCEEYFv+dllgE/gZR7u0A8tZ/gc EAsw== X-Gm-Message-State: AOJu0YwYg9DLA5N5jRYs/mBnKbVtbbr38PnaRLo6Ile363iQmN2RetmJ TpbWqrTuuzRmT6gVYyZqra+uk0eaO684GBGpZqK/RFdVojUVygVRdg+XP9mqZf4= X-Google-Smtp-Source: AGHT+IFv0Yjg4arq+eCLuk5BObF9yZTlKw5TpY3Cg+R3aydYaNjEbdhck13EPDCmBIKDKchj2R8NRg== X-Received: by 2002:a9d:7d88:0:b0:6e6:97e5:7949 with SMTP id j8-20020a9d7d88000000b006e697e57949mr1061288otn.6.1711680835725; Thu, 28 Mar 2024 19:53:55 -0700 (PDT) Received: from hermes.local (204-195-123-203.wavecable.com. [204.195.123.203]) by smtp.gmail.com with ESMTPSA id z25-20020a656659000000b005e47afd5c5dsm1773478pgv.37.2024.03.28.19.53.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Mar 2024 19:53:55 -0700 (PDT) Date: Thu, 28 Mar 2024 19:53:53 -0700 From: Stephen Hemminger To: Andrey Ignatov Cc: dev@dpdk.org, Maxime Coquelin , Chenbo Xia , Wei Shen Subject: Re: [PATCH] vhost: optimize mbuf allocation in virtio Tx packed path Message-ID: <20240328195353.0dc838be@hermes.local> In-Reply-To: References: <20240328233338.56544-1-rdna@apple.com> <20240328164426.5b600cd1@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 28 Mar 2024 17:10:42 -0700 Andrey Ignatov wrote: > > > > You don't need always inline, the compiler will do it anyway. > > I can remove it in v2, but it's not completely obvious to me how is it > decided when to specify it explicitly and when not? > > I see plenty of __rte_always_inline in this file: > > % git grep -c '^static __rte_always_inline' lib/vhost/virtio_net.c > lib/vhost/virtio_net.c:66 Cargo cult really.