From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0436F43D73; Fri, 29 Mar 2024 00:52:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 830A040268; Fri, 29 Mar 2024 00:52:08 +0100 (CET) Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by mails.dpdk.org (Postfix) with ESMTP id DAB6D40042 for ; Fri, 29 Mar 2024 00:52:06 +0100 (CET) Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-6e74bd85f26so1334762b3a.1 for ; Thu, 28 Mar 2024 16:52:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1711669926; x=1712274726; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yAF0QcNolbeVwenp7DtZF+zQ0hF0KtYkc9wGxHtYzMM=; b=Jx3Wf8ZgrHYJ9Gy3y8g02Ntgox3ShOBoawSJIWOjpfZg3G6wpxqcvf7JdEdqKY6Dg7 /scUlZyk2CuTwrua/8tCawKhRUnIADPvqhjYjM/hU47sLoIrPC1p2N2/0V/OUcGLiTYi ip0WEiBh6GCcooyUeMbuRejRWuWCUf3bnLkvHRoIXzWl24FgjR3BZZW8LFlFc15+PZBA fYx1EkeWdHfrQDr8VSeZJFzqKrEUAz5ZPPoQJ6y45WmQJeOJIBANCIM5n15jKdBq3sZM AOS3ZAXlC3Lg9bi+zt5IcxEXjPXP13S45qh7XJjK1bnyNURXL8eV/DjKbg05NvTEddtu uySA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711669926; x=1712274726; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yAF0QcNolbeVwenp7DtZF+zQ0hF0KtYkc9wGxHtYzMM=; b=ehDJ9xHCNWJ7OJvL8HwzXmUXkPvh0a5kuCBujDKAmsv+NIEhJWBq/Yyx2mxTCOJgv9 P4NFlQAidgqCGq9q9XtsvwN26Glh7imByO2ZTaP5pT4gIEYyT8kej1bYqxWJVVp8Rq3q x6KKbINqDTrybbtiObJ9Dhur4zzojAkcVY4bnh/l8l1r4BUVK+tXo++l8U7cqnVpc66d thud2EAGxoYnw1nWHghgxwqq/C7P/G2MQ7Umj6aBi8kUaCJW/FtrvGVO9ULfBUEdAMoT 4Ijvjvtm4GjY5EAcAnwnFPij1oSC54Nqb73ysghlYeOjiWI6x8ptAmPaWx714yq1PxCx ifiw== X-Gm-Message-State: AOJu0YxOCiTcLXfty/eQLPOMGg2jRzEVPt4tSWIfF5hGh4TH+AwxVW93 2NYbMe7r4rcWtuwxKB0tFNCOFvVYHu4sEtpKR5nxIyXMNHOaH6/rXz3nXaZPJBA7LXCKcZg4nH+ i X-Google-Smtp-Source: AGHT+IHI7SO3Ki9YxVsQMQZ0oKXjcQp04SLEBRmVT5Fp9np11efJQG/R5hqMFAgZtf4/Wev2q6mcPA== X-Received: by 2002:a05:6a00:1910:b0:6ea:ca90:3459 with SMTP id y16-20020a056a00191000b006eaca903459mr842084pfi.32.1711669925895; Thu, 28 Mar 2024 16:52:05 -0700 (PDT) Received: from hermes.local (204-195-123-203.wavecable.com. [204.195.123.203]) by smtp.gmail.com with ESMTPSA id g21-20020a631115000000b005df58c83e89sm1875650pgl.84.2024.03.28.16.52.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Mar 2024 16:52:05 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v18 00/15] Logging unification and improvements Date: Thu, 28 Mar 2024 16:49:30 -0700 Message-ID: <20240328235156.5768-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20200814173441.23086-1-stephen@networkplumber.org> References: <20200814173441.23086-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Improvements and unification of logging library. This version works on all platforms: Linux, Windows and FreeBSD. This is update to rework patch set. It adds several new features to the console log output. * Putting a timestamp on console output which is useful for analyzing performance of startup codes. Timestamp is optional and must be enabled on command line. * Displaying console output with colors. It uses the standard conventions used by many other Linux commands for colorized display. The default is to enable color if the console output is going to a terminal. But it can be always on or disabled by command line flag. This default was chosen based on what dmesg(1) command does. I find color helpful because DPDK drivers and libraries print lots of not very useful messages. And having error messages highlighted in bold face helps. This might also get users to pay more attention to error messages. Many bug reports have earlier messages that are lost because there are so many info messages. * Add support for automatic detection of systemd journal protocol. If running as systemd service will get enhanced logging. * Use of syslog is optional and the meaning of the --syslog flag has changed. The default is *not* to use syslog. Add myself as maintainer for log because by now have added more than previous authors... v18 - handle more Windows MSVC incompatabilities. Stephen Hemminger (15): maintainers: add for log library windows: make getopt functions have const properties windows: add os shim for localtime_r windows: common wrapper for vasprintf and asprintf eal: make eal_log_level_parse common eal: do not duplicate rte_init_alert() messages eal: change rte_exit() output to match rte_log() log: move handling of syslog facility out of eal eal: initialize log before everything else log: drop syslog support, and make code common log: add hook for printing log messages log: add timestamp option log: add optional support of syslog log: add support for systemd journal log: colorize log output MAINTAINERS | 1 + app/test/test_eal_flags.c | 64 +- doc/guides/linux_gsg/linux_eal_parameters.rst | 27 - doc/guides/prog_guide/log_lib.rst | 57 ++ drivers/bus/pci/pci_common.c | 32 - lib/eal/common/eal_common_debug.c | 11 +- lib/eal/common/eal_common_options.c | 126 ++-- lib/eal/common/eal_options.h | 5 + lib/eal/common/eal_private.h | 10 - lib/eal/freebsd/eal.c | 64 +- lib/eal/linux/eal.c | 68 +- lib/eal/windows/eal.c | 77 +-- lib/eal/windows/getopt.c | 23 +- lib/eal/windows/include/getopt.h | 8 +- lib/eal/windows/include/rte_os_shim.h | 58 ++ lib/log/log.c | 652 +++++++++++++++++- lib/log/log_freebsd.c | 5 +- lib/log/log_internal.h | 25 +- lib/log/log_linux.c | 61 -- lib/log/log_windows.c | 18 - lib/log/meson.build | 5 +- lib/log/version.map | 4 +- 22 files changed, 973 insertions(+), 428 deletions(-) delete mode 100644 lib/log/log_linux.c delete mode 100644 lib/log/log_windows.c -- 2.43.0