From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 49DB243D73; Fri, 29 Mar 2024 00:52:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1F964427E5; Fri, 29 Mar 2024 00:52:21 +0100 (CET) Received: from mail-oa1-f53.google.com (mail-oa1-f53.google.com [209.85.160.53]) by mails.dpdk.org (Postfix) with ESMTP id 59B8F4114B for ; Fri, 29 Mar 2024 00:52:12 +0100 (CET) Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-222b6a05bb1so965779fac.3 for ; Thu, 28 Mar 2024 16:52:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1711669931; x=1712274731; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jpuKRgSOIbpBBbsAGPHwAR/lg4j9u3JMjpynNGAPSTY=; b=HlQUSSo4tv6XoGEVSjN63GGzlO+Uj6NmxQYMTkD++ze+IFSjBXYdlq5SIDnPixQ07O Rn1z2NnSeYHfuW/0QkJIgCBsbgP7Xc33+aAr3Ca2S6a/HPt8eVEbu+ULmxbMf4ZpaxdW 32GAhO84mH0gAuD/Why8iZUSCbJMU6WFMyZAdo1bEdAwyvTvScS5ahwlfFFmpCUqJy0L tEFrwJqU6+CPSRCndjK8PJ4VpUkrpDXLW2XgmKLqDGn4KrZvD1xgM/Edxp4C/WfNDx7/ N23hYPn3eIHmAZd/FYYsZzaJK3A3h6P78/s1fwgXgyHw5cC/eCC0aHQWBpg39DdJ4tAW tRYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711669931; x=1712274731; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jpuKRgSOIbpBBbsAGPHwAR/lg4j9u3JMjpynNGAPSTY=; b=iuFnh9Tg2NGBIJ+M3A39JbU0e95Q8KQjsovBIkWRjAReBKUk1AFBu4yHI/fNN7Vnea n8rC6k4uJgqkJSY5JZDWWywQL7NLHXTmO4earvLvMszpJtxwP2JA0VHMcILSxEkXgJ+j s7w1nof84nRlzRvkQwGFuaQkIJJ6EIQ2MqT5UJfk7yaGpFBidTiTxFVHBQQWsBEEbKMA 6O80z5ecTYMfc7hNBbNpf4TrI0ry17zyvXDON6WYEk3VKXdzLqupMorr0Wt04A+wsKq4 E2trhT6zFLRdb0Wh3a60LCaRpIgsmCQWB9w7+On0qlEh6/UifppDQ4M5j1e/zxvV1UN3 nwAA== X-Gm-Message-State: AOJu0YyXp/cGlfHqmdyOFTdLhJToGptfshh/E6HxAIO7otRvGjfkz9VH RuZ2tOLypKyPQr83oP3mXwuONNCtcLki9MkSKmeL0XYMyrN0IWuUpz8vFgci3p9ixX1IBmnyXnQ e X-Google-Smtp-Source: AGHT+IFm94rrjJdgAuSaaQcLuozuN40YAHnteQ6tNVeZihoZRhAS/SlRim+iFqFHVyekdePZ2fC9Tg== X-Received: by 2002:a05:6870:c34f:b0:229:c1d4:83bf with SMTP id e15-20020a056870c34f00b00229c1d483bfmr685678oak.8.1711669931561; Thu, 28 Mar 2024 16:52:11 -0700 (PDT) Received: from hermes.local (204-195-123-203.wavecable.com. [204.195.123.203]) by smtp.gmail.com with ESMTPSA id g21-20020a631115000000b005df58c83e89sm1875650pgl.84.2024.03.28.16.52.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Mar 2024 16:52:11 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Tyler Retzlaff , Bruce Richardson Subject: [PATCH v18 06/15] eal: do not duplicate rte_init_alert() messages Date: Thu, 28 Mar 2024 16:49:36 -0700 Message-ID: <20240328235156.5768-7-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240328235156.5768-1-stephen@networkplumber.org> References: <20200814173441.23086-1-stephen@networkplumber.org> <20240328235156.5768-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The message already goes through logging, and does not need to be printed on stderr. Message level should be ALERT to match function name. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff --- lib/eal/freebsd/eal.c | 3 +-- lib/eal/linux/eal.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c index 9825bcea0b..17b56f38aa 100644 --- a/lib/eal/freebsd/eal.c +++ b/lib/eal/freebsd/eal.c @@ -529,8 +529,7 @@ rte_eal_iopl_init(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* Launch threads, called at application init(). */ diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c index bffeb1f34e..23dc26b124 100644 --- a/lib/eal/linux/eal.c +++ b/lib/eal/linux/eal.c @@ -840,8 +840,7 @@ static int rte_eal_vfio_setup(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* -- 2.43.0