From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7B6B43D8B; Sat, 30 Mar 2024 04:05:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 37E6D41153; Sat, 30 Mar 2024 04:04:55 +0100 (CET) Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by mails.dpdk.org (Postfix) with ESMTP id F1F1E40647 for ; Sat, 30 Mar 2024 04:04:46 +0100 (CET) Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-6eaf1a3e917so450447b3a.2 for ; Fri, 29 Mar 2024 20:04:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1711767885; x=1712372685; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jpuKRgSOIbpBBbsAGPHwAR/lg4j9u3JMjpynNGAPSTY=; b=imKGv4sLKtQJpGw9vJzQUW4NgQ5VtGQ5oKxQ/yPRZACk3Th5ysLlBLewRwNiwCfpVO +W98sjsVd86DTm7TpjxIlrURNKIBdPWX+kv0NO+DOtZicXIlwrdUzqbzgBs3Q0qWcCvB OpkY1gu+Bukl1k1HUyWM7mcDlQNCldStWZBI/L1x7iC2E6R5AMJlh+sVB6Z6eK0DPvyt 6iDZHlqUaHxxQJ5XQrRVEJO4VGSUoC9IVjQ/TeBG+nCPoh73jxEkan7fQ4NJ9bSSgr0w zCp68TIxEmWVTcxFHzstnFbgbAUyNpzFtHCDW6BGDkKKVk0dg/Bzr1iHE7KT/L92RGT6 EtFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711767885; x=1712372685; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jpuKRgSOIbpBBbsAGPHwAR/lg4j9u3JMjpynNGAPSTY=; b=hH2HkFGBSTjZ1La9SG86ShyIrj5A24hoYLbt6O72uh6oxk4ZhOkQ34ufDuv/Qx0crs PtN9s7tS45Zt0sUkpfVWHP+LhHx/+Sjr+WBSNi5E3ikyiW/XbrDGtoy8d4lDKdXtxC0O q2ZbqG11rR9wPKKDRfXOxn2v5GLWdvze6eEr1hKoS/1Jhj9+CNS1Updf4kGxv+meHtd5 WQAKXYQiYrem5D+9kAmlIzQWHxEXd0BknViy6meDcsc/qndSoOyp92grtS6kEChfZ2PG Rc9fjcnPJyKkT0lVJEsWMARD4Joxz1B3R0uQBR5MC9pidXQESyVd/aqbvvcMZF5FL+Ag ZzTA== X-Gm-Message-State: AOJu0Yz0AfNE/xMDXlLAy2nQBr0Hptt31wzXG+f27O6lSiHduhXnM3oK qbbjXnLQE+EcZOmvIIpkpjl1s4SNNy/0Q0wCGf14IaFF2Wxnn+jVYoKDK47biyuFCpMc2pkfFWo f X-Google-Smtp-Source: AGHT+IHPMeotA3ECprMtGnXTGsR+CQ0wjNbQLUaeBQJlnpVOQSg/q7lBuosU+SFj68XXv5RGkD+L3Q== X-Received: by 2002:a05:6a00:b46:b0:6ea:8e21:e94d with SMTP id p6-20020a056a000b4600b006ea8e21e94dmr4178928pfo.26.1711767885193; Fri, 29 Mar 2024 20:04:45 -0700 (PDT) Received: from hermes.local (204-195-123-203.wavecable.com. [204.195.123.203]) by smtp.gmail.com with ESMTPSA id o3-20020a056a00214300b006e6288ef4besm3655486pfk.54.2024.03.29.20.04.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Mar 2024 20:04:44 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Tyler Retzlaff , Bruce Richardson Subject: [PATCH v19 06/15] eal: do not duplicate rte_init_alert() messages Date: Fri, 29 Mar 2024 20:00:49 -0700 Message-ID: <20240330030429.4630-7-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240330030429.4630-1-stephen@networkplumber.org> References: <20200814173441.23086-1-stephen@networkplumber.org> <20240330030429.4630-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The message already goes through logging, and does not need to be printed on stderr. Message level should be ALERT to match function name. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff --- lib/eal/freebsd/eal.c | 3 +-- lib/eal/linux/eal.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c index 9825bcea0b..17b56f38aa 100644 --- a/lib/eal/freebsd/eal.c +++ b/lib/eal/freebsd/eal.c @@ -529,8 +529,7 @@ rte_eal_iopl_init(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* Launch threads, called at application init(). */ diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c index bffeb1f34e..23dc26b124 100644 --- a/lib/eal/linux/eal.c +++ b/lib/eal/linux/eal.c @@ -840,8 +840,7 @@ static int rte_eal_vfio_setup(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* -- 2.43.0